mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-31 05:09:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibJS: Remove our existing Temporal implementation

Browse source 
Our Temporal implementation is woefully out of date. The spec has been
so vastly rewritten that it is unfortunately not practical to update our
implementation in-place. Even just removing Temporal objects that were
removed from the spec, or updating any of the simpler remaining objects,
has proven to be a mess in previous attempts.

So, this removes our Temporal implementation. AOs used by other specs
are left intact.
This commit is contained in:
Timothy Flynn 2024-11-16 12:51:53 -05:00 • committed by Tim Flynn
commit f7517c5b8d
Notes: github-actions[bot] 2024-11-21 00:06:58 +00:00
386 changed files with 8 additions and 33007 deletions
Download patch file Download diff file Expand all files Collapse all files

133
Libraries/LibJS/Tests/builtins/Temporal/Duration/Duration.from.js
View file

@ -1,133 +0,0 @@
const expectDurationOneToTen = duration => {
expect(duration.years).toBe(1);
expect(duration.months).toBe(2);
expect(duration.weeks).toBe(3);
expect(duration.days).toBe(4);
expect(duration.hours).toBe(5);
expect(duration.minutes).toBe(6);
expect(duration.seconds).toBe(7);
expect(duration.milliseconds).toBe(8);
expect(duration.microseconds).toBe(9);
expect(duration.nanoseconds).toBe(10);
};
describe("correct behavior", () => {
test("length is 1", () => {
expect(Temporal.Duration.from).toHaveLength(1);
});
test("Duration instance argument", () => {
const duration = Temporal.Duration.from(
new Temporal.Duration(1, 2, 3, 4, 5, 6, 7, 8, 9, 10)
);
expectDurationOneToTen(duration);
});
test("Duration-like object argument", () => {
const duration = Temporal.Duration.from({
years: 1,
months: 2,
weeks: 3,
days: 4,
hours: 5,
minutes: 6,
seconds: 7,
milliseconds: 8,
microseconds: 9,
nanoseconds: 10,
});
expectDurationOneToTen(duration);
});
test("NaN value becomes zero", () => {
// NOTE: NaN does *not* throw a RangeError anymore - which is questionable, IMO - as of:
// https://github.com/tc39/proposal-temporal/commit/8c854507a52efbc6e9eb2642f0f928df38e5c021
const duration = Temporal.Duration.from({ years: "foo" });
expect(duration.years).toBe(0);
});
test("Duration string argument", () => {
// FIXME: yes, this needs 11 instead of 10 for nanoseconds for the test to pass.
// See comment in parse_temporal_duration_string().
const duration = Temporal.Duration.from("P1Y2M3W4DT5H6M7.008009011S");
expectDurationOneToTen(duration);
});
});
describe("errors", () => {
test("Invalid duration-like object", () => {
expect(() => {
Temporal.Duration.from({});
}).toThrowWithMessage(TypeError, "Invalid duration-like object");
});
test("Invalid duration property value", () => {
expect(() => {
Temporal.Duration.from({ years: 1.23 });
}).toThrowWithMessage(
RangeError,
"Invalid value for duration property 'years': must be an integer, got 1.2" // ...29999999999999 - let's not include that in the test :^)
);
});
test("invalid duration string", () => {
expect(() => {
Temporal.Duration.from("foo");
}).toThrowWithMessage(RangeError, "Invalid duration string 'foo'");
});
test("invalid duration string: fractional hours proceeded by minutes or seconds", () => {
const values = [
"PT1.23H1M",
"PT1.23H1.23M",
"PT1.23H1S",
"PT1.23H1.23S",
"PT1.23H1M1S",
"PT1.23H1M1.23S",
"PT1.23H1.23M1S",
"PT1.23H1.23M1.23S",
];
for (const value of values) {
expect(() => {
Temporal.Duration.from(value);
}).toThrowWithMessage(
RangeError,
`Invalid duration string '${value}': fractional hours must not be proceeded by minutes or seconds`
);
}
});
test("invalid duration string: fractional minutes proceeded by seconds", () => {
const values = ["PT1.23M1S", "PT1.23M1.23S"];
for (const value of values) {
expect(() => {
Temporal.Duration.from(value);
}).toThrowWithMessage(
RangeError,
`Invalid duration string '${value}': fractional minutes must not be proceeded by seconds`
);
}
});
test("invalid duration string: exceed duration limits", () => {
const values = [
"P4294967296Y", // abs(years) >= 2**32
"P4294967296M", // abs(months) >= 2**32
"P4294967296W", // abs(weeks) >= 2**32
"P104249991375D", // days >= 2*53 seconds
"PT2501999792984H", // hours >= 2*53 seconds
"PT150119987579017M", // minutes >= 2*53 seconds
"PT9007199254740992S", // seconds >= 2*53 seconds
];
for (const value of values) {
expect(() => {
Temporal.Duration.from(value);
}).toThrowWithMessage(RangeError, `Invalid duration`);
expect(() => {
Temporal.Duration.from("-" + value);
}).toThrowWithMessage(RangeError, `Invalid duration`);
}
});
});