mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-04 23:30:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibGC+Everywhere: Factor out a LibGC from LibJS

Browse source 
Resulting in a massive rename across almost everywhere! Alongside the
namespace change, we now have the following names:

 * JS::NonnullGCPtr -> GC::Ref
 * JS::GCPtr -> GC::Ptr
 * JS::HeapFunction -> GC::Function
 * JS::CellImpl -> GC::Cell
 * JS::Handle -> GC::Root
This commit is contained in:
Shannon Booth 2024-11-15 04:01:23 +13:00 • committed by Andreas Kling
commit f87041bf3a
Notes: github-actions[bot] 2024-11-15 13:50:17 +00:00
1722 changed files with 9939 additions and 9906 deletions
Download patch file Download diff file Expand all files Collapse all files

16
Libraries/LibWeb/HTML/HTMLOptionsCollection.cpp
View file

@ -16,9 +16,9 @@
namespace Web::HTML {
JS_DEFINE_ALLOCATOR(HTMLOptionsCollection);
GC_DEFINE_ALLOCATOR(HTMLOptionsCollection);
JS::NonnullGCPtr<HTMLOptionsCollection> HTMLOptionsCollection::create(DOM::ParentNode& root, Function<bool(DOM::Element const&)> filter)
GC::Ref<HTMLOptionsCollection> HTMLOptionsCollection::create(DOM::ParentNode& root, Function<bool(DOM::Element const&)> filter)
{
return root.realm().create<HTMLOptionsCollection>(root, move(filter));
}
@ -123,13 +123,13 @@ WebIDL::ExceptionOr<void> HTMLOptionsCollection::set_value_of_indexed_property(u
WebIDL::ExceptionOr<void> HTMLOptionsCollection::add(HTMLOptionOrOptGroupElement element, Optional<HTMLElementOrElementIndex> before)
{
auto resolved_element = element.visit(
[](auto& e) -> JS::Handle<HTMLElement> {
return JS::make_handle(static_cast<HTML::HTMLElement&>(*e));
[](auto& e) -> GC::Root<HTMLElement> {
return GC::make_root(static_cast<HTML::HTMLElement&>(*e));
});
JS::GCPtr<DOM::Node> before_element;
if (before.has_value() && before->has<JS::Handle<HTMLElement>>())
before_element = before->get<JS::Handle<HTMLElement>>().ptr();
GC::Ptr<DOM::Node> before_element;
if (before.has_value() && before->has<GC::Root<HTMLElement>>())
before_element = before->get<GC::Root<HTMLElement>>().ptr();
// 1. If element is an ancestor of the select element on which the HTMLOptionsCollection is rooted, then throw a "HierarchyRequestError" DOMException.
if (resolved_element->is_ancestor_of(root()))
@ -144,7 +144,7 @@ WebIDL::ExceptionOr<void> HTMLOptionsCollection::add(HTMLOptionOrOptGroupElement
return {};
// 4. If before is a node, then let reference be that node. Otherwise, if before is an integer, and there is a beforeth node in the collection, let reference be that node. Otherwise, let reference be null.
JS::GCPtr<DOM::Node> reference;
GC::Ptr<DOM::Node> reference;
if (before_element)
reference = move(before_element);