LibWeb/CSP: Implement the form-action directive

This commit is contained in:
Luke Wilde 2024-12-04 11:24:19 +00:00 committed by Alexander Kalenik
commit f9247116b1
Notes: github-actions[bot] 2025-08-06 22:46:59 +00:00
5 changed files with 71 additions and 0 deletions

View file

@ -50,6 +50,7 @@ set(SOURCES
ContentSecurityPolicy/Directives/DirectiveFactory.cpp
ContentSecurityPolicy/Directives/DirectiveOperations.cpp
ContentSecurityPolicy/Directives/FontSourceDirective.cpp
ContentSecurityPolicy/Directives/FormActionDirective.cpp
ContentSecurityPolicy/Directives/FrameSourceDirective.cpp
ContentSecurityPolicy/Directives/ImageSourceDirective.cpp
ContentSecurityPolicy/Directives/KeywordSources.cpp

View file

@ -11,6 +11,7 @@
#include <LibWeb/ContentSecurityPolicy/Directives/Directive.h>
#include <LibWeb/ContentSecurityPolicy/Directives/DirectiveFactory.h>
#include <LibWeb/ContentSecurityPolicy/Directives/FontSourceDirective.h>
#include <LibWeb/ContentSecurityPolicy/Directives/FormActionDirective.h>
#include <LibWeb/ContentSecurityPolicy/Directives/FrameSourceDirective.h>
#include <LibWeb/ContentSecurityPolicy/Directives/ImageSourceDirective.h>
#include <LibWeb/ContentSecurityPolicy/Directives/ManifestSourceDirective.h>
@ -41,6 +42,9 @@ GC::Ref<Directive> create_directive(GC::Heap& heap, String name, Vector<String>
if (name == Names::FontSrc)
return heap.allocate<FontSourceDirective>(move(name), move(value));
if (name == Names::FormAction)
return heap.allocate<FormActionDirective>(move(name), move(value));
if (name == Names::FrameSrc)
return heap.allocate<FrameSourceDirective>(move(name), move(value));

View file

@ -0,0 +1,38 @@
/*
* Copyright (c) 2024, Luke Wilde <luke@ladybird.org>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
#include <LibWeb/ContentSecurityPolicy/Directives/DirectiveOperations.h>
#include <LibWeb/ContentSecurityPolicy/Directives/FormActionDirective.h>
#include <LibWeb/ContentSecurityPolicy/Directives/Names.h>
#include <LibWeb/Fetch/Infrastructure/HTTP/Requests.h>
namespace Web::ContentSecurityPolicy::Directives {
GC_DEFINE_ALLOCATOR(FormActionDirective);
FormActionDirective::FormActionDirective(String name, Vector<String> value)
: Directive(move(name), move(value))
{
}
Directive::Result FormActionDirective::pre_navigation_check(GC::Ref<Fetch::Infrastructure::Request const> request, NavigationType navigation_type, GC::Ref<Policy const> policy) const
{
// 1. Assert: policy is unused in this algorithm.
// FIXME: File spec issue, because this is not the case. The policy is required to resolve 'self'.
// 2. If navigation type is "form-submission":
if (navigation_type == NavigationType::FormSubmission) {
// 1. If the result of executing § 6.7.2.5 Does request match source list? on request, this directives value,
// and a policy, is "Does Not Match", return "Blocked".
if (does_request_match_source_list(request, value(), policy) == MatchResult::DoesNotMatch)
return Result::Blocked;
}
// 3. Return "Allowed".
return Result::Allowed;
}
}

View file

@ -0,0 +1,27 @@
/*
* Copyright (c) 2024, Luke Wilde <luke@ladybird.org>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
#pragma once
#include <LibWeb/ContentSecurityPolicy/Directives/Directive.h>
namespace Web::ContentSecurityPolicy::Directives {
// https://w3c.github.io/webappsec-csp/#directive-form-action
class FormActionDirective final : public Directive {
GC_CELL(FormActionDirective, Directive)
GC_DECLARE_ALLOCATOR(FormActionDirective);
public:
virtual ~FormActionDirective() = default;
virtual Result pre_navigation_check(GC::Ref<Fetch::Infrastructure::Request const>, NavigationType, GC::Ref<Policy const>) const override;
private:
FormActionDirective(String name, Vector<String> value);
};
}

View file

@ -141,6 +141,7 @@ class ConnectSourceDirective;
class DefaultSourceDirective;
class Directive;
class FontSourceDirective;
class FormActionDirective;
class FrameSourceDirective;
class ImageSourceDirective;
class ManifestSourceDirective;