mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-09-03 08:08:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Compare anchor/focus offsets in selection.isCollapsed

Browse source 
The "isCollapsed" attribute on a selection must "return true if and only
if the anchor and focus are the same".

In addition to checking that the anchor and focus belonged to the same
DOM node, we now also check that they refer to the same position within
the node.

With this change Ladybird passes all the subtests in the "isCollapsed"
WPT suite.

https://wpt.live/selection/isCollapsed.html
This commit is contained in:
John Diamond 2024-10-12 02:42:55 +02:00 • committed by Andreas Kling
commit fadb14d31d
Notes: github-actions[bot] 2024-10-12 13:01:26 +00:00
3 changed files with 32 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Userland/Libraries/LibWeb/Selection/Selection.cpp
View file

@ -96,7 +96,10 @@ bool Selection::is_collapsed() const
{
// The attribute must return true if and only if the anchor and focus are the same
// (including if both are null). Otherwise it must return false.
return const_cast<Selection*>(this)->anchor_node() == const_cast<Selection*>(this)->focus_node();
if (!m_range)
return true;
return const_cast<Selection*>(this)->anchor_node() == const_cast<Selection*>(this)->focus_node()
&& m_range->start_offset() == m_range->end_offset();
}
// https://w3c.github.io/selection-api/#dom-selection-rangecount