From fbf8ffe872b61378755091d8872279395ad0938a Mon Sep 17 00:00:00 2001 From: Andrew Kaster Date: Mon, 23 Jun 2025 12:12:51 -0600 Subject: [PATCH] AK: Only propagate delayload of dbghelp.dll for static builds When AK is a shared library, the flag should be applied to the link of the dll. When it's a static library, we need to apply it to the executable that links against it instead. Co-Authored-By: ayeteadoe --- AK/CMakeLists.txt | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/AK/CMakeLists.txt b/AK/CMakeLists.txt index 25a132d66aa..16c8258dbc4 100644 --- a/AK/CMakeLists.txt +++ b/AK/CMakeLists.txt @@ -77,7 +77,11 @@ if (WIN32) target_link_libraries(AK PRIVATE clang_rt.builtins-x86_64.lib) target_link_libraries(AK PRIVATE Bcrypt.lib) target_link_libraries(AK PRIVATE delayimp.lib) - target_link_options(AK INTERFACE /DELAYLOAD:dbghelp.dll) + set(DELAYLOAD_DBGHLP_VISIBILITY PRIVATE) + if (NOT BUILD_SHARED_LIBS) + set(DELAYLOAD_DBGHLP_VISIBILITY INTERFACE) + endif() + target_link_options(AK ${DELAYLOAD_DBGHLP_VISIBILITY} /DELAYLOAD:dbghelp.dll) elseif (APPLE) set(ASSERTION_HANDLER_VISIBILITY PRIVATE) if (NOT BUILD_SHARED_LIBS)