mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-28 11:49:44 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibWeb/DOM: Set Document's origin in JS constructor

Browse source 
We were missing this spec step, which meant that the created
document had no origin, causing a crash when accessed for same-origin
checks.
This commit is contained in:
Shannon Booth 2025-06-18 14:52:11 +12:00 • committed by Jelle Raaijmakers
commit fc62a05c98
Notes: github-actions[bot] 2025-06-18 06:50:19 +00:00
3 changed files with 11 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Libraries/LibWeb/DOM/Document.cpp
View file

@ -424,9 +424,13 @@ WebIDL::ExceptionOr<GC::Ref<Document>> Document::create_and_initialize(Type type
return document; return document;
} }
WebIDL::ExceptionOr<GC::Ref<Document>> Document::construct_impl(JS::Realm& realm) // https://dom.spec.whatwg.org/#dom-document-document
GC::Ref<Document> Document::construct_impl(JS::Realm& realm)
{ {
return Document::create(realm); // The new Document() constructor steps are to set this’s origin to the origin of current global object’s associated Document. [HTML]
auto document = Document::create(realm);
document->set_origin(as<HTML::Window>(HTML::current_principal_global_object()).associated_document().origin());
return document;
} }
GC::Ref<Document> Document::create(JS::Realm& realm, URL::URL const& url) GC::Ref<Document> Document::create(JS::Realm& realm, URL::URL const& url)

2
Libraries/LibWeb/DOM/Document.h
View file

@ -178,7 +178,7 @@ public:
[[nodiscard]] static GC::Ref<Document> create(JS::Realm&, URL::URL const& url = URL::about_blank()); [[nodiscard]] static GC::Ref<Document> create(JS::Realm&, URL::URL const& url = URL::about_blank());
[[nodiscard]] static GC::Ref<Document> create_for_fragment_parsing(JS::Realm&); [[nodiscard]] static GC::Ref<Document> create_for_fragment_parsing(JS::Realm&);
static WebIDL::ExceptionOr<GC::Ref<Document>> construct_impl(JS::Realm&); static GC::Ref<Document> construct_impl(JS::Realm&);
virtual ~Document() override; virtual ~Document() override;
// AD-HOC: This number increments whenever a node is added or removed from the document, or an element attribute changes. // AD-HOC: This number increments whenever a node is added or removed from the document, or an element attribute changes.

4
Tests/LibWeb/Crash/DOM/document-constructor-no-origin.html Normal file
View file

@ -0,0 +1,4 @@
<!DOCTYPE html>
<script>
let d = new Document().domain;
</script>