mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-12 02:59:45 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Don't strip leading '?' in query initializing a URL

Browse source 
In our implementation of url-initialize, we were invoking the
constructor of URLSearchParams:

https://url.spec.whatwg.org/#dom-urlsearchparams-urlsearchparams

Instead of the 'initialize' AO:

https://url.spec.whatwg.org/#urlsearchparams-initialize

This has the small difference of stripping any leading '?' from the
query (which we are not meant to be doing!).
This commit is contained in:
Shannon Booth 2024-08-06 23:27:11 +12:00 • committed by Tim Ledbetter
commit fd4e943e12
Notes: github-actions[bot] 2024-08-06 22:09:12 +00:00
5 changed files with 34 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

22
Tests/LibWeb/Text/expected/URL/url.txt
View file

@ -152,6 +152,17 @@ pathname => '/test'
search => '?test'
searchParams => 'test='
hash => ''
new URL('??a=b&c=d', 'http://example.org/foo/bar')
protocol => 'http:'
username => ''
password => ''
host => 'example.org'
hostname => 'example.org'
port => ''
pathname => '/foo/bar'
search => '??a=b&c=d'
searchParams => '%3Fa=b&c=d'
hash => ''
=========================================
URL.parse('ftp://serenityos.org:21', undefined)
protocol => 'ftp:'
@ -307,3 +318,14 @@ pathname => '/test'
search => '?test'
searchParams => 'test='
hash => ''
URL.parse('??a=b&c=d', 'http://example.org/foo/bar')
protocol => 'http:'
username => ''
password => ''
host => 'example.org'
hostname => 'example.org'
port => ''
pathname => '/foo/bar'
search => '??a=b&c=d'
searchParams => '%3Fa=b&c=d'
hash => ''