mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-08 17:19:13 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Only set selection focus if an associated DOM node was found

Browse source 
The relation from a paintable to a DOM node is not always set.
This commit is contained in:
Jelle Raaijmakers 2024-12-06 16:32:20 +01:00 • committed by Jelle Raaijmakers
commit fd949ee3dd
Notes: github-actions[bot] 2024-12-10 13:55:19 +00:00
3 changed files with 21 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Libraries/LibWeb/Page/EventHandler.cpp
View file

@ -596,9 +596,8 @@ EventResult EventHandler::handle_mousemove(CSSPixelPoint viewport_position, CSSP
if (m_in_mouse_selection) {
auto hit = paint_root()->hit_test(viewport_position, Painting::HitTestType::TextCursor);
if (m_mouse_selection_target) {
if (hit.has_value()) {
if (hit.has_value() && hit->paintable->dom_node())
m_mouse_selection_target->set_selection_focus(*hit->paintable->dom_node(), hit->index_in_node);
}
} else {
if (start_index.has_value() && hit.has_value() && hit->dom_node()) {
if (auto selection = document.get_selection()) {

1
Tests/LibWeb/Text/expected/Editing/selection-in-contenteditable-crash-regression.txt Normal file
View file

@ -0,0 +1 @@
PASS (did not crash)

19
Tests/LibWeb/Text/input/Editing/selection-in-contenteditable-crash-regression.html Normal file
View file

@ -0,0 +1,19 @@
<script src="../include.js"></script>
<style>
div {
font-size: 10px;
}
</style>
<div contenteditable="true">a<br><br><div id="b">b</div></div>
<script>
test(() => {
var bDiv = document.querySelector('div#b');
var bBounds = bDiv.getBoundingClientRect();
// Drag a selection from inside the #b div to just above it.
internals.mouseDown(bBounds.x + 2, bBounds.y + 5);
internals.movePointerTo(bBounds.x + 2, bBounds.y - 5);
println('PASS (did not crash)');
});
</script>