mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-08 09:09:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Don't crash when parsing HTMLInputElement invalid time values

Browse source
This commit is contained in:
Tim Ledbetter 2024-08-20 21:56:04 +01:00 • committed by Tim Ledbetter
commit fe42e2719f
Notes: github-actions[bot] 2024-08-20 22:31:28 +00:00
3 changed files with 20 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Tests/LibWeb/Text/expected/HTML/HTMLInputElement-invalid-time-digits.txt Normal file
View file

@ -0,0 +1 @@
PASS (didn't crash)

13
Tests/LibWeb/Text/input/HTML/HTMLInputElement-invalid-time-digits.html Normal file
View file

@ -0,0 +1,13 @@
<!DOCTYPE html>
<script src="../include.js"></script>
<script>
test(() => {
const inputElement = document.createElement("input");
inputElement.type = "time";
inputElement.value = "invalid";
inputElement.value = "xx:34:56";
inputElement.value = "12:xx:56";
inputElement.value = "12:34:xx";
println("PASS (didn't crash)");
});
</script>

6
Userland/Libraries/LibWeb/HTML/Dates.cpp
View file

@ -183,11 +183,15 @@ bool is_valid_time_string(StringView value)
return false; return false;
if (parts[0].length() != 2) if (parts[0].length() != 2)
return false; return false;
if (!(is_ascii_digit(parts[0][0]) && is_ascii_digit(parts[0][1])))
return false;
auto hour = (parse_ascii_digit(parts[0][0]) * 10) + parse_ascii_digit(parts[0][1]); auto hour = (parse_ascii_digit(parts[0][0]) * 10) + parse_ascii_digit(parts[0][1]);
if (hour > 23) if (hour > 23)
return false; return false;
if (parts[1].length() != 2) if (parts[1].length() != 2)
return false; return false;
if (!(is_ascii_digit(parts[1][0]) && is_ascii_digit(parts[1][1])))
return false;
auto minute = (parse_ascii_digit(parts[1][0]) * 10) + parse_ascii_digit(parts[1][1]); auto minute = (parse_ascii_digit(parts[1][0]) * 10) + parse_ascii_digit(parts[1][1]);
if (minute > 59) if (minute > 59)
return false; return false;
@ -196,6 +200,8 @@ bool is_valid_time_string(StringView value)
if (parts[2].length() < 2) if (parts[2].length() < 2)
return false; return false;
if (!(is_ascii_digit(parts[2][0]) && is_ascii_digit(parts[2][1])))
return false;
auto second = (parse_ascii_digit(parts[2][0]) * 10) + parse_ascii_digit(parts[2][1]); auto second = (parse_ascii_digit(parts[2][0]) * 10) + parse_ascii_digit(parts[2][1]);
if (second > 59) if (second > 59)
return false; return false;