mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-12 20:11:51 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibCore: Add S_ISDIR, S_ISREG to System.h on Windows

Browse source 
Before this commit, LibCore/System.h exposed only part of
System::stat API on Windows. Namely, users of Core::System::stat
had to #include <dirent.h> in order to check the return value of stat.
It is OK for low-level libs like LibCore/LibFileSystem, but
S_ISDIR is also used in LibWeb\Loader\GeneratedPagesLoader.cpp.
We want to avoid platform #ifdefs in LibWeb.
This commit is contained in:
stasoid 2024-12-21 10:04:11 +05:00 • committed by Andrew Kaster
parent 6b86d8a44d
commit fe43712e72
Notes: github-actions[bot] 2025-02-13 01:43:13 +00:00
5 changed files with 3 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibFileSystem/FileSystem.cpp
View file

@ -16,7 +16,7 @@
#elif defined(AK_OS_LINUX)
# include <linux/fs.h>
#elif defined(AK_OS_WINDOWS)
# include <dirent.h>
# include <windows.h>
#endif
// On Linux distros that use glibc `basename` is defined as a macro that expands to `__xpg_basename`, so we undefine it