From fe6d8131aedb49404d34b7070494bad452ed0001 Mon Sep 17 00:00:00 2001 From: Timothy Flynn Date: Thu, 24 Apr 2025 22:13:14 -0400 Subject: [PATCH] LibWeb: Return correct type from CSSNestedDeclarations::style We implement CSSStyleProperties so let's use it. --- Libraries/LibWeb/CSS/CSSNestedDeclarations.cpp | 2 +- Libraries/LibWeb/CSS/CSSNestedDeclarations.h | 2 +- Libraries/LibWeb/CSS/CSSNestedDeclarations.idl | 5 ++--- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/Libraries/LibWeb/CSS/CSSNestedDeclarations.cpp b/Libraries/LibWeb/CSS/CSSNestedDeclarations.cpp index 89b8c9e47ba..1b0e3156853 100644 --- a/Libraries/LibWeb/CSS/CSSNestedDeclarations.cpp +++ b/Libraries/LibWeb/CSS/CSSNestedDeclarations.cpp @@ -38,7 +38,7 @@ void CSSNestedDeclarations::visit_edges(Cell::Visitor& visitor) visitor.visit(m_parent_style_rule); } -CSSStyleDeclaration* CSSNestedDeclarations::style() +GC::Ref CSSNestedDeclarations::style() { return m_declaration; } diff --git a/Libraries/LibWeb/CSS/CSSNestedDeclarations.h b/Libraries/LibWeb/CSS/CSSNestedDeclarations.h index 34b6db14273..86717cd8a23 100644 --- a/Libraries/LibWeb/CSS/CSSNestedDeclarations.h +++ b/Libraries/LibWeb/CSS/CSSNestedDeclarations.h @@ -22,7 +22,7 @@ public: CSSStyleProperties const& declaration() const { return m_declaration; } - CSSStyleDeclaration* style(); + GC::Ref style(); CSSStyleRule const& parent_style_rule() const; diff --git a/Libraries/LibWeb/CSS/CSSNestedDeclarations.idl b/Libraries/LibWeb/CSS/CSSNestedDeclarations.idl index 16cdac54c85..72910862040 100644 --- a/Libraries/LibWeb/CSS/CSSNestedDeclarations.idl +++ b/Libraries/LibWeb/CSS/CSSNestedDeclarations.idl @@ -1,9 +1,8 @@ #import -#import +#import // https://drafts.csswg.org/css-nesting-1/#cssnesteddeclarations [Exposed=Window] interface CSSNestedDeclarations : CSSRule { - // FIXME: Should be a CSSStyleProperties, once we have that - [SameObject, PutForwards=cssText] readonly attribute CSSStyleDeclaration style; + [SameObject, PutForwards=cssText] readonly attribute CSSStyleProperties style; };