LibCore: Make NetworkJob::start() take a Stream::BufferedSocketBase&

It used to take a plain `Socket` and cast it to a `BufferedSocketBase`, which can lead to unpleasant result when used with a non-buffered `Socket`.
Author: https://github.com/LucasChollet Commit: ff47223301 Pull-request: https://github.com/SerenityOS/serenity/pull/19764 Reviewed-by: https://github.com/alimpfard ✅ Reviewed-by: https://github.com/gmta ✅ Reviewed-by: https://github.com/shannonbooth
2025-09-13 13:02:28 +00:00 · 2023-02-09 19:07:11 -05:00 · 2023-02-09 19:07:11 -05:00 · ff47223301 · 2024-07-16 18:26:46 +09:00
commit ff47223301
parent 5fc873f53b
6 changed files with 8 additions and 8 deletions
--- a/Userland/Libraries/LibCore/NetworkJob.h
+++ b/Userland/Libraries/LibCore/NetworkJob.h
@ -41,7 +41,7 @@ public:
        DetachFromSocket,
        CloseSocket,
    };
-    virtual void start(Core::Socket&) = 0;
+    virtual void start(Core::BufferedSocketBase&) = 0;
    virtual void shutdown(ShutdownMode) = 0;
    virtual void fail(Error error) { did_fail(error); }