mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-10-18 14:09:42 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Add HTMLElement::uses_button_layout()

Browse source 
This suits the spec a bit better, and exposes the fact that we were
allowing `::ImageButton` to use the button layout although it is never
specified that it should do so. Tests were rebaselined for this.
This commit is contained in:
Jelle Raaijmakers 2025-08-15 09:42:52 +02:00 • committed by Sam Atkins
commit ff5f80a196
Notes: github-actions[bot] 2025-08-18 10:05:59 +00:00
8 changed files with 112 additions and 99 deletions
Download patch file Download diff file Expand all files Collapse all files

23
Libraries/LibWeb/HTML/HTMLInputElement.cpp
View file

@ -3622,4 +3622,27 @@ bool HTMLInputElement::is_mutable() const
&& !(has_attribute(AttributeNames::readonly) && is_allowed_to_be_readonly(m_type));
}
// https://html.spec.whatwg.org/multipage/rendering.html#button-layout
bool HTMLInputElement::uses_button_layout() const
{
// https://html.spec.whatwg.org/multipage/rendering.html#the-input-element-as-a-button:button-layout-2
// An input element whose type attribute is in the Submit Button, Reset Button, or Button state, when it generates a
// CSS box, is expected to depict a button and use button layout [..]
// https://html.spec.whatwg.org/multipage/rendering.html#the-input-element-as-a-colour-well:button-layout-2
// The element, when it generates a CSS box, is expected to use button layout, that has no child boxes of the
// anonymous button content box.
// https://html.spec.whatwg.org/multipage/rendering.html#the-input-element-as-a-file-upload-control:button-layout-2
// The button is expected to use button layout and match the '::file-selector-button' pseudo-element.
// https://html.spec.whatwg.org/multipage/input.html#image-button-state-(type=image):concept-button
// The element is a button, specifically a submit button.
// NOTE: Although type=image is specified to be a submit button, that does not mean that the type attribute is
// Submit Button, so we don't include ::ImageButton below.
return first_is_one_of(type_state(), TypeAttributeState::SubmitButton, TypeAttributeState::ResetButton,
TypeAttributeState::Button, TypeAttributeState::Color, TypeAttributeState::FileUpload);
}
}