68640 commits

This branch

This branch

All branches

Author	SHA1	Message	Date
Timothy Flynn	0de017df9b	LibRequests: Move NetworkError stringification to LibRequests ... Let's also rename the file to NetworkError.h while we're here. No need to have "Enum" in the name.	2025-04-02 08:52:45 -04:00
Shannon Booth	a5df972055	LibWeb: Do not store network errors as a StringView ... This is very clearly a very dangerous API to have, and was causing a crash on Linux as a result of a stack use-after-free when visiting https://www.index.hr/. Fixes #3901	2025-04-02 11:43:53 +02:00
Kenneth Myhra	82a2ae99c8	Everywhere: Remove DeprecatedFlyString + any remaining references to it ... This reverts commit 7c32d1e8a5.	2025-04-02 11:43:13 +02:00
Ali Mohammad Pur	4136d8d13e	LibRegex: Use an interned string table for capture group names ... This avoids messing around with unsafe string pointers and removes the only non-FlyString-able user of DeprecatedFlyString.	2025-04-02 11:43:13 +02:00
Andreas Kling	6bb0d585e3	LibJS: Elide function wrapper for class field literal initializers ... If a class field initializer is just a simple literal, we can skip creating (and calling) a wrapper function for it entirely. 1.44x speedup on JetStream3/raytrace-private-class-fields.js 1.53x speedup on JetStream3/raytrace-public-class-fields.js	2025-04-01 23:55:20 +02:00
Aliaksandr Kalenik	fd147e6be0	LibWeb: Protect SkiaBackendContext with a mutex ... The Skia Ganesh backend we currently use doesn't support painting from multiple threads, which could happen before this change when the main thread used Skia to paint on the HTML canvas while the rendering thread was working on display list rasterization. Fixes https://github.com/LadybirdBrowser/ladybird/issues/4172	2025-04-01 23:39:05 +02:00
Aliaksandr Kalenik	24527b6ae3	LibWeb: Pass PaintingSurface into DisplayListPlayer::execute() ... Deleteing set_surface() makes DisplayListPlayer API a bit more intuitive because now caller doesn't have to think whether it's necessary to restore previous surface after execution, instead DisplayListPlayer takes care of it by maintaining a stack of surfaces.	2025-04-01 23:39:05 +02:00
Timothy Flynn	b23b21fa4a	UI/AppKit: Restore custom cursor shown on link hover ... This seems to have broken in some recent-ish AppKit update. When we add the status label to the view hierarchy / change its visibility state, the NSApp is resetting the cursor to the standard cursor. By overriding the cursorUpdate method to do nothing, we prevent this from happening.	2025-04-01 23:10:14 +02:00
Timothy Flynn	b64d450f32	CI: Set correct architecture for JS artifact builds	2025-04-01 16:49:28 -04:00
Timothy Flynn	c5c3859205	CI: Temporarily install CMake 3.x ... Many vcpkg dependencies do not work with CMake 4.x, which GitHub Actions now bundles by default. Install the latest 3.x from Kitware for now.	2025-04-01 20:49:03 +02:00
Andreas Kling	fd0a0e963a	LibJS: Make IteratorRecord slightly smaller ... By reordering the members, we take this from 40 bytes to 32 bytes.	2025-04-01 20:16:39 +02:00
Jelle Raaijmakers	23f0fddeab	LibWeb: Let LineBuilder decide on Y-coordinate for float insertion ... Instead of reaching into the IFC of the LineBuilder from the BFC, we should let LineBuilder determine how to deal with the running vertical float clearance. No functional changes.	2025-04-01 16:02:53 +02:00
Jelle Raaijmakers	6d911a6baa	LibWeb: Resolve block height correctly after line break with clear: .. ... If a block with inline children ends with a line break clearing any floats, we not only need to take the introduced clearance into account for the next line box, but the containing block needs to set the correct height as well. Since the spec calls for using the last line box' bottom as the resolved height (if treated as auto), we now correctly apply the clearance to the previous line box' bottom coordinate. Fixes #4058.	2025-04-01 16:02:53 +02:00
Andreas Kling	e5db913b0d	Revert "LibRegex: Port remaining DeprecatedFlyString to ByteString" ... This reverts commit aab3fbe254. Greatly regressed JavaScript benchmark performance.	2025-04-01 15:40:38 +02:00
Andreas Kling	7c32d1e8a5	Revert "Everywhere: Remove DeprecatedFlyString + any remaining references to it" ... This reverts commit 3131e6369f. Greatly regressed JavaScript benchmark performance.	2025-04-01 15:40:27 +02:00
Jelle Raaijmakers	45905d6f7b	LibWeb: Use relative coordinates for available_space_for_line() ... We were accidentally providing it with absolute Y-coordinates, messing up stacked floating boxes that would otherwise intrude on each other. Fixes #4160.	2025-04-01 15:26:12 +02:00
Jelle Raaijmakers	a728d67ac2	LibWeb: Only calculate float intrusions for definite available width ... No functional changes.	2025-04-01 15:26:12 +02:00
Andreas Kling	b9c57d3122	LibJS: Use xorshift128++ PRNG for Math.random() ... This is the same PRNG used by major browser engines, and although it's a step down in randomness, it massively improves performance of Math.random(). 1.20x speedup on JetStream3/sync-file-system.js :^)	2025-04-01 15:16:54 +02:00
Jelle Raaijmakers	3bc6870bbf	Meta: Make the "Release" build type use -O3 and -flto ... This doesn't affect the default preset, but the Distribution preset will now compile with these flags instead.	2025-04-01 13:44:05 +02:00
Glenn Skrzypczak	da09608156	LibWeb/Painting: Fix blending with viewport background ... The viewport is now drawn onto transparent black instead of the background color of the viewport.	2025-04-01 13:38:00 +02:00
Glenn Skrzypczak	9973b01848	LibWeb/CSS: Improved implementation of background-blend-mode ... This is a improved version of a73cd88f0c The old commit was reverted in 552dd18696 The new version only paints an element into a new layer if background blend modes other than normal are used. The rasterization performance of most websites should therefore not suffer. Co-Authored-By: Alexander Kalenik <kalenik.aliaksandr@gmail.com>	2025-04-01 13:38:00 +02:00
Glenn Skrzypczak	6906f1722a	LibWeb/Painting: Add back SaveLayer command ... This reverts commit 552dd18696.	2025-04-01 13:38:00 +02:00
Kenneth Myhra	3131e6369f	Everywhere: Remove DeprecatedFlyString + any remaining references to it	2025-04-01 12:50:00 +02:00
Kenneth Myhra	aab3fbe254	LibRegex: Port remaining DeprecatedFlyString to ByteString	2025-04-01 12:50:00 +02:00
Aliaksandr Kalenik	cb722ca18b	LibWeb: Allow working on N+1 frame while N is rasterizing ... This change allows us to overlap rasterization and rendering work across threads: while the rasterization thread processes frame N, the main thread can simultaneously work on producing the display list for frame N+1.	2025-04-01 12:17:52 +02:00
Aliaksandr Kalenik	7248748157	Tests: Disable WebAnimations/animation-methods/updatePlaybackRate.html ... This test is timing-sensitive, similar to some other animation tests we had to disable, and starts failing on CI after the change in upcoming commit, so let's disable it for now.	2025-04-01 12:17:52 +02:00
Luke Wilde	278666edcd	LibWeb: Enforce Content Security Policy on navigation request/response	2025-04-01 04:01:28 +02:00
Timothy Flynn	004173f88b	LibWeb: Allow parsing of "file" prompt types in WebDriver ... See: https://github.com/w3c/webdriver/commit/3055808 This isn't actually used outside of BiDi.	2025-04-01 03:52:02 +02:00
Timothy Flynn	952ad4e68b	LibWeb: Allow fractional numbers for WebDriver mouse-move coordinates ... See: https://github.com/w3c/webdriver/commit/a67669c	2025-04-01 03:52:02 +02:00
Luke Wilde	ee6dbcc96e	LibWeb: Apply HTMLFontElement's face attribute's presentational hint ... Fixes font selection on https://stagsnet.net/	2025-04-01 03:50:30 +02:00
Aliaksandr Kalenik	e33174fca1	LibWeb: Make BackingStore atomic ref-counted ... This is required to make sure rendering thread will keep backing stores alive in case backing stores reallocation happens during rasterization. Fixes https://github.com/LadybirdBrowser/ladybird/issues/4164	2025-04-01 03:05:21 +02:00
Andreas Kling	a0bb31f7a0	LibJS: Make async functions & generators faster with helper types ... Instead of returning internal generator results as ordinary JS::Objects with properties, we now use GeneratorResult and CompletionCell which both inherit from Cell directly and allow efficient access to state. 1.59x speedup on JetStream3/lazy-collections.js :^)	2025-04-01 02:30:42 +02:00
Glenn Skrzypczak	1022566bff	LibWeb/Layout: Properly remove layout nodes ... This properly remove the old layout node subtree when no new layout node is created during layout update.	2025-03-31 18:19:58 +01:00
Aliaksandr Kalenik	24e2c402f5	LibWeb+WebContent: Move display list rasterization off the main thread ... The display list is an immutable data structure, so once it's created, rasterization can be moved to a separate thread. This allows more room for performing other tasks between processing HTML rendering tasks. This change makes PaintingSurface, ImmutableBitmap, and GlyphRun atomic ref-counted, as they are shared between the main and rendering threads by being included in the display list.	2025-03-31 15:58:15 +01:00
Jelle Raaijmakers	86b831750d	LibWeb: Layout children a bit earlier in BlockFormattingContext ... We don't need to duplicate this piece of code. No functional changes.	2025-03-31 08:11:10 +01:00
Jelle Raaijmakers	04ba375cc7	LibWeb: Only set line builder's block offset if clearance increases it ... This prevents text from overlapping with each other if a `<br>` with `clear: ..` is used in between.	2025-03-31 08:11:10 +01:00
Timothy Flynn	6f1710121d	LibWeb: Remove OOM handling from the AutoplayAllowlist	2025-03-30 16:18:57 +01:00
Timothy Flynn	ed265b568d	LibWebView+WebContent+UI: Migrate to the new autoplay settings ... This removes the old autoplay allowlist file in favor of the new site setting. We still support the command-line flag to enable autoplay globally, as this is needed for WPT.	2025-03-30 16:18:57 +01:00
Timothy Flynn	223b04f087	LibWebView: Add autoplay settings to about:settings ... The idea with the UI here is that it will serve as a generic component for all site settings, such as autoplay, notifications, etc. When the site settings dialog is opened, it is filled with the requested setting data, and messages sent to the browser process are based on the setting. This patch only implements the UI and persisted settings. It does not apply autoplay changes to the WebContent process.	2025-03-30 16:18:57 +01:00
Timothy Flynn	c7979a8bd6	LibWeb: Add missing forward-include to AutoplayAllowlist ... This just lets clangd index this file.	2025-03-30 16:18:57 +01:00
Andreas Kling	4dc63ddf49	LibJS: Make Optional<Utf16String> use less space ... By specializing the template, we can shrink it from 16 to 8 bytes. This makes PrimitiveString a measly 32 bytes. :^)	2025-03-30 07:16:40 +01:00
Andreas Kling	152691f9eb	LibWeb: Make RopeString subclass so PrimitiveString can be smaller ... By moving the LHS and RHS pointers used by rope strings into a RopeString subclass, we shrink PrimitiveString by 16 bytes. Most strings are not rope strings, so this ends up saving quite a bit of memory.	2025-03-30 07:16:40 +01:00
Tim Ledbetter	568531f06a	Everywhere: Mark GC::Cell derived classes as Weakable explicitly ... Previously, all `GC::Cell` derived classes were Weakable. Marking only those classes that require this functionality as Weakable allows us to reduce the memory footprint of some frequently used classes.	2025-03-29 17:36:33 -05:00
Totto16	11280897d3	LibWeb: Add Extended Tests for Window BarProps ... Add Tests for Window BarProps in popout windows	2025-03-29 02:35:27 +00:00
Totto16	b66e7ac1ba	LibWeb: Implement BarProp properties for Window	2025-03-29 02:35:27 +00:00
Andreas Kling	ad634897b8	Tests: Hide scrollbars in failing ref test ... The test scrolled-svg-path-with-transform.html was relying on overlay scrollbars mistakenly not showing up.	2025-03-28 22:01:51 +00:00
Andreas Kling	ba8aabdeb0	Revert "LibWeb: Skip "overlay" paint phase when there's no inspected node" ... This reverts commit dc56435ecd. It broke overlay scrollbars.	2025-03-28 20:08:48 +00:00
Jelle Raaijmakers	b688fe0396	Tests: Update FileWatcher's test timeouts ... Increase the step timeouts on Linux from 50 to 75 milliseconds, since we're seeing the occasional timeout on CI. For macOS, we should probably be able to execute the tests a bit quicker than 500ms per step.	2025-03-28 19:19:43 +00:00
Aliaksandr Kalenik	1229328adc	Revert "LibWeb/Painting: Add SaveLayer command" ... This reverts commit 1898643ba4.	2025-03-28 16:48:03 +00:00
Aliaksandr Kalenik	552dd18696	Revert "LibWeb/CSS: Implement 'background-blend-mode'" ... This reverts commit a73cd88f0c. Emitting SaveLayer for each paintable made rasterization a lot slower on every website because now Skia has to allocate enormous amounts of temporary surfaces. Let's revert it for now and figure how to implement it with less aggressive SaveLayer usage.	2025-03-28 16:48:03 +00:00