39 commits

Author	SHA1	Message	Date
Callum Law	778da0175e	LibWeb: Clamp and censor top-level calc results ... We now clamp the values returned from calc into the allowed range (where we know it) and censor any `NaN`s to `0` both when we resolve and when we serialize. Gains us 76 WPT passes.	2025-08-11 17:10:04 +01:00
Callum Law	e260ba54e0	LibWeb: Propagate NaN in CSS clamp function ... Gains us 10 WPT tests.	2025-08-08 11:43:49 +01:00
Callum Law	4ba54a7a1c	LibWeb: Handle NaN and Infinite values in CSS round function ... Gains us 10 WPT tests	2025-08-08 11:43:49 +01:00
Callum Law	376b992f0e	LibWeb: Handle NaN within CSS min and max functions ... Gains us 10 WPT tests	2025-08-08 11:43:49 +01:00
Callum Law	9e1ace28a6	LibWeb: Import WPT tests related to handling non-finite values in calcs	2025-08-08 11:43:49 +01:00
Callum Law	a1037e28d6	LibWeb: Improve support for CalculatedStyleValue in scale ... - Properly serialize CalculatedStyleValue components - Allow CSV to be the 'Z' component in interpolated value Gains us 52 WPT tests	2025-08-08 09:45:00 +01:00
Sam Atkins	5808eff1f4	LibWeb/CSS: Hyphenate request-url-modifier names ... Corresponds to e1bf92d49a Also update our imported WPT tests.	2025-08-07 13:38:25 +01:00
Callum Law	ba4a57b34d	LibWeb: Absolutize StyleValueList in StyleComputer::absolutize_values	2025-08-06 17:44:12 +01:00
Callum Law	a2ceed27e2	LibWeb: Absolutize CalculatedSVs in StyleComputer::absolutize_values	2025-08-06 17:44:12 +01:00
Callum Law	a44e28fd56	LibWeb: Avoid premature creation of CSSPixels in calc simplification ... Previously we were converting lengths to CSSPixels values when we didn't need to, this had a couple of effects in that: - We rounded to CSSPixel resolution prematurely (sometimes giving incorrect results) - We converted NaN to 0 when we shouldn't have. We now avoid prematurely converting lengths to CSSPixels values in two places: - `CalculationResult::from_value` - `CalculatedStyleValue::resolve_length_deprecated` (the new method already avoided rounding). Gains us 16 WPT tests.	2025-08-06 14:57:34 +01:00
Callum Law	c3b1013018	LibWeb: Skip inverted non-canonical values when simplifying product node ... This matches the logic with the non-inverted children. Gains us 2 WPT tests.	2025-08-06 14:53:22 +01:00
Callum Law	15cee5cc15	LibWeb: Correctly round non-integer z-indexes ... Previously we would just cast to an int. Gains us 3 WPT tests.	2025-08-05 06:37:40 +01:00
norbiros	190745fd58	LibWeb/CSS: Parse initial value using syntax from @property ... Now we pass all WPT tests in: `css/css-properties-values-api/at-property-cssom`. Note: Failing tests were false positives. Proper handling of inheriting values and detecting computational independence will be done in another PR.	2025-08-04 11:08:46 +01:00
norbiros	90c0decd95	LibWeb/CSS: Add CSS.registerProperty JS method ... This adds an *almost* complete implementation of `CSS.registerProperty` method enabling further progress on the `@property` feature.	2025-07-22 10:57:54 +01:00
norbiros	7ad01d28a8	LibWeb/CSS: Add basic registered properties with initial values ... Add global registry for registered properties and partial support for `@property` rule. Enables registering properties with initial values. Also adds basic retrieval via `var()`. Note: This is not a complete `@property` implementation.	2025-07-18 11:12:39 +01:00
Sam Atkins	27a666f3b2	LibWeb/CSS: Implement type(<syntax>) in attr() ... This lets the `attr()` interpret the attribute's contents as an arbitrary type instead of just as a string or number.	2025-07-16 14:47:45 +01:00
Sam Atkins	5d1ba658c9	Tests: Import attr()-related WPT tests	2025-07-16 14:47:45 +01:00
Tim Ledbetter	c4cf1ccede	LibWeb: Don't crash when parsing ASF with non comma-separated arguments	2025-07-09 19:47:12 +01:00
Tim Ledbetter	78b6032940	LibWeb: Validate operator count when parsing a calculation ... Previously, we would allow calc values such as `calc(min(1 2))`, which would be simplified to `calc(3)` because we assumed that numbers not separated by an operator represented a sum. We now validate that the number of operators we see is as we would expect before collecting these values into a sum node.	2025-07-02 10:12:58 +01:00
Callum Law	8e9753eadb	LibWeb: Correctly compute consistent type when simplifying hypot ... Previously we would never get a valid `consistent_type` as we were trying to make the node types consistent with the initial empty type which isn't possible. Gains us 7 WPT tests.	2025-06-30 14:53:04 +02:00
Tim Ledbetter	48f56cad08	LibWeb: Handle non-numeric font-weight values in keyframes ... Previously, using `font-weight` with a keyword or `calc()` value inside a keyframe rule would cause a crash.	2025-06-25 09:01:56 +02:00
Callum Law	536f8c395c	LibWeb: Set numeric type of asin, acos, atan calculation results ... Previously we were omitting the numeric type which meant these functions weren't valid in some cases e.g. within rotate() functions.	2025-06-25 05:19:07 +01:00
Tim Ledbetter	b46378085d	LibWeb: Absolutize keyframe values before interpolating	2025-06-24 12:36:47 +01:00
Timothy Flynn	7d99a92135	LibWeb: Absolutize CSS image URLs for computed style resolution ... For getComputedStyle(), we must return an absolute URL for image style values. We currently return the raw parsed URL. This fixes loading the marker icons on https://usermap.serenityos.org.	2025-06-03 19:30:43 -04:00
Andreas Kling	d7cd8f0fc7	LibWeb: Make CSS sign(A) ignore A's unit and just look at the raw value ... This allows stuff like sign(1em) even when we don't have something to resolve the em unit against. +25 new WPT subtest passes.	2025-05-20 13:28:40 +02:00
Andreas Kling	4ef34ebd96	LibWeb: Make CSS sign(A) behave correctly for negative zero ... We were incorrectly returning 0 instead of -0 for sign(-0). +7 new WPT subtest passes.	2025-05-20 13:28:40 +02:00
Andreas Kling	c1e79d0b13	LibWeb: Handle calc() in CSS z-index ... We also make getComputedStyle() reflect the actually used z-index value, since otherwise this change is hard to observe. +26 new WPT subtest passes.	2025-05-20 13:28:40 +02:00
Andreas Kling	821d54de7f	LibWeb: Invalidate layout tree on CSS position property change ... When position changes, we may need to make larger structural updates to the layout tree. A simple relayout is not sufficient. This was a source of flakiness in the engine, and gives us at least +28 new WPT subtest passes.	2025-05-20 13:28:40 +02:00
Andreas Kling	cef9564728	LibWeb: Only serialize CSS numbers with up to 5 decimals ... This fixes an issue where we'd serialize some floating point numbers with excessive precision, resulting in unpleasant-looking numbers like 0.49999999999999999 and such. At least 90 new subtests passing on WPT, possibly more. :^)	2025-05-18 17:23:34 +02:00
Andreas Kling	f813c495ae	Tests: Import a WPT test for sin(), cos() and tan() serialization	2025-05-18 17:23:34 +02:00
Sam Atkins	de6df6f403	LibWeb/CSS: Parse and use CSS URL request modifiers	2025-05-03 23:22:40 +01:00
Sam Atkins	09b508d8e8	Tests: Import some URL-related WPT tests	2025-05-03 23:22:40 +01:00
Andreas Kling	d8ea16d94e	LibWeb: Don't assume calc() simplification worked on invalid tree ... Fixes #4469	2025-04-25 16:55:05 +02:00
Andreas Kling	0553bcb35b	LibWeb: Simplify standalone CSS math functions when used outside calc() ... Math functions like abs(), clamp(), round(), etc, can be used by themselves in property values, without wrapping them in calc(). Before this change, we were neglecting to run calc simplification on the generated calculation node trees. By doing that manually after parsing a standalone math function, we score at least a couple hundred WPT points.	2025-04-24 20:38:00 +02:00
Andreas Kling	1772adb600	LibWeb: Don't crash on non-finite values in CSS clamp() function ... Stops a WPT test from crashing, giving us 29 new subtest passes. :^)	2025-04-24 18:26:54 +02:00
Lucas CHOLLET	4bf197872b	LibWeb/CSS: Remove an ad-hoc simplification step in calc() parsing	2025-03-05 12:05:45 +00:00
Sam Atkins	5cfb8163c6	LibWeb/CSS: Sort a calculation's children during serialization ... This gets us 38 more passes in our in-tree tests, plus however many more in the rest of WPT. :^)	2025-02-27 21:42:43 +01:00
Sam Atkins	a63879330f	LibWeb/CSS: Implement calc-serialization spec algorithms ... This gets us 37 new subtest passes in css/css-values, and 13 passes in our other in-tree tests (and probably some random other ones!) As noted in comments, a few parts of this algorithm have ad-hoc behaviour to handle some issues in the spec.	2025-02-27 21:42:43 +01:00
Sam Atkins	7b13ccabd4	Tests: Import some calc() serialization tests from WPT	2025-02-27 21:42:43 +01:00