mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-04-25 14:05:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9
13406 commits 1 branch 0 tags 464 MiB
Commit graph

90 commits

Author SHA1 Message Date
AnotherTest
254d66cd81 Shell: Assert that the same pid is not given to waitpid() 
Theoretically, this assertion should never trip (at least, on serenity
where we don't really reuse PIDs).
This change should be considered temporary, until we figure out whether
waitpid() is being called twice (and succeeding) for one given PID.
 2020-10-01 21:20:14 +02:00
AnotherTest
519d1811fd Shell: Wait for *any* child to change state when receiving a SIGCHLD 
This really just works around the core issue, which is that we have no
reliable way to know exactly who raised the signal (yet).
Fixes #3645, in a very weird (yet apparently standard) way.
 2020-10-01 21:20:14 +02:00
AnotherTest
b91be8b9fd Shell: Make 'editor' a member of Shell, and provide a LibShell 2020-09-30 20:05:24 +02:00
asynts
afa2523724 Shell: Don't execute scripts interactively. 
The following example should illustrate one issue arising from this:

    $ echo 'exit 1' > example.sh
    $ Shell example.sh
    Good-bye!

This message is meant to be shown to an interactive user, but not in a
shell script.
 2020-09-28 17:39:50 +02:00
AnotherTest
5f1cc64504 Shell: Fix use-after-move in alias resolution 
This unbreaks aliases!
 2020-09-26 22:11:28 +02:00
AnotherTest
b3dd97a694 Shell: Add a (very basic) formatter 2020-09-26 21:28:35 +02:00
AnotherTest
51e598cf0b Shell: Use NonnullRefPtr to store non-null subnodes 
Also replaces null-is-invalid nodes with syntax error nodes.
 2020-09-26 21:28:35 +02:00
AnotherTest
29ef65c458 Shell: Fix Vector OOB access in `add_entry_to_cache()' 
Fixes #3530.
 2020-09-19 00:38:41 +02:00
AnotherTest
a43d9c4fe0 Shell: Make a new session at start if there's no active session 2020-09-19 00:38:41 +02:00
AnotherTest
4c2f86c24f Shell: Do not strip glob base path when it was explicitly requested 
Fixes #3544.
 2020-09-19 00:24:16 +02:00
AnotherTest
cd0ddf27f3 Shell: Allow builtins and functions as conditions for 'if' 2020-09-14 17:40:18 +02:00
AnotherTest
d1550ea64f Shell: Add support for functions 
This implementation does not have support for 'return' yet.
 2020-09-14 17:40:18 +02:00
AnotherTest
0b57cdff82 Shell: Add support for $0,$1,... 2020-09-14 17:40:18 +02:00
AnotherTest
063fb02ef4 Shell: Move the first command in a pipeline to the pipeline pgid too 
This process is supposed to be the session leader of the pipeline
process group, we can't *not* move it into that group :P
 2020-09-12 21:18:24 +02:00
AnotherTest
927e2fc6bc Shell: Do not reset the terminal attributes when command is run in bg 
Also removes a FIXME that no longer applies.
 2020-09-10 11:20:22 +02:00
AnotherTest
54b453be57 Shell: Fix event loop processing and backgrounding in subshells 2020-09-09 20:35:21 +02:00
AnotherTest
aa2df9277d Shell: Allow control structures to appear in pipe sequences 
This makes commands like the following to be possible:
```sh
$ ls && for $(seq 10) { echo $it }
$ ls | for $(seq 1) { cat > foobar }
```
 2020-09-09 20:35:21 +02:00
AnotherTest
7b5ead64a5 Shell: Announce job events at the right times 
This fixes a duplicate message when running `jobs` for the first time
after a job has been moved to the background.
Also actually announces background exits now :^)
 2020-09-09 20:35:21 +02:00
AnotherTest
715e11f692 Shell: Fix job control and backgrounding 
This patchset makes the shell capable of lazily resolving and executing
sequences of commands, to allow for putting logical sequences in the
background.
In particular, it enables And/Or/Sequence nodes to be run in the background,
and consequently unmarks them as `would_execute`.
Doing so also fixes job control to an extent, as jobs are now capable of
having 'tails', so sequences can be put in the background while
preserving their following sequences.
 2020-09-09 20:35:21 +02:00
Nico Weber
8b166e57df
Misc: Remove some unneeded includes of Timer.h and ElapsedTimer.h (#3286) 2020-08-25 09:41:56 +02:00
AnotherTest
cf18bff72a Shell: Do not attempt to yank the TTY from background processes 
They don't own the TTY anyway!
 2020-08-19 21:21:34 +02:00
AnotherTest
20d4287eaf Shell: Fix outdated debug log code 2020-08-19 21:21:34 +02:00
AnotherTest
4ee4c94d60 Shell: Respect the 'PROMPT_EOL_MARK' environment variable 
This allows the users to customise what is shown when a command ends
without a newline.
 2020-08-18 16:58:17 +02:00
AnotherTest
14a54a72fa Shell: Ensure that the cursor starts on a new line 
And print an indicator when it doesn't, a la zsh.
 2020-08-17 17:44:02 +02:00
AnotherTest
c589625418 Shell: Allow redirections and pipes on builtins 
Fixes #3072.
 2020-08-15 20:48:17 +02:00
AnotherTest
2b51250863 Shell: Wait for the parent to deal with the PGID stuff before execvp() 2020-08-12 11:41:18 +02:00
AnotherTest
ab3e787334 Shell: Moves pipelined processes to one process group 2020-08-12 11:41:18 +02:00
AnotherTest
8a17527bc5 Shell: Show the job id instead of the pid when a job exits in background 2020-08-12 11:41:18 +02:00
Nico Weber
37d5e3e0df Shell: Fix fd leak with pipes 
Fixes the problem reported in #3073. While trying to write a test
for this, I thought I'd use

    Shell -c 'for i in $(seq 100) { echo $i }' | head -n 1

but that makes the cpu spin at 100% and doesn't terminate even
with this fix here. But at least piping disasm into head now works.
 2020-08-10 20:57:38 +02:00
AnotherTest
9fde92db38 Shell: Make redirections without commands apply to all future commands 
This restirects redirection-only commands' scope, and keeps their
usefulness too!
 2020-08-09 21:50:33 +02:00
Andreas Kling
3b3d158649 Shell: Make Command::redirections a NonnullRefPtrVector 2020-08-07 09:42:12 +02:00
Andreas Kling
0c6ce063e6 Shell: Print job status after suspending a command 2020-08-06 15:33:04 +02:00
Andreas Kling
d9aecc8e08 Shell: Remove unnecessary ignore() in Shell::custom_event() 
Ignoring an event means that it will bubble to the parent Core::Object.
This is not necessary here.
 2020-08-06 14:27:06 +02:00
Andreas Kling
5bce0193de Shell: Make Job constructors private and use a create() helper 
Also store PGIDs as pid_t since that's what they are.
 2020-08-06 13:48:45 +02:00
Andreas Kling
bf2cd9374c Shell: Make run_command() return a NonnullRefPtrVector<Job> 
This never returns null Job pointers.
 2020-08-06 13:44:30 +02:00
AnotherTest
7b15c85ff5 Shell: Do not assume that stdin/stdout is a TTY 
This closes #2989.
 2020-08-05 17:30:31 +02:00
AnotherTest
771751258e Shell: Give the TTY to the foreground process 
This fixes the bug with the shell not waiting for any foreground process
that attempts to read from the terminal in the Lagom build.
 2020-08-04 21:22:44 +02:00
AnotherTest
1d08cab9ab Shell: Correct FdRedirection inheriting from two RefCounted bases 
Also add missing calls to `adopt()`.
 2020-08-04 13:40:58 +02:00
Mathieu PATUREL
0622b60fbd Shell: factor out updating the path cache into a function. 2020-08-04 10:51:16 +02:00
Mathieu PATUREL
f6d4c4f02c Shell: update cached_path when adding aliases 
This has the nice side effect of fixing alias completion, because
cached_path is the source of truth for the completion system, and it was
only refreshed (with shell::cache_path()) in the shell's constructor,
before the rc files where loaded (ie no aliases)

This also means that shell::is_runnable can now rely on the cache, and
doesn't have to check the aliases itself.
 2020-08-04 10:51:16 +02:00
Mathieu PATUREL
2b4b9d212e Shell: highlight runnable commands 
And display in red the command which will result in something like "no
command, or is directory" (inspired by the fish shell).
 2020-08-04 10:51:16 +02:00
asynts
707d92db61 Refactor: Change the AK::binary_search signature to use AK::Span. 2020-07-26 16:49:06 +02:00
AnotherTest
b6066faa1f Shell: Add a 'for' loop 
Closes #2760.
This commit adds a 'for' loop, and tweaks the syntax slightly to make &&
bind more tightly than || (allowing for `expr && if_ok || if_bad`) :^)
 2020-07-16 16:01:10 +02:00
AnotherTest
95fc7dd03a Shell: Parse lists serially, and flatten them only when needed 
This allows `((1 2 3) (4 5 6))` to remain nested until we explicitly
flatten it out.
 2020-07-16 16:01:10 +02:00
AnotherTest
cd8495f1d4 Shell: Explicitly declare 'environ' to make the macOS Lagom build happy 2020-07-15 00:09:01 +02:00
AnotherTest
dc62371439 Shell: Avoid waiting for jobs that were *just* unblocked 
This fixes the issue with C-z not suspending the job on the first try.
...and further signal issues when the suspended job is contiued.
 2020-07-13 19:48:45 +02:00
AnotherTest
151e4d41ed Shell: Put children in their own process groups and fix job control 
This commit fixes job control by putting children in their own process
group, and proxying TTY signals to active jobs.
This also cleans up the code around builtin_disown a bit to use
the newer job interfaces.
 2020-07-13 15:29:16 +02:00
AnotherTest
b0ce8d725a Shell: Move out run_commands and expand_aliases to be Shell member fns 
This makes running commands from outside the AST chain easier.
 2020-07-13 15:12:28 +02:00
Tom
6dfd503518 Shell: Handle signals asynchronously 
Fixes #2717
 2020-07-09 21:58:07 +02:00
AnotherTest
173effc88d Shell: Suggest aliases when completing program names :^) 
Closes #2732
 2020-07-07 23:11:01 +02:00