69763 commits

This branch

This branch

All branches

Author	SHA1	Message	Date
Callum Law	9ba74316d2	LibWeb: Implement text-wrap-style CSS property	2025-06-04 12:48:36 +01:00
Timothy Flynn	7d99a92135	LibWeb: Absolutize CSS image URLs for computed style resolution ... For getComputedStyle(), we must return an absolute URL for image style values. We currently return the raw parsed URL. This fixes loading the marker icons on https://usermap.serenityos.org.	2025-06-03 19:30:43 -04:00
Timothy Flynn	3ae2220534	LibWeb: Add missing FlyString include to CSS/URL.h ... clangd is complaining about this.	2025-06-03 19:30:43 -04:00
Andreas Kling	6dba720370	LibWeb: Invalidate layout tree at nearest non-anonymous ancestor ... When marking a part of the layout tree for rebuild, if the subtree root that we're marking has an anonymous parent, we now mark from the nearest non-anonymous ancestor instead. This ensures that subtrees inside anonymous wrappers don't just get duplicated (i.e recreated but inserted instead of replaced).	2025-06-04 00:43:23 +02:00
Aliaksandr Kalenik	93cd17db74	LibJS: Add fast path internal_has_property() for Array ... If array has packed index property storage without holes, we could check if indexed property is present simple by checking if it's less than array's length. Makes the following program go 1.1x faster: ```js function f() { let array = []; for (let i = 0; i < 3_000; i++) { array.push(i); } for (let i = 0; i < 10_000; i++) { array.map(x => x * 2); } } f(); ```	2025-06-03 23:18:41 +02:00
Aliaksandr Kalenik	22e0b732db	LibJS: Add missing update for holes count in IndexedPropertyStorage ... This one is required to cover the case when new empty elements are introduced by assigning to element with index > length, like: ```js var x = []; x[0] = 1; x[2] = 2; ```	2025-06-03 23:18:41 +02:00
aplefull	3781c132aa	LibWeb: Fix grid item placement when only grid-column-end is specified	2025-06-03 22:22:24 +02:00
Rocco Corsi	4b3dccd0f2	LibWeb: Remove Unicode Cyrillic e char (04+35) in variable name ... Static analysis tool cppcheck reports that LibWeb/Internals/Internals.cpp:65 has a variable named hit_tеsting_result with a Cyrillic e in the 'testing' portion of the name, instead of the more common ASCII e. No other use of Unicode characters for identifiers in the Ladybird code base noted by cppcheck, so assuming that this is unintended use.	2025-06-03 21:22:27 +02:00
Aliaksandr Kalenik	1274f4e2f7	LibJS: Optimize Function.prototype.apply() ... ...by avoiding `CreateListFromArrayLike` in cases when we could directly use elements of underlying object's indexed properties storage. Makes this program go 2.1x faster: ```js function target(a, b, c) { return a + b + c; } const args = [1, 2, 3]; let result = 0; (function() { for (let i = 0; i < 10_000_000; i++) { result += target.apply(null, args); } })(); ```	2025-06-03 17:16:01 +02:00
Aliaksandr Kalenik	3f7c4dd5f6	LibJS: Maintain number of empty elements in SimpleIndexedPropertyStorage ... This will be used in upcoming changes to do a fast path when array does not have any holes.	2025-06-03 17:16:01 +02:00
Psychpsyo	4c54a28c45	Meta: Add doctypes to a few more layout tests	2025-06-03 11:03:19 +01:00
Manuel Zahariev	f972342c27	LibWeb/CSS: Unit tests for changes to counter definitions	2025-06-03 03:51:42 +02:00
Manuel Zahariev	99c6eb0c35	LibWeb/CSS: Invalidate layout tree for changes to counter definitions ... A change to a counter "definition" propagates to all subsequent instances of this counter: descendents, siblings and their descendents (the "next tree slice"). Rebuilding the layout tree (from the parent node) covers at least the "next_tree_slice".	2025-06-03 03:51:42 +02:00
Timothy Flynn	8145572180	LibJS+LibUnicode: Support ambiguous time zone transitions ... For example, time zone transitions can result in repeated or skipped wall times. Temporal wants us to handle these transitions.	2025-06-03 09:09:21 +12:00
Timothy Flynn	c8b4dc4847	LibJS: Require strict matching with a precise ZonedDateTime offset ... This is a normative change in the Temporal proposal. See: 1117eaf	2025-06-03 09:09:21 +12:00
Timothy Flynn	f091047159	LibJS+LibUnicode: Implement retrieval of collator keyword values ... Completely missed this when implementing Intl.Collator!	2025-06-03 09:03:33 +12:00
Timothy Flynn	422d72e85d	LibUnicode: Provide string length to ICU string enumeration callbacks ... Some callers need the raw nul-terminated c-string in this callback, to pass to some other ICU method. But other callers will want a StringView. We know the length already in `icu_string_enumeration_to_list`, so let's just pass it along to avoid `strlen`.	2025-06-03 09:03:33 +12:00
Timothy Flynn	21cff645a2	LibUnicode: Use ICU to convert Unicode keywords to their BCP 47 value ... We were manually doing this for the calendar keyword, and would need to do so for the collation keyword as well. I wasn't aware of this API originally, so let's start using it.	2025-06-03 09:03:33 +12:00
aplefull	486602e796	LibRegex: Fix handling of + quantifier with zero-width matches ... Small change that allows quantifiers using Fork* forms (e.g., +) to succeed after one match, even if that match has zero width.	2025-06-02 15:52:26 +02:00
Timothy Flynn	2380fb0ca1	Meta: Default chosen compilers to the CC and CXX environment variables ... This regressed when porting find_compiler.sh to python.	2025-06-02 08:04:07 -04:00
Saksham Mittal	c52c05555b	LibWeb: Don't place cursor on certain <input> elements ... For example, button inputs shouldn't have a cursor displayed in their text since they're not editable, and are not meant to be editable. Fixes #4140 Co-authored-by: Sam Atkins <sam@ladybird.org>	2025-06-02 11:38:38 +01:00
Tim Ledbetter	17f14a277b	LibWeb: Don't crash when interpolating single-value repeatable lists ... Previously, when interpolating a repeatable list from a list with multiple values to a single value, we would crash.	2025-06-02 11:33:01 +01:00
Timothy Flynn	8ded0c65dc	LibJS+LibUnicode: Change time zones in a way that works on Windows ... On Windows, ICU does not look at the TZ environment variable at all. So to support changing time zones in test-js, let's set ICU's default time zone directly. Note that we no longer deal with "null" time zone strings. We just cache whatever ICU thinks is the current time zone before attempting to change it, for which we never have a null result. Co-authored-by: Andrew Kaster <andrew@ladybird.org>	2025-06-01 18:48:58 -04:00
stasoid	8d33a97630	Tests/LibURL: Port to Windows	2025-06-01 16:42:19 -06:00
Tim Ledbetter	e2d0d8e2b9	LibWeb/CSS: Implement the scrollbar-color property ... This allows the user to set the scrollbar thumb and track colors.	2025-06-02 00:17:51 +02:00
Aliaksandr Kalenik	285bc005cb	LibJS: Do more comprehensive check if next() fast path is possible ... Before this change each built-in iterator object has a boolean `m_next_method_was_redefined`. If user code later changed the iterator’s prototype (e.g. `Object.setPrototypeOf()`), we still believed the built-in fast-path was safe and skipped the user supplied override, producing wrong results. With this change `BuiltinIterator::as_builtin_iterator_if_next_is_not_redefined()` looks up the current `next` property and verifies that it is still the built-in native function.	2025-06-02 00:15:36 +02:00
Lucien Fiorini	0fcb574041	LibGfx+LibWeb: Turn Gfx::Filter into a SkImageFilter wrapper	2025-06-01 23:22:10 +02:00
InvalidUsernameException	417f4edc46	Tests/LibWeb: Print properties without indexes ... The test CSSStyleDeclaration-has-indexed-property-getter is a frequent source of merge conflicts between PRs that are adding to or otherwise modifying the list of supported CSS properties. This is primarily because the test prints out a numeric index of each property along with the property. As far as I can tell the indexes are inconsequential for what the test is trying to verify. So lets modify the printout to only contain the properties without indexes.	2025-06-01 19:09:10 +01:00
Julien Le Bras	3ba6d129df	LibJS: Cache string constants in Generator::add_constant ... This mirrors the existing caching logic for int32 constants. Avoids duplication of string constants in m_constants which could result in stack overflows for large scripts with a lot of similar strings.	2025-06-01 18:25:59 +02:00
Richard Gibson	9bf836e6c4	js: Don't escape printed strings with --disable-string-quotes	2025-06-01 09:51:09 -04:00
Timothy Flynn	5e40db5a17	AK: Remove some now-unnecessary workarounds for simdutf base64 usage	2025-06-01 08:03:00 -04:00
Timothy Flynn	3693fd5caa	Meta: Update simdutf to version 7.3.0	2025-06-01 08:03:00 -04:00
Timothy Flynn	d9d87d4816	Meta: Update libjxl to version 0.11.1#1 ... This includes a CMake fix that we added for Ladybird.	2025-06-01 08:03:00 -04:00
Timothy Flynn	0f2bcd26c4	Meta: Update curl to version 8.14.0	2025-06-01 08:03:00 -04:00
Timothy Flynn	2205177d15	Meta: Update vcpkg baseline	2025-06-01 08:03:00 -04:00
Aliaksandr Kalenik	4b4d960cba	LibWeb: Cancel previous animation if new animation-name is "none" ... "none" value should be interpreted as "no animation" to trigger the path that cancels previous animation if it exists.	2025-06-01 05:02:12 +02:00
Timothy Flynn	985434ea10	headless-browser: Allow running LibWeb tests without specifying a path ... Especially on new setups, it is handy for `headless-browser --run-tests` to "just work". Anyone using ladybird.py will have LADYBIRD_SOURCE_DIR set in their environment already.	2025-06-01 10:34:30 +12:00
Shannon Booth	bc4317be20	LibWeb/HTML: Handle failure determining mime type fetching module script ... Fixes crash in WPT test: https://wpt.live/html/semantics/scripting-1/the-script-element/css-module/content-type-checking.html	2025-05-31 09:15:52 -04:00
Shannon Booth	caf959f06c	LibWeb/FileAPI: Handle an aborted stream in Blob::get_stream() close ... The streams AO that we were calling to close the stream would assert if it was not in a readable state. This version of close is exported publicly in the streams specification, and properly handles this situation. Fixes a crash in the imported test, and happens to fix some others!	2025-05-31 09:12:57 -04:00
Timothy Flynn	667a568526	Meta: Add compiler arguments to the debug build mode	2025-05-30 20:06:15 -04:00
Andrew Kaster	6f9e56870e	CMake: Exclude GlobalFontConfig.h from autogenerated clang module ... This header file is never included by any other headers, and including it would require adding the fontconfig include paths to the swift interop header generation, which is not desirable.	2025-05-30 15:21:17 -06:00
Andrew Kaster	17b7f192c4	LibGfx: Add a strict CMake check for the libpng apng patch	2025-05-30 15:21:07 -06:00
Andrew Kaster	8f0dad0898	CMake: Use static libraries for try_compile() in libfuzzer builds	2025-05-30 15:21:07 -06:00
Andrew Kaster	645eac1734	CI: Use new name for macOS JS artifact in js-benchmarks workflow ... This was missed in 1a0b83a59f	2025-05-30 14:20:44 -06:00
Timothy Flynn	3786d56814	Meta: Remove msbuild presets ... Let's just support ninja for simplicity. The msbuild presets are significantly slower anyhow.	2025-05-30 13:52:51 -04:00
Andrew Kaster	1a0b83a59f	CI: Rename macOS js REPL artifact to match name of tgz ... We haven't built a universal binary in over 11 months. The name is confusing, and actually breaks esvu on macOS. The fact that nobody has complained suggests that this is not a common use case..	2025-05-30 11:28:06 -06:00
Andrew Kaster	30fe721a3d	CMake: Set a higher default CMAKE_OSX_DEPLOYMENT_TARGET with Swift ... We have tests that require 15.0 without checking for availability.	2025-05-30 12:54:12 -04:00
Andrew Kaster	68bba89dc3	CMake: Set macOS deployment target for vcpkg ports to match our build ... Without this, ports get built with whatever default is there from the toolchain, and we get all sorts of linker warnings about a mismatch.	2025-05-30 12:54:12 -04:00
Timothy Flynn	0958c5f508	Meta: Provide compiler jobs as a command line argument ... On my Linux machine with 32 cores, ninja actually defaults to 34 jobs. By defaulting ourselves to multiprocessing.cpu_count(), we actually decrease the number of jobs used.	2025-05-30 12:03:38 -04:00
Timothy Flynn	e6938e11b0	Meta: Inspect the host compiler only when needed ... We don't need to pick a host compiler every time ladybird.py is invoked. We only need to do so when configuring the Build directory. This shaves about 10ms off an invocation of `ladybird.py build` on my machine, going from ~170ms to ~160ms.	2025-05-30 12:03:38 -04:00