943 commits

Author	SHA1	Message	Date
Callum Law	cfc8d3031b	LibWeb: Map logical aliases at cascade time ... Previously we would incorrectly map these in `CSSStyleProperties::convert_declarations_to_specified_order`, aside from being too early (as it meant we didn't maintain them as distinct from their physical counterparts in CSSStyleProperties), this meant that we didn't yet have the required context to map them correctly. We now map them as part of the cascade process. To compute the mapping context we do a cascade without mapping, and extract the relevant properties (writing-direction and direction).	2025-06-23 15:19:07 +01:00
Callum Law	4e87f85458	LibWeb: Convert logical property shorthands to full-fledged shorthands ... No functionality changes. This is just prep work for later commits around moving logical alias mapping to cascade time	2025-06-23 15:19:07 +01:00
Callum Law	12581fa995	LibWeb: Resolve conflicts in compute_keyframe_values correctly ... As conflict resolution depends on whether the property was set directly or via a shorthand, we have to store the non-expanded values in the resolved keyframe properties.	2025-06-23 15:19:07 +01:00
Tim Ledbetter	9b6da84fff	LibWeb/CSS: Implement the font-kerning property ... This sets whether the kerning information stored on the current font is used.	2025-06-23 13:26:48 +01:00
Callum Law	80ea865b19	LibWeb: Use correct error for invalid rule in nested insertRule ... When we try to insert a disallowed (non-nested) statement into a CSSGroupingRule we should throw a `HierarchyRequestError` as it being disallowed is a "constraint specified by CSS". Previously we would rely on `Parser::is_valid_in_the_current_context` and throw a Syntax error. There are more constraints to be implemented.	2025-06-23 12:52:40 +01:00
Callum Law	ef7ba02842	LibWeb: Throw error in insertRule when rule violates constraints	2025-06-23 12:52:40 +01:00
Callum Law	6144154e4f	LibWeb: Ensure valid placement of @import and @namespace rules ... These rules should appear before all other rules (excluding @layer statements and @charset) with @import appearing first.	2025-06-23 12:52:40 +01:00
Aliaksandr Kalenik	6ec6e755b2	LibWeb: Merge consecutive grid lines in GridTrackSizeList ... Fixes a bug where consecutively defined grid lines were not merged during serialization.	2025-06-22 21:15:40 +02:00
Aliaksandr Kalenik	af602b2555	LibWeb: Align CSS Grid properties parsing with the specification ... Reimplements `grid`, `grid-template`, `grid-template-rows`, and `grid-template-columns` in a way that uses a separate function for each grammar rule defined in the specification. This change results in many additional passing tests from the already imported WPT suite. Most of the remaining test failures are related to incorrect serialization of grid properties.	2025-06-21 22:07:08 +02:00
Callum Law	d7036daa89	LibWeb: Disallow trailing tokens in @supports(<declaration>)	2025-06-21 11:49:43 +01:00
Sam Atkins	c1d4323cf7	LibWeb: Support counter-* properties on pseudo-elements ... There are multiple things happening here which are interconnected: - We now use AbstractElement to refer to the source of a counter, which means we also need to pass that around to compute `content`. - Give AbstractElement new helper methods that are needed by CountersSet, so it doesn't have to care whether it's dealing with a true Element or PseudoElement. - The CountersSet algorithms now walk the layout tree instead of DOM tree, so TreeBuilder needs to wait until the layout node exists before it resolves counters for it. - Resolve counters when creating a pseudo-element's layout node. We awkwardly compute the `content` value up to twice: Once to figure out what kind of node we need to make, and then if it's a string, we do so again after counters are resolved so we can get the true value of any `counter()` functions. This will need adjusting in the future but it works for now.	2025-06-19 12:35:31 +01:00
Sam Atkins	498e143687	LibWeb/DOM: Stop including Element.h from AbstractElement.h ... We only need the forward declaration here, and this will let us include AbstractElement from Element.	2025-06-19 12:35:31 +01:00
Sam Atkins	dfce9974b5	LibWeb: Remove GeneratedPseudoElement enum ... This doesn't currently provide any value over just using PseudoElement, and makes it harder to work with PseudoElement in other places.	2025-06-19 12:35:31 +01:00
Sam Atkins	a57595faf5	LibWeb: Make [resolve,inherit]_counters() take AbstractElement ... This is one of those cases where the spec says "element" and means "element or pseudo-element". The easiest way to handle both is to make these be free functions that take an AbstractElement, and then give AbstractElement some helper methods so that the caller doesn't have to care which it's dealing with. There are some FIXMEs here because PseudoElement doesn't have a CountersSet yet, and because the CountersSet currently uses a UniqueNodeID to identify counter sources, which doesn't support pseudo-elements.	2025-06-19 12:35:31 +01:00
Sam Atkins	ce380a59c7	LibWeb/DOM: Rename ElementReference to AbstractElement ... This isn't some kind of identifier, it's a handle on an actual Element or PseudoElement.	2025-06-19 12:35:31 +01:00
Tim Ledbetter	07b3b70a10	LibWeb: Return the correct computed value for opacity properties	2025-06-19 10:27:35 +02:00
Tim Ledbetter	269d5bb40e	LibWeb: Resolve percentages for opacity properties at parse time	2025-06-19 10:27:35 +02:00
Gingeh	e96338dd63	LibWeb: Don't play initially-paused animations	2025-06-18 17:17:29 +02:00
Aliaksandr Kalenik	6169e91994	LibWeb: Delete redundant GridFitContent class from track representation ... GridSize already supports the FitContent type, so there is no need to additionally wrap it in a GridFitContent class.	2025-06-18 15:51:10 +01:00
Tim Ledbetter	e0af205d69	LibWeb/CSS: Implement the empty-cells property ... This property sets whether table borders and backgrounds are painted if a given table cell has no visible content.	2025-06-18 14:55:03 +01:00
Tim Ledbetter	fa1e02e5d7	LibWeb: Allow calc() values in cubic-bezier() easing functions	2025-06-18 08:57:06 +02:00
Tim Ledbetter	c5a3eaaf45	LibWeb: Allow calc() values in steps() easing functions	2025-06-18 08:57:06 +02:00
Veeti Paananen	21b531598d	LibWeb/CSS: Fix reference bug when canonicalizing linear easing stops ... +2 WPT tests	2025-06-18 08:53:10 +02:00
Aliaksandr Kalenik	b9b6927b85	LibWeb: Fix swapped strings for auto-fill and auto-fit in GridRepeat ... ...serialization.	2025-06-17 17:43:04 +01:00
Sam Atkins	7fe854c131	LibWeb/CSS: Link CalculationContext to new spec definition ... Corresponds to ad244f3413 There's nothing that we need to do differently I think, but it's nice to have a clear spec definition to refer to. :^)	2025-06-17 12:38:27 +01:00
Sam Atkins	a263ba78ed	LibWeb/CSS: Add FIXME that color-mix() now takes 1+ colors, not 2 ... Corresponds to 83c7bffe51	2025-06-17 12:38:27 +01:00
Sam Atkins	1435480d76	LibWeb/CSS: Add fixme for sRGB color interpolation ... Corresponds to a0a9886063	2025-06-17 12:38:27 +01:00
Tim Ledbetter	59a2e10a4e	LibWeb: Distinguish between empty block at-rules and statement at-rules	2025-06-17 08:58:00 +01:00
Tim Ledbetter	701fcb9e87	LibWeb: Allow anonymous layer block rule with no declarations	2025-06-17 08:58:00 +01:00
Tim Ledbetter	30cdacc05a	LibWeb: Add flow relative values for the clear property ... Currently `inline-start` and `inline-end` are always treated as `left` and `right` respectively.	2025-06-17 09:26:26 +02:00
Tim Ledbetter	28b24b72bc	LibWeb: Don't resolve flow-relative values for float too early ... This allows `getComputedStyle()` to return the correct value if `float` is set to `inline-start` or `inline-end`	2025-06-17 09:26:26 +02:00
Tim Ledbetter	6c6219db05	LibWeb: Use shorthand keywords for contain used value where possible ... The used value of `contain` is now set to `strict` or `content` when the relevant set of containment keywords are specified.	2025-06-17 08:17:33 +01:00
Tim Ledbetter	96d8bed35b	LibWeb/CSS: Serialize contain values in canonical order	2025-06-17 08:17:33 +01:00
Callum Law	12c9da2d3f	LibWeb: Serialize grid/grid-template as "none" when applicable ... This exposes a bunch of false-positives in the grid-{shorthand,template}-invalid.html WPT tests, but gains us some new passes as well.	2025-06-16 12:37:40 +01:00
Callum Law	7d81823eb3	LibWeb: Handle CSS-wide keywords in style_property_for_sided_shorthand ... CSS-wide keywords should not be concatenated in the same way as other values unless they are all the same.	2025-06-16 12:37:40 +01:00
Callum Law	62da650992	LibWeb: Don't serialize longhands if we directly serialized shorthand ... The spec assumes that we only store values against expanded longhands, there are however limited circumstances where we store against shorthands directly in addition to the expanded longhands. For example if the value of the shorthand is unresolved we store an UnresolvedStyleValue against the shorthand directly and a PendingSubstitutionStyleValue against each of the longhands. This commit updates the logic so that in the case we serialize a shorthand directly we should also mark it's longhands as serialized to avoid serializing them separately. This also avoids the scenario where we tried to create and serialize a ShorthandStyleValue with PendingSubstitutionStyleValue longhands, so we can remove the check and related FIXME for that.	2025-06-16 12:37:40 +01:00
Callum Law	f8f4da3b90	LibWeb: Don't serialize shorthand with non-uniform CSS-wide keywords	2025-06-16 12:37:40 +01:00
Callum Law	3c6b8d5a2c	LibWeb: Propagate CSS-wide keyword to transition longhands ... Previously we would treat CSS-wide keywords as equivalent to "none"	2025-06-16 12:37:40 +01:00
Callum Law	335190e925	LibWeb: Handle nested shorthands in all-same-CSS-wide-keyword to_string ... Previously we only checked direct sub-properties, not accounting for the nested case.	2025-06-16 12:37:40 +01:00
Tim Ledbetter	7faeef8d0d	LibWeb: Treat font-variant values with unknown keywords as invalid	2025-06-15 16:44:51 +02:00
Tim Ledbetter	d89a67ffee	LibWeb: Don't serialize omitted box-shadow and text-shadow values	2025-06-15 16:05:12 +02:00
Tim Ledbetter	68d3ddb1a7	LibWeb: Parse the transform-origin z-value	2025-06-15 16:01:54 +02:00
Tim Ledbetter	a8d5758777	LibWeb: Only resolve transform-origin keywords for the computed value ... Previously, we were resolving these keywords at parse time, which gave an incorrect serialization of the specified value.	2025-06-15 16:01:54 +02:00
Tim Ledbetter	a3f6e71e33	LibWeb/CSS: Disallow third argument in 2D scale functions	2025-06-15 15:59:02 +02:00
Tim Ledbetter	39cef6eeb5	LibWeb: Disallow default as a keyframe name	2025-06-14 17:56:10 -04:00
Tim Ledbetter	64728aef6c	LibWeb: Disallow non-ASCII font-language-override values	2025-06-14 16:05:04 -04:00
Tim Ledbetter	c55f281475	LibWeb: Disallow empty font-language-override string values	2025-06-14 16:05:04 -04:00
Tim Ledbetter	028bcd3d67	LibWeb/CSS: Backtrack the parser if a property does not accept a value	2025-06-14 08:22:56 +02:00
Tim Ledbetter	26293114d8	LibWeb/CSS: Treat repeated text-decoration-line values as invalid	2025-06-14 08:19:47 +02:00
Aliaksandr Kalenik	fdecdb9410	LibWeb/CSS: Remove unused default constructors in GridTrackSize.h	2025-06-13 19:57:00 +02:00