Max Trussell
99b263a2db
Userland/Notify: Check if optional icon arg is null before loading
...
The commandline "notify" application was always attempting to load an
icon path from an optional argument, even when the argument was
omitted. In this case, the image icon argument would be a null pointer
and the notify program would crash.
This fix adds a conditional to only attempt to load the icon file if
the icon_path variable is not a null pointer
2021-12-19 00:50:53 -08:00
Michel Hermier
060e5ccbbc
Lagom: Bind time_zone_list_index_type
in the generator
...
The variable `s_time_zone_list_index_type` seems to be unused (detected
when compiling with clang), and it seems logical to bind it even it if
it is not used for now.
2021-12-18 21:01:10 -08:00
Michel Hermier
0bfb7f9675
LibC: Move _abort
next to abort
...
It should be now the only user of it, and it is more logical to have it
in `stdlib.h` than in `assert.h`
2021-12-18 21:01:10 -08:00
Michel Hermier
2c62d51e25
LibC: Remove VERIFY_NOT_REACHED()
from assert.h
...
Both `AK/Assertions.h` and `assert.h` would define the macro if `NDEBUG`
is set.
Remove the definition from `assert.h` since it is not an ISO-C
requirement.
2021-12-18 21:01:10 -08:00
Michel Hermier
ee42acddf8
LibC: Make __assertion_failed
always defined
...
The symbol should be always defined, in case Serenity is built with
`NDEBUG` defined, and users wants to use `assert` from `LibC`.
2021-12-18 21:01:10 -08:00
Michel Hermier
35a5305264
LibC: Remove undefined __generate_unique_filename
declaration
2021-12-18 21:01:10 -08:00
Luke Wilde
cf5f08b317
LibJS: Only allow TimeZone this value in TimeZone#getPlainDateTimeFor
...
This is a normative change in the Temporal spec.
See: 2644fc6
2021-12-19 00:13:01 +00:00
Luke Wilde
7729598b5b
LibJS: Only allow TimeZone this value in Temporal.TimeZone#toJSON
...
This is a normative change in the Temporal spec.
See: 2644fc6
2021-12-19 00:13:01 +00:00
Luke Wilde
6c8c34ed6c
LibJS: Only allow TimeZone this value in Temporal.TimeZone#id
...
This is a normative change in the Temporal spec.
See: 2644fc6
2021-12-19 00:13:01 +00:00
Luke Wilde
803e96f0c5
LibJS: Only allow Calendar this value in Temporal.Calendar#toJSON
...
This is a normative change in the Temporal spec.
See: 2644fc6
2021-12-19 00:13:01 +00:00
Linus Groh
5277646f46
LibJS: Fix 'precision != "auto"' check in temporal_duration_to_string()
...
If the Variant does *not* have a StringView, it *also* is not "auto".
Thanks to YouTube user JWeis for noticing this :^)
2021-12-18 23:20:00 +00:00
Astraeus-
a961a51692
Profiler: Convert to try_create_default_icon
...
and sprinkle in some more TRY() statements
2021-12-18 23:36:59 +01:00
Astraeus-
8513aff1cd
Playground: Convert to try_create_default_icon
...
and sprinkle in some more TRY() statements
2021-12-18 23:36:59 +01:00
Astraeus-
64a5f990b1
Inspector: Convert to try_create_default_icon
2021-12-18 23:36:59 +01:00
Astraeus-
d12359ff20
WidgetGallery: Convert to try_create_default_icon
2021-12-18 23:36:59 +01:00
Astraeus-
1adc808664
Mouse: Convert to try_create_default_icon
2021-12-18 23:36:59 +01:00
Astraeus-
b9579de2b5
ModelGallery: Convert to try_create_default_icon
2021-12-18 23:36:59 +01:00
Astraeus-
683077c894
LibGfxScaleDemo: Convert to try_create_default_icon
2021-12-18 23:36:59 +01:00
Astraeus-
1c189dbba5
LibGfxDemo: Convert to try_create_default_icon
2021-12-18 23:36:59 +01:00
Astraeus-
4db2f5b4ae
Eyes: Convert to try_create_default_icon
2021-12-18 23:36:59 +01:00
Astraeus-
b02da2442f
CatDog: Convert to try_create_default_icon
2021-12-18 23:36:59 +01:00
Astraeus-
3e4e055c76
ClipboardHistory: Convert to try_create_default_icon
2021-12-18 23:36:59 +01:00
Astraeus-
3ca72831d1
Solitaire: Convert to try_create_default_icon
2021-12-18 23:36:59 +01:00
Astraeus-
bb214dd7e8
Pong: Convert to try_create_default_icon
2021-12-18 23:36:59 +01:00
Astraeus-
07cf17f328
2048: Convert to try_create_default_icon
2021-12-18 23:36:59 +01:00
Astraeus-
c1820770bb
Minesweeper: Convert to try_create_default_icon
2021-12-18 23:36:59 +01:00
Astraeus-
421f91e4ca
Hearts: Convert to try_create_default_icon
2021-12-18 23:36:59 +01:00
Astraeus-
88ce05317f
Chess: Convert to try_create_default_icon
2021-12-18 23:36:59 +01:00
Astraeus-
21335ad720
Spider: Convert to try_create_default_icon
2021-12-18 23:36:59 +01:00
Astraeus-
29d5fee07e
FlappyBug: Convert to try_create_default_icon
2021-12-18 23:36:59 +01:00
Astraeus-
ff3272b60d
GameOfLife: Convert to try_create_default_icon
2021-12-18 23:36:59 +01:00
Astraeus-
a15b86cd01
Snake: Convert to try_create_default_icon
2021-12-18 23:36:59 +01:00
Astraeus-
38f47a79d0
Breakout: Convert to try_create_default_icon
2021-12-18 23:36:59 +01:00
Nick Johnson
e122502f70
AK: Speed up BitmapView::find_next_range_of_unset_bits
...
While watching Andreas' most recent video, I noticed that this function
only worked with 32 bit values, but was a serious performance
bottleneck for the kernel. As such, I reworked it to use `size_t`, so
it now can switch to 64-bit sweeps on 64-bit platforms. This caused
test-js to go from 12.5 seconds hot to 11.5 seconds hot on my machine
when running on KVM x86_64.
2021-12-18 23:36:08 +01:00
Nick Johnson
548529ace4
AK: Add BuiltinWrappers.h
...
The goal of this file is to enable C++ overloaded functions for
standard builtin functions that we use. It contains fallback
implementations for systems that do not have the builtins available.
2021-12-18 23:36:08 +01:00
Linus Groh
01eefc344a
LibJS: Disallow date-only strings for PlainTime
...
This is a normative change in the Temporal spec.
See: b16a296
2021-12-18 22:32:39 +00:00
Linus Groh
6da6da73cc
LibJS: Allow 'T' prefix in time-only strings
...
This is a normative change in the Temporal spec.
See: f5e8edf
2021-12-18 22:32:39 +00:00
Linus Groh
acce65b52c
LibJS: Fix fractionalSecondDigits behavior in Duration.proto.toString()
...
This is a normative change in the Temporal spec.
See: 3ee771e
2021-12-18 22:32:39 +00:00
Linus Groh
6d5e95d621
LibJS: Add optional calendar to Plain{Time,YearMonth,MonthDay} prod
...
This is a normative change in the Temporal spec.
See: 7e58ba3
2021-12-18 22:32:39 +00:00
Linus Groh
b70a55bd5a
LibJS: Update spec comment in get_iso_parts_from_epoch()
...
This is a normative change in the Temporal spec.
See: bdf60f5
2021-12-18 22:32:39 +00:00
Linus Groh
4b7f716f21
LibJS: Fix ambiguity in FractionalPart grammar
...
This is a normative change in the Temporal spec.
See: 0f11bd6
2021-12-18 22:32:39 +00:00
Linus Groh
bbfbd02c1b
LibJS: Make PlainDate difference methods units handling consistent
...
This is a normative change in the Temporal spec.
See: 8b7ba00
2021-12-18 22:32:39 +00:00
Linus Groh
006bea5d31
LibJS: Remove outdated comment in prepare_partial_temporal_fields()
...
This is a normative change in the Temporal spec.
See: bf066ea
2021-12-18 22:32:39 +00:00
Linus Groh
69b8079b11
LibJS: Fix "smallestUnit" property name typo in a couple of places
...
This is a normative change in the Temporal spec.
See: 900e4bc
2021-12-18 22:32:39 +00:00
Linus Groh
70e6eae27b
LibJS: Fix off-by-one in balance_iso_date() for leap year inputs
...
This is a normative change in the Temporal spec.
See: 5ab1822
2021-12-18 22:32:39 +00:00
Linus Groh
7270bbb255
LibJS: Remove outdated comment from parse_temporal_duration_string()
...
This is a normative change in the Temporal spec.
See:
- e7182d3
- 6dae066
2021-12-18 22:32:39 +00:00
Linus Groh
247d2f7cc4
LibJS: Only allow Calendar this value in Temporal.Calendar.prototype.id
...
This is a normative change in the Temporal spec.
See: 2644fc6
2021-12-18 22:32:39 +00:00
Junior Rantila
1f7c196788
LibC: Make sysbeep return int instead of void
...
Since the beep syscall may fail it is strange that the error is
discarded by the LibC wrapper.
2021-12-18 10:36:35 -08:00
Hendiadyoin1
18013f3c06
Kernel: Remove a redundant check in Process::remap_range_as_stack
...
We already VERIFY that we have carved something out, so we don't need to
check that again.
2021-12-18 10:31:18 -08:00
Hendiadyoin1
2d28b441bf
Kernel: Collapse a redundant boolean conditional return statement in …
...
validate_mmap_prot
2021-12-18 10:31:18 -08:00