9149 commits

Author	SHA1	Message	Date
Timothy Flynn	c846616d51	LibWeb: Adjust positions by the scroll offset for scrollbar hit testing ... This ensures we scroll to the correct position when dragging a scrollbar or clicking its gutter.	2025-05-08 10:40:58 +01:00
Timothy Flynn	22532c769c	LibWeb: Be less lenient in scrollbar hit testing ... A scrollbar contains a mouse position only if its gutter rect contains that position. We were incorrectly deciding a position was contained if it fell to the right of a vertical scrollbar, or below a horizontal scrollbar.	2025-05-08 10:40:58 +01:00
Sam Atkins	a8529629e2	LibWeb/HTML: Update "is script closable" to current spec ... Corresponds to d7fc63a84a and 7a48703e77	2025-05-08 10:39:34 +01:00
Ali Mohammad Pur	292688e249	LibWasm: Validate tables, memories, globals, elements and data correctly ... These sections are supposed to be validated with only the imported globals.	2025-05-08 03:35:11 -06:00
Ali Mohammad Pur	638a354b29	LibWeb/WebAssembly: Throw appropriate errors as defined by the spec	2025-05-08 03:35:11 -06:00
Ali Mohammad Pur	333ba93d49	LibWeb/WebAssembly: Define the hacky 'native' errors given in the spec ... These cannot be implemented "correctly" as the set of native errors as defined by ecma262 is closed, but we can get pretty close.	2025-05-08 03:35:11 -06:00
Francesco Gazzetta	5610f5a865	LibWeb/HTML: Add missing include to CanvasRenderingContext2D.cpp ... Fixes linking of CanvasRenderingContext2D on some systems: [2959/3075] Linking CXX shared library lib/liblagom-web.so.0.0.0 FAILED: lib/liblagom-web.so.0.0.0 : && /nix/store/f0m6caffiykyvsjim9376a3hx2yj2ghj-gcc-wrapper-14.2.1.20250322/bin/g++ -fPIC -O3 -DNDEBUG -fstack-protector-strong -Wl,-z,defs -Wl,--no-undefined -Wl,--no-allow-shlib-undefined -Wl,--dependency-file=Lagom/Libraries/LibWeb/CMakeFiles/LibWeb.dir/link.d -shared -Wl,-soname,liblagom-web.so.0 -o lib/liblagom-web.so.0.0.0 @CMakeFiles/LibWeb.rsp && : /nix/store/hzw38c3f7s0w200cgk9645z53al7k8lw-binutils-2.44/bin/ld: Lagom/Libraries/LibWeb/CMakeFiles/LibWeb.dir/HTML/CanvasRenderingContext2D.cpp.o: in function `Web::HTML::CanvasRenderingContext2D::context_attributes_from_options(JS::VM&, JS::Value) [clone .localalias]': CanvasRenderingContext2D.cpp:(.text+0x355a): undefined reference to `JS::Value::to_boolean() const' /nix/store/hzw38c3f7s0w200cgk9645z53al7k8lw-binutils-2.44/bin/ld: CanvasRenderingContext2D.cpp:(.text+0x38e6): undefined reference to `JS::Value::to_boolean() const' /nix/store/hzw38c3f7s0w200cgk9645z53al7k8lw-binutils-2.44/bin/ld: CanvasRenderingContext2D.cpp:(.text+0x3d67): undefined reference to `JS::Value::to_boolean() const' collect2: error: ld returned 1 exit status ninja: build stopped: subcommand failed. Co-authored-by: Timothy Flynn <trflynn89@pm.me>	2025-05-07 16:53:09 -04:00
Jelle Raaijmakers	d424dc1b32	LibWeb: Assign new wrapped node list to container for insertParagraph ... Forgot to implement this part of the spec.	2025-05-07 16:11:31 +02:00
Jelle Raaijmakers	c56f7d9cde	LibWeb: Invalidate sibling style for :only-child and :*-of-type ... After f7a3f785a8, sibling nodes' styles were no longer invalidated after a node was removed. This reuses the flag for `:first-child` and `:last-child` to indicate that a node's style might be affected by any structural change in its siblings. Fixes #4631. Resolves the `:only-child` ACID3 failure as documented in #1231.	2025-05-07 14:55:12 +03:00
Andreas Kling	74f133293d	LibJS: Avoid redundant ExecutionContext allocation for bound functions ... Instead of creating a second ExecutionContext in BoundFunction.[[Call]], we now implement BoundFunction::get_stack_frame_size() and combine information from the target + the bound arguments list. This allows BoundFunction.[[Call]] to reuse the already-established ExecutionContext for the callee. 1.20x speedup on MicroBench/bound-call-04-args.js	2025-05-07 13:20:41 +02:00
Psychpsyo	dbece92637	LibWeb: Make elements with 'opacity: 0' respond to hit-testing	2025-05-07 01:45:07 +03:00
Andreas Kling	d462731a4d	LibJS: Make PutById inline cache polymorphic (4 shapes) ... 2.44x speedup on MicroBench/pic-put-own.js 1.48x speedup on MicroBench/pic-put-pchain.js	2025-05-07 00:27:11 +02:00
Andreas Kling	a677d96b8f	LibJS: Make GetById cache polymorphic ... Instead of monomorphic (1 shape), GetById inline caches are now polymorphic (4 shapes). This improves inline cache hit rates greatly on most web JavaScript. For example, Speedometer 2.1 sees 88% -> 97% cache hit rate improvement. 1.71x speedup on MicroBench/pic-get-own.js 1.82x speedup on MicroBench/pic-get-pchain.js	2025-05-07 00:27:11 +02:00
Lyra	39dae6fb2d	LibWeb: Fix SRI handling of badly-formatted strings	2025-05-06 13:02:58 -04:00
Timothy Flynn	0da7441b9b	LibWeb: Set the initiator type for script-initiated CSS requests ... Similar to other ad-hoc behavior in this method, we need to handle requests which are not associated with a style sheet. For example: <script> const element = document.createElement('div'); element.style['background'] = 'url(https://foo.com/img.png)'; document.body.appendChild(element); </script> Will not be associated with a style sheet. This is needed to ensure we fire a PerformanceResourceTiming event for this resource load. This is not currently testable in CI, as this event is also gated by HTTP/S requests.	2025-05-06 17:37:34 +01:00
Timothy Flynn	4fc8443757	LibWeb: Translate scrollbar gutters by the cumulative scroll offset ... This `translate_by` function is invoked with the cumulative scroll offset during display list execution. Applying the offset to the gutter was missed in 66e422b4f1.	2025-05-06 16:38:23 +03:00
stelar7	9d5f6108e4	LibWeb/IDB: Implement recent spec changes	2025-05-06 13:30:37 +01:00
Mark Langen	6cbb5d2785	LibWeb: Parse and propagate touch-action CSS property ... Co-authored-by: Sam Atkins <sam@ladybird.org>	2025-05-06 12:22:01 +01:00
Aliaksandr Kalenik	b3713db4ab	LibJS: Emit ThrowIfTDZ for identifiers used in assignment expressions ... Error about not-initialized `x` variable access should be thrown for: ```js function foo() { x = 69; let x; } foo(); ``` Progress on test262: ``` Diff Tests: test/staging/sm/expressions/optional-chain-tdz.js ❌ -> ✅ test/staging/sm/expressions/short-circuit-compound-assignment-tdz.js ❌ -> ✅ ``` Fixes https://github.com/LadybirdBrowser/ladybird/issues/4587	2025-05-06 12:06:23 +02:00
Aliaksandr Kalenik	db480b1f0c	LibJS: Preserve information about local variables declaration kind ... This is required for upcoming change where we want to emit ThrowIfTDZ for assignment expressions only for lexical declarations.	2025-05-06 12:06:23 +02:00
stelar7	2774068ca0	LibWeb/IDB: Initialize the index set in a ObjectStore handle	2025-05-06 11:16:01 +02:00
stelar7	0ed71d87ca	LibWeb/IDB: Dont move away the name when creating an Index	2025-05-06 11:16:01 +02:00
stelar7	f3a31c98ea	LibWeb/IDB: Use correct key comparison when doing Index lookup	2025-05-06 11:16:01 +02:00
stelar7	64c4bea189	LibWeb/IDB: Implement IDBCursor::continue	2025-05-06 11:16:01 +02:00
stelar7	08f73db773	LibWeb/IDB: Return undefined if request was an error	2025-05-06 11:16:01 +02:00
stelar7	d0156e2c88	LibWeb/IDB: Use invalidation reason when returning DataError	2025-05-06 11:16:01 +02:00
stelar7	05fe37619a	LibWeb/IDB: Implement IDBObjectStore::open_cursor	2025-05-06 11:16:01 +02:00
stelar7	98d08b27e4	LibWeb/IDB: Implement iterate_a_cursor	2025-05-06 11:16:01 +02:00
stelar7	0890b10d11	LibWeb/IDB: Improve error messages related to transaction state	2025-05-06 11:16:01 +02:00
Bastiaan van der Plaat	58b735010b	LibWeb: Add -webkit-box-* legacy CSS property aliases	2025-05-05 23:36:31 +02:00
Andreas Kling	183c847c80	LibJS: Cache PutById to setters in the prototype chain ... This is *extremely* common on the web, but barely shows up at all in JavaScript benchmarks. A typical example is setting Element.innerHTML on a HTMLDivElement. HTMLDivElement doesn't have innerHTML, so it has to travel up the prototype chain until it finds it. Before this change, we didn't cache this at all, so we had to travel the prototype chain every time a setter like this was used. We now use the same mechanism we already had for GetBydId and cache PutById setter accesses in the prototype chain as well. 1.74x speedup on MicroBench/setter-in-prototype-chain.js	2025-05-05 15:21:43 +02:00
Jelle Raaijmakers	71665fa504	LibWeb: Scale font size by 1.15 for line-height: normal ... Browsers such as Chrome and Firefox apply an arbitrary scale to the current font size if `normal` is used for `line-height`. Firefox uses 1.2 while Chrome uses 1.15. Let's go with the latter for now, it's relatively easy to change if we ever want to go back on that decision. This also requires updating the expectations for a lot of layout tests. The upside of this is that it's a bit easier to compare our layout results to other browsers', especially Chrome.	2025-05-05 13:15:56 +02:00
Timothy Flynn	01791c5a52	LibJS: Mark sync module evaluation promise as handled ... This is a normative change in the ECMA-262 spec. See: 0fb1859 As noted in the PR for this change, this is not actually testable via either test262 or WPT.	2025-05-05 17:50:18 +12:00
Psychpsyo	7c36a82129	LibWeb: Improve parsing for the CSS contain property ... This makes us actually respect the grammar and nets us a couple extra WPT passes in the parsing section.	2025-05-04 22:24:26 +01:00
Timothy Flynn	1c075d6039	LibWeb: Remove Web::Infra ASCII case conversion methods ... We have more optimized versions of these methods in AK.	2025-05-04 15:59:17 +02:00
Andreas Kling	bf1b754e91	LibJS: Optimize reading known-to-be-initialized var bindings ... `var` bindings are never in the temporal dead zone (TDZ), and so we know accessing them will not throw. We now take advantage of this by having a specialized environment binding value getter that doesn't check for exceptional cases. 1.08x speedup on JetStream.	2025-05-04 02:31:18 +02:00
Andreas Kling	ad7c1e147f	LibJS: Add SetGlobal bytecode instruction for cached global writes ... Before this change, setting a global would end up as SetLexicalBinding. That instruction always failed to cache the access if the global was a property of the global object. 1.14x speedup on Octane/earley-boyer.js 2.04x speedup on MicroBench/for-of.js Note that MicroBench/for-of.js was more of a "set global" benchmark before this. After this change, it's actually a for..of benchmark. :^)	2025-05-04 01:58:57 +02:00
Sam Atkins	de6df6f403	LibWeb/CSS: Parse and use CSS URL request modifiers	2025-05-03 23:22:40 +01:00
Sam Atkins	a1fb34d7f2	LibWeb/CSS: Alphabetize Enums.json	2025-05-03 23:22:40 +01:00
Andreas Kling	edb5547e37	LibJS: Don't incrementally delete PropertyNameIterator while iterating ... We were spending a lot of time removing each property name from the iterator's underlying HashMap while iterating over it. This wasn't actually necessary, so let's stop doing it and instead just iterate over the property names with a stored HashTable iterator. 1.10x speedup on MicroBench/for-in-indexed-properties.js	2025-05-03 22:00:51 +02:00
Andreas Kling	570d1e8811	LibJS: Use PrimitiveString more instead of Utf16String in String code ... This avoids a whole lot of unnecessary roundtrips from UTF8 <=> UTF16.	2025-05-03 20:01:20 +02:00
Andreas Kling	98fef16972	LibJS: Use PrimitiveString more instead of Utf16String in RegExp code ... PrimitiveString has an internal UTF-16 string cache anyway, and so this actually avoids repeatedly converting between UTF-8 and UTF-16.	2025-05-03 20:01:20 +02:00
Andreas Kling	7c26354563	LibJS: Avoid Value->PropertyKey->Value roundtrip in for..in iteration ... Before this change, we would call [[OwnPropertyKeys]] on the target objects, then convert the returned keys from Value into PropertyKey. Then, when actually iterating, we'd convert them back into Value again. This was particularly costly for numeric property keys, since we had to go through string-from-number construction. Now, we simply keep the original values returned by [[OwnPropertyKeys]] around and use them for the enumeration. 1.09x speedup on MicroBench/for-in-indexed-properties.js 1.01x speedup on MicroBench/for-in-named-properties.js	2025-05-03 17:33:54 +02:00
Andreas Kling	11ece7de10	LibGC: Add GC::RootHashMap<...> template container ... This is a GC-aware wrapper around AK::HashMap. Entry values are treated as GC roots, much like the GC::RootVector we already had. We also provide GC::OrderedRootHashMap as a convenience.	2025-05-03 17:33:54 +02:00
Timothy Flynn	8a80ff7b3b	AK+LibJS: Use simdutf for all base64 operations ... We were previously unable to use simdutf for base64 decoding operations other than "loose". Upstream has added support for the "strict" and "stop-before-partial" operations, so let's make use of them!	2025-05-03 11:21:10 -04:00
Shannon Booth	e476d21ed0	LibJS: Add and use PrimitiveString::length_in_utf16_code_units ... I was investigating an optimization in this area, and while it didn't seem to have a noticable improvement, it still seems useful to apply this change.	2025-05-03 16:18:47 +02:00
Sam Atkins	560317b3d0	LibWeb/CSS: Update spec comment in calc() simplification algorithm ... This was corrected in 8bcf3ada9e	2025-05-03 14:54:33 +01:00
Sam Atkins	1cb1526178	LibWeb/CSS: Remove document-URL hack from create_a_style_sheet() ... We no longer need this, because we don't complete URLs during parsing, and the location is set elsewhere when needed.	2025-05-03 12:01:43 +01:00
Sam Atkins	bc1d323ba0	LibWeb/CSS: Remove URL parameter to the CSS Parser ... We no longer complete any URLs during parsing.	2025-05-03 12:01:43 +01:00
Sam Atkins	9e2e796f2d	LibWeb/CSS: Use CSS::URL for font-fetching ... ParsedFontFace and FontLoader now both keep track of which CSSStyleSheet (if any) was the source of the font-face, so the URLs can be completed correctly.	2025-05-03 12:01:43 +01:00