163 commits

Author	SHA1	Message	Date
Tim Ledbetter	fa1e02e5d7	LibWeb: Allow calc() values in cubic-bezier() easing functions	2025-06-18 08:57:06 +02:00
Tim Ledbetter	c5a3eaaf45	LibWeb: Allow calc() values in steps() easing functions	2025-06-18 08:57:06 +02:00
Veeti Paananen	21b531598d	LibWeb/CSS: Fix reference bug when canonicalizing linear easing stops ... +2 WPT tests	2025-06-18 08:53:10 +02:00
Sam Atkins	7fe854c131	LibWeb/CSS: Link CalculationContext to new spec definition ... Corresponds to ad244f3413 There's nothing that we need to do differently I think, but it's nice to have a clear spec definition to refer to. :^)	2025-06-17 12:38:27 +01:00
Callum Law	12c9da2d3f	LibWeb: Serialize grid/grid-template as "none" when applicable ... This exposes a bunch of false-positives in the grid-{shorthand,template}-invalid.html WPT tests, but gains us some new passes as well.	2025-06-16 12:37:40 +01:00
Callum Law	f8f4da3b90	LibWeb: Don't serialize shorthand with non-uniform CSS-wide keywords	2025-06-16 12:37:40 +01:00
Callum Law	335190e925	LibWeb: Handle nested shorthands in all-same-CSS-wide-keyword to_string ... Previously we only checked direct sub-properties, not accounting for the nested case.	2025-06-16 12:37:40 +01:00
Tim Ledbetter	d89a67ffee	LibWeb: Don't serialize omitted box-shadow and text-shadow values	2025-06-15 16:05:12 +02:00
Callum Law	d31a58a7d6	LibWeb: Add support for the 'all' CSS property ... The "longhands" array is populated in the code generator to avoid the overhead of manually maintaining the list in Properties.json There is one subtest that still fails in 'cssstyledeclaration-csstext-all-shorthand', this is related to us not maintaining the relative order of CSS declarations for custom vs non-custom properties.	2025-06-12 15:25:35 +01:00
Callum Law	0a53aaa3b6	LibWeb: Omit initial values from background CSS property serialization	2025-06-09 10:43:50 +01:00
Sam Atkins	d611806f18	LibWeb/CSS: Parse and use tech() in @font-face { src }	2025-06-05 12:10:29 +01:00
Timothy Flynn	7d99a92135	LibWeb: Absolutize CSS image URLs for computed style resolution ... For getComputedStyle(), we must return an absolute URL for image style values. We currently return the raw parsed URL. This fixes loading the marker icons on https://usermap.serenityos.org.	2025-06-03 19:30:43 -04:00
Tim Ledbetter	e2d0d8e2b9	LibWeb/CSS: Implement the scrollbar-color property ... This allows the user to set the scrollbar thumb and track colors.	2025-06-02 00:17:51 +02:00
Lucien Fiorini	0fcb574041	LibGfx+LibWeb: Turn Gfx::Filter into a SkImageFilter wrapper	2025-06-01 23:22:10 +02:00
Callum Law	94f5a51820	LibWeb: Convert white-space CSS property to shorthand ... This exposed a few bugs which caused the following tests to behave incorrectly: - `tab-size-text-wrap.html`: This previously relied on a bug where we incorrectly treated `white-space: pre` as allowing text wrapping. The fix here is to implement the text-wrap CSS shorthand property. - `execCommand-preserveWhitespace.html`: We don't correctly serialize shorthand properties. This is covered by an existing FIXME in `CSSStyleProperties::serialized()` - `white-space-shorthand.html`: The last 5 subtests here fail as we don't correctly handle shorthand properties in `CSSStyleProperties::remove_property()`. This is covered by an existing FIXME in said function.	2025-05-29 12:04:28 +02:00
Sam Atkins	f5cd853597	LibWeb/CSS: Avoid calling to_font_weight() when serializing font ... This function attempts to resolve `lighter` and `bolder`, which we don't want to do when serializing - that should happen in style computation. This has the unexpected bonus of 37 more WPT passes!	2025-05-24 13:35:30 +01:00
Sam Atkins	fe7bac73f0	LibWeb/CSS: Stub out a function for serializing ComponentValue sequences ... This is very hacky and wrong, but it means there's one place to fix, instead of one for UnresolvedStyleValue, and one for invalid MediaFeatureValues which I'm about to implement.	2025-05-23 10:17:58 +01:00
Andreas Kling	d7cd8f0fc7	LibWeb: Make CSS sign(A) ignore A's unit and just look at the raw value ... This allows stuff like sign(1em) even when we don't have something to resolve the em unit against. +25 new WPT subtest passes.	2025-05-20 13:28:40 +02:00
Andreas Kling	4ef34ebd96	LibWeb: Make CSS sign(A) behave correctly for negative zero ... We were incorrectly returning 0 instead of -0 for sign(-0). +7 new WPT subtest passes.	2025-05-20 13:28:40 +02:00
Sam Atkins	443f9e5afb	LibWeb/CSS: Make dimension types serialize in resolved form ... Some dimensions would always serialize in a canonical unit, others never did, and others we manually would do so in their StyleValue. This commit moves all of that into the dimension types, which means for example that Length can apply its special rounding. Our local serialization test now produces the same output as other browsers. :^)	2025-05-17 07:53:24 +01:00
Sam Atkins	eec4365542	LibWeb/CSS: Extract SerializationMode into its own header ... Prep for using this to serialize dimension types, and perhaps other things in the future.	2025-05-17 07:53:24 +01:00
Sam Atkins	398d2f9981	LibWeb/CSS: Implement pending-substitution value ... This is a special value temporarily assigned to longhands when their shorthand is unresolved, and then later replaced once that is resolved.	2025-05-14 11:46:47 +01:00
Sam Atkins	d1dadd43a1	LibWeb/CSS: Implement guaranteed-invalid value ... This is a special value produced when var/attr substitution fails, and is also the initial value for custom properties.	2025-05-14 11:46:47 +01:00
Timothy Flynn	7280ed6312	Meta: Enforce newlines around namespaces ... This has come up several times during code review, so let's just enforce it using a new clang-format 20 option.	2025-05-14 02:01:59 -06:00
Sam Atkins	560317b3d0	LibWeb/CSS: Update spec comment in calc() simplification algorithm ... This was corrected in 8bcf3ada9e	2025-05-03 14:54:33 +01:00
Sam Atkins	9e2e796f2d	LibWeb/CSS: Use CSS::URL for font-fetching ... ParsedFontFace and FontLoader now both keep track of which CSSStyleSheet (if any) was the source of the font-face, so the URLs can be completed correctly.	2025-05-03 12:01:43 +01:00
Tim Ledbetter	c0f9b11070	LibWeb: Parse oblique font-style with an angle value	2025-05-03 12:05:22 +02:00
Tim Ledbetter	542c3cbe51	LibWeb: Implement the transition-behavior CSS property ... This specifies whether transitions should be started for transitions whose animation behavior is discrete.	2025-05-02 11:07:19 +01:00
Psychpsyo	82387e2127	LibWeb: Avoid changing button border color on disable/hover	2025-04-30 20:13:14 +01:00
Tim Ledbetter	27baaa13e9	LibWeb: Support parsing and serializing 3D translate values	2025-04-30 19:36:56 +02:00
Tim Ledbetter	d804f1311c	LibWeb: Don't serialize scale z value if it is 1	2025-04-30 19:36:56 +02:00
Sam Atkins	326933cd93	LibWeb/CSS: Use CSS::URL for <url> and <paint> types	2025-04-30 17:38:38 +01:00
Tim Ledbetter	e7ae9c8ebf	LibWeb: Parse all as keyword in transition shorthand ... This ensures that the parsing of the `transition` shorthand property behaves in the same way as the `transition-property` longhand.4	2025-04-28 20:51:36 +02:00
Andreas Kling	d8ea16d94e	LibWeb: Don't assume calc() simplification worked on invalid tree ... Fixes #4469	2025-04-25 16:55:05 +02:00
Andreas Kling	cf704cfbfc	LibWeb: Implement interpolation for CSS scale values ... And let's handle the 3rd (Z) scale parameter as well, while we're here. At least 242 new passes on WPT.	2025-04-25 14:08:12 +02:00
Andreas Kling	1772adb600	LibWeb: Don't crash on non-finite values in CSS clamp() function ... Stops a WPT test from crashing, giving us 29 new subtest passes. :^)	2025-04-24 18:26:54 +02:00
Tim Ledbetter	0beb22f19e	LibWeb: Implement interpolation of edge values	2025-04-23 09:13:45 +01:00
Tim Ledbetter	6f5b107fcc	LibWeb: Resolve absolute calc() values in color functions ... Currently, `calc()` values with relative units are not handled correctly and will output an error to the console.	2025-04-22 12:20:26 +02:00
Tim Ledbetter	9cf04f40f6	LibWeb: Implement the color-mix() function ... This takes 2 color values and returns the result of mixing them by a given amount.	2025-04-22 12:19:51 +02:00
Tim Ledbetter	e860dd4f65	LibWeb: Implement serialization of lch-like color values	2025-04-20 16:51:20 +02:00
Tim Ledbetter	5074d90888	LibWeb: Implement serialization of lab-like color values	2025-04-20 16:51:20 +02:00
Andreas Kling	57809b1100	LibWeb: Skip dynamic_cast in CSSRGB after we already did a type check	2025-04-18 14:45:56 +02:00
Andrew Kaster	d1f6f5649e	LibWeb: Make storage of CSS::CalculationNodes const-correct ... Now we consistently use `RefPtr<CalculationNode const>` for all CalculationNodes.	2025-04-16 10:41:44 -06:00
Andrew Kaster	6d11414957	LibWeb: Make storage of CSS::StyleValues const-correct ... Now we consistently use `RefPtr<StyleValue const>` for all StyleValues.	2025-04-16 10:41:44 -06:00
Sam Atkins	c224644bed	LibWeb/CSS: Fetch ImageStyleValue images closer to spec ... We now don't absolutize the URL during parsing, keeping it as a CSS::URL object which we then pass to the "fetch an external image for a stylesheet" algorithm. Our version of this algorithm is a bit ad-hoc, in order to make use of SharedResourceRequest. To try and reduce duplication, I've pulled all of fetch_a_style_resource() into a static function, apart from the "actually do the fetch" step.	2025-04-15 09:54:35 +01:00
Sam Atkins	9f00425dad	LibWeb/CSS: Let CSSStyleValue know its CSSStyleSheet ... The CSS `fetch_foo()` functions resolve the URL relative to the CSSStyleSheet if one is provided. So, style values that do so need to know what CSSStyleSheet they are part of so that, for example, `url (foo.png)` is loaded relative to the style sheet's URL instead of the document's one. That all works without this change because we currently absolutize URLs during parsing, but we're in the process of stopping that. This commit adds the infrastructure for telling style values what their CSSStyleSheet is.	2025-04-15 09:54:35 +01:00
Sam Atkins	f1af4bcc58	LibWeb: Include SharedResourceRequest.h where it's used ... ImageStyleValue.h can rely on the forward-declaration.	2025-04-15 09:54:35 +01:00
Aliaksandr Kalenik	6507d23e29	LibWeb: Save ScrollState snapshot in DisplayList to avoid race condition ... With this change we save a copy of of scroll state at the time of recording a display list, instead of actual ScrollState pointer that could be modifed by the main thread while display list is beings rasterized on the rendering thread, which leads to a frame painted with inconsistent scroll state. Fixes https://github.com/LadybirdBrowser/ladybird/issues/4288	2025-04-12 02:55:18 +02:00
Sam Atkins	c82f4b46a2	LibWeb/CSS: Qualify uses of LibURL ... To prepare for introducing a CSS::URL type, we need to qualify any use of LibURL as `::URL::foo` instead of `URL::foo` so the compiler doesn't get confused. Many of these uses will be replaced, but I don't want to mix this in with what will likely already be a large change.	2025-04-09 18:45:57 +01:00
Tim Ledbetter	55769be9c6	LibWeb: Don't resolve color components when serializing color functions ... Previously, we were incorrectly replacing color components with `None` values with 0.	2025-04-09 12:11:33 +01:00