mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2025-04-26 14:28:49 +00:00
001949d77a
The handling of filesystem level errors was basically non-existing or consisting of `VERIFY_NOT_REACHED` assertions. Addressed this by * Adding `open` methods to `Heap` and `Database` which return errors. * Changing the interface of methods of these classes and clients downstream to propagate these errors. The constructors of `Heap` and `Database` don't open the underlying filesystem file anymore. The SQL statement handlers return an `SQLErrorCode::InternalError` error code if an error comes back from the lower levels. Note that some of these errors are things like duplicate index entry errors that should be caught before the SQL layer attempts to actually update the database. Added tests to catch attempts to open weird or non-existent files as databases. Finally, in between me writing this patch and submitting the PR the AK::Result<Foo, Bar> template got deprecated in favour of ErrorOr<Foo>. This resulted in more busywork.
101 lines
4.2 KiB
C++
101 lines
4.2 KiB
C++
/*
|
|
* Copyright (c) 2021, Jan de Visser <jan@de-visser.net>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#include <LibSQL/AST/AST.h>
|
|
#include <LibSQL/Database.h>
|
|
#include <LibSQL/Meta.h>
|
|
#include <LibSQL/Row.h>
|
|
|
|
namespace SQL::AST {
|
|
|
|
RefPtr<SQLResult> Select::execute(ExecutionContext& context) const
|
|
{
|
|
NonnullRefPtrVector<ResultColumn> columns;
|
|
for (auto& table_descriptor : table_or_subquery_list()) {
|
|
if (!table_descriptor.is_table())
|
|
return SQLResult::construct(SQLCommand::Select, SQLErrorCode::NotYetImplemented, "Sub-selects are not yet implemented");
|
|
auto table_def_or_error = context.database->get_table(table_descriptor.schema_name(), table_descriptor.table_name());
|
|
if (table_def_or_error.is_error())
|
|
return SQLResult::construct(SQLCommand::Select, SQLErrorCode::InternalError, table_def_or_error.error());
|
|
auto table = table_def_or_error.value();
|
|
if (!table) {
|
|
return SQLResult::construct(SQLCommand::Select, SQLErrorCode::TableDoesNotExist, table_descriptor.table_name());
|
|
}
|
|
|
|
if (result_column_list().size() == 1 && result_column_list()[0].type() == ResultType::All) {
|
|
for (auto& col : table->columns()) {
|
|
columns.append(
|
|
create_ast_node<ResultColumn>(
|
|
create_ast_node<ColumnNameExpression>(table->parent()->name(), table->name(), col.name()),
|
|
""));
|
|
}
|
|
}
|
|
}
|
|
|
|
VERIFY(!result_column_list().is_empty());
|
|
if (result_column_list().size() != 1 || result_column_list()[0].type() != ResultType::All) {
|
|
for (auto& col : result_column_list()) {
|
|
if (col.type() == ResultType::All)
|
|
// FIXME can have '*' for example in conjunction with computed columns
|
|
return SQLResult::construct(SQL::SQLCommand::Select, SQLErrorCode::SyntaxError, "*");
|
|
columns.append(col);
|
|
}
|
|
}
|
|
|
|
context.result = SQLResult::construct();
|
|
AK::NonnullRefPtr<TupleDescriptor> descriptor = AK::adopt_ref(*new TupleDescriptor);
|
|
Tuple tuple(descriptor);
|
|
Vector<Tuple> rows;
|
|
descriptor->empend("__unity__");
|
|
tuple.append(Value(SQLType::Boolean, true));
|
|
rows.append(tuple);
|
|
|
|
for (auto& table_descriptor : table_or_subquery_list()) {
|
|
if (!table_descriptor.is_table())
|
|
return SQLResult::construct(SQLCommand::Select, SQLErrorCode::NotYetImplemented, "Sub-selects are not yet implemented");
|
|
auto table_def_or_error = context.database->get_table(table_descriptor.schema_name(), table_descriptor.table_name());
|
|
if (table_def_or_error.is_error())
|
|
return SQLResult::construct(SQLCommand::Select, SQLErrorCode::InternalError, table_def_or_error.error());
|
|
auto table = table_def_or_error.value();
|
|
if (table->num_columns() == 0)
|
|
continue;
|
|
auto old_descriptor_size = descriptor->size();
|
|
descriptor->extend(table->to_tuple_descriptor());
|
|
for (auto cartesian_row = rows.first(); cartesian_row.size() == old_descriptor_size; cartesian_row = rows.first()) {
|
|
rows.remove(0);
|
|
auto table_rows_or_error = context.database->select_all(*table);
|
|
if (table_rows_or_error.is_error())
|
|
return SQLResult::construct(SQLCommand::Create, SQLErrorCode::InternalError, table_rows_or_error.error());
|
|
for (auto& table_row : table_rows_or_error.value()) {
|
|
auto new_row = cartesian_row;
|
|
new_row.extend(table_row);
|
|
rows.append(new_row);
|
|
}
|
|
}
|
|
}
|
|
|
|
for (auto& row : rows) {
|
|
context.current_row = &row;
|
|
if (where_clause()) {
|
|
auto where_result = where_clause()->evaluate(context);
|
|
if (context.result->has_error())
|
|
return context.result;
|
|
if (!where_result)
|
|
continue;
|
|
}
|
|
tuple.clear();
|
|
for (auto& col : columns) {
|
|
auto value = col.expression()->evaluate(context);
|
|
if (context.result->has_error())
|
|
return context.result;
|
|
tuple.append(value);
|
|
}
|
|
context.result->append(tuple);
|
|
}
|
|
return context.result;
|
|
}
|
|
|
|
}
|