mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2025-04-27 06:48:49 +00:00
0b7e19e2bb
Since the `redo` action never goes back to `index: 0`, we have to mark the clean index as being the current non-empty index for the undo/redo navigation to work properly. The problem is that if we never `undo`, the stack index stays at zero, which is the empty container waiting for commands. In that situation, if we save the document, it registers the clean index as being 1 (the non-empty index) but because the stack index has never left zero, the document was being reported as modified, being out of sync with the window modified state.
118 lines
2.5 KiB
C++
118 lines
2.5 KiB
C++
/*
|
|
* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#include <LibGUI/Command.h>
|
|
#include <LibGUI/UndoStack.h>
|
|
|
|
namespace GUI {
|
|
|
|
UndoStack::UndoStack()
|
|
{
|
|
}
|
|
|
|
UndoStack::~UndoStack()
|
|
{
|
|
}
|
|
|
|
void UndoStack::undo()
|
|
{
|
|
if (!can_undo())
|
|
return;
|
|
|
|
auto pop_container_and_undo = [this]() {
|
|
for (;;) {
|
|
if (m_stack_index >= m_stack.size())
|
|
break;
|
|
|
|
auto& combo = m_stack[m_stack_index++];
|
|
if (combo.commands.size() == 0)
|
|
continue;
|
|
for (auto& command : combo.commands)
|
|
command.undo();
|
|
break;
|
|
}
|
|
};
|
|
|
|
// If this is the first undo, finish off our current combo
|
|
if (m_stack_index == 0)
|
|
finalize_current_combo();
|
|
pop_container_and_undo();
|
|
}
|
|
|
|
void UndoStack::redo()
|
|
{
|
|
if (!can_redo())
|
|
return;
|
|
|
|
m_stack_index -= 1;
|
|
auto& commands = m_stack[m_stack_index].commands;
|
|
for (int i = commands.size() - 1; i >= 0; i--)
|
|
commands[i].redo();
|
|
}
|
|
|
|
void UndoStack::push(NonnullOwnPtr<Command>&& command)
|
|
{
|
|
if (m_stack.is_empty())
|
|
finalize_current_combo();
|
|
|
|
if (m_stack_index > 0) {
|
|
for (size_t i = 0; i < m_stack_index; i++)
|
|
m_stack.remove(0);
|
|
|
|
if (m_clean_index.has_value()) {
|
|
if (m_clean_index.value() < m_stack_index)
|
|
m_clean_index.clear();
|
|
else
|
|
m_clean_index = m_clean_index.value() - m_stack_index;
|
|
}
|
|
|
|
m_stack_index = 0;
|
|
finalize_current_combo();
|
|
}
|
|
|
|
m_stack.first().commands.prepend(move(command));
|
|
}
|
|
|
|
void UndoStack::finalize_current_combo()
|
|
{
|
|
if (m_stack_index > 0)
|
|
return;
|
|
if (m_stack.size() != 0 && m_stack.first().commands.size() == 0)
|
|
return;
|
|
|
|
auto undo_commands_container = make<Combo>();
|
|
m_stack.prepend(move(undo_commands_container));
|
|
|
|
if (m_clean_index.has_value())
|
|
m_clean_index = m_clean_index.value() + 1;
|
|
}
|
|
|
|
void UndoStack::set_current_unmodified()
|
|
{
|
|
m_clean_index = non_empty_stack_index();
|
|
}
|
|
|
|
bool UndoStack::is_current_modified() const
|
|
{
|
|
return !m_clean_index.has_value() || non_empty_stack_index() != m_clean_index.value();
|
|
}
|
|
|
|
void UndoStack::clear()
|
|
{
|
|
m_stack.clear();
|
|
m_stack_index = 0;
|
|
m_clean_index.clear();
|
|
}
|
|
|
|
size_t UndoStack::non_empty_stack_index() const
|
|
{
|
|
if (can_undo() && m_stack[m_stack_index].commands.is_empty())
|
|
return m_stack_index + 1;
|
|
else
|
|
return m_stack_index;
|
|
}
|
|
|
|
}
|