ladybird/Libraries/LibWeb/Layout/LineBoxFragment.cpp
Andreas Kling 0d2800e411
Some checks are pending
CI / macOS, arm64, Sanitizer, Clang (push) Waiting to run
CI / Linux, x86_64, Fuzzers, Clang (push) Waiting to run
CI / Linux, x86_64, Sanitizer, GNU (push) Waiting to run
Package the js repl as a binary artifact / macOS, arm64 (push) Waiting to run
Lint Code / lint (push) Waiting to run
Label PRs with merge conflicts / auto-labeler (push) Waiting to run
CI / Linux, x86_64, Sanitizer, Clang (push) Waiting to run
Package the js repl as a binary artifact / Linux, arm64 (push) Waiting to run
Package the js repl as a binary artifact / Linux, x86_64 (push) Waiting to run
Run test262 and test-wasm / run_and_update_results (push) Waiting to run
Push notes / build (push) Waiting to run
LibWeb: Don't relocate fragments across atomic inline boundary
All fragments inside an atomic inline box should stay within that box,
otherwise we'll screw up the paint order and paint them behind things
that they're supposed to be on top of.

This fixes an issue with inline-block content not appearing on sites
like Google Docs and Reddit, among others.
2025-08-24 21:00:08 +02:00

179 lines
5.6 KiB
C++

/*
* Copyright (c) 2018-2023, Andreas Kling <andreas@ladybird.org>
* Copyright (c) 2025, Jelle Raaijmakers <jelle@ladybird.org>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
#include <AK/Utf8View.h>
#include <LibWeb/Layout/LayoutState.h>
#include <LibWeb/Layout/TextNode.h>
#include <ctype.h>
namespace Web::Layout {
LineBoxFragment::LineBoxFragment(Node const& layout_node, size_t start, size_t length, CSSPixels inline_offset, CSSPixels block_offset, CSSPixels inline_length, CSSPixels block_length, CSSPixels border_box_top, CSS::Direction direction, CSS::WritingMode writing_mode, RefPtr<Gfx::GlyphRun> glyph_run)
: m_layout_node(layout_node)
, m_start(start)
, m_length(length)
, m_inline_offset(inline_offset)
, m_block_offset(block_offset)
, m_inline_length(inline_length)
, m_block_length(block_length)
, m_border_box_top(border_box_top)
, m_direction(direction)
, m_writing_mode(writing_mode)
, m_glyph_run(move(glyph_run))
{
if (m_glyph_run) {
m_current_insert_direction = resolve_glyph_run_direction(m_glyph_run->text_type());
if (m_direction == CSS::Direction::Rtl)
m_insert_position = m_inline_length.to_float();
}
}
CSSPixelPoint LineBoxFragment::offset() const
{
if (m_writing_mode != CSS::WritingMode::HorizontalTb)
return { m_block_offset, m_inline_offset };
return { m_inline_offset, m_block_offset };
}
CSSPixelSize LineBoxFragment::size() const
{
if (m_writing_mode != CSS::WritingMode::HorizontalTb)
return { m_block_length, m_inline_length };
return { m_inline_length, m_block_length };
}
bool LineBoxFragment::ends_in_whitespace() const
{
auto text = this->text();
if (text.is_empty())
return false;
return is_ascii_space(text.code_unit_at(text.length_in_code_units() - 1));
}
bool LineBoxFragment::is_justifiable_whitespace() const
{
return text() == " "sv;
}
Utf16View LineBoxFragment::text() const
{
if (!is<TextNode>(layout_node()))
return {};
return as<TextNode>(layout_node()).text_for_rendering().substring_view(m_start, m_length);
}
bool LineBoxFragment::is_atomic_inline() const
{
return layout_node().is_atomic_inline();
}
CSS::Direction LineBoxFragment::resolve_glyph_run_direction(Gfx::GlyphRun::TextType text_type) const
{
switch (text_type) {
case Gfx::GlyphRun::TextType::Common:
case Gfx::GlyphRun::TextType::ContextDependent:
case Gfx::GlyphRun::TextType::EndPadding:
return m_direction;
case Gfx::GlyphRun::TextType::Ltr:
return CSS::Direction::Ltr;
case Gfx::GlyphRun::TextType::Rtl:
return CSS::Direction::Rtl;
default:
VERIFY_NOT_REACHED();
}
}
void LineBoxFragment::append_glyph_run(RefPtr<Gfx::GlyphRun> const& glyph_run, CSSPixels run_width)
{
switch (m_direction) {
case CSS::Direction::Ltr:
append_glyph_run_ltr(glyph_run, run_width);
break;
case CSS::Direction::Rtl:
append_glyph_run_rtl(glyph_run, run_width);
break;
}
}
void LineBoxFragment::append_glyph_run_ltr(RefPtr<Gfx::GlyphRun> const& glyph_run, CSSPixels run_width)
{
auto run_direction = resolve_glyph_run_direction(glyph_run->text_type());
auto inline_offset = m_inline_length.to_float();
if (m_current_insert_direction != run_direction) {
if (run_direction == CSS::Direction::Rtl)
m_insert_position = inline_offset;
m_current_insert_direction = run_direction;
}
auto& glyphs = m_glyph_run->glyphs();
glyphs.ensure_capacity(glyphs.size() + glyph_run->glyphs().size());
switch (run_direction) {
case CSS::Direction::Ltr:
for (auto& glyph : glyph_run->glyphs()) {
glyph.position.translate_by(inline_offset, 0);
glyphs.unchecked_append(glyph);
}
break;
case CSS::Direction::Rtl:
for (auto& glyph : m_glyph_run->glyphs()) {
if (glyph.position.x() >= m_insert_position)
glyph.position.translate_by(run_width.to_float(), 0);
}
for (auto& glyph : glyph_run->glyphs()) {
glyph.position.translate_by(m_insert_position, 0);
glyphs.unchecked_append(glyph);
}
break;
}
m_inline_length += run_width;
}
void LineBoxFragment::append_glyph_run_rtl(RefPtr<Gfx::GlyphRun> const& glyph_run, CSSPixels run_width)
{
auto run_direction = resolve_glyph_run_direction(glyph_run->text_type());
auto run_offset = run_width.to_float();
if (m_current_insert_direction != run_direction) {
if (run_direction == CSS::Direction::Ltr)
m_insert_position = 0;
m_current_insert_direction = run_direction;
}
auto& glyphs = m_glyph_run->glyphs();
glyphs.ensure_capacity(glyphs.size() + glyph_run->glyphs().size());
switch (run_direction) {
case CSS::Direction::Ltr:
for (auto& glyph : m_glyph_run->glyphs()) {
if (glyph.position.x() >= m_insert_position)
glyph.position.translate_by(run_offset, 0);
}
for (auto& glyph : glyph_run->glyphs()) {
glyph.position.translate_by(m_insert_position, 0);
glyphs.unchecked_append(glyph);
}
break;
case CSS::Direction::Rtl:
if (glyph_run->text_type() != Gfx::GlyphRun::TextType::EndPadding) {
for (auto& glyph : m_glyph_run->glyphs()) {
glyph.position.translate_by(run_offset, 0);
}
}
for (auto& glyph : glyph_run->glyphs()) {
glyphs.unchecked_append(glyph);
}
break;
}
m_inline_length += run_width;
m_insert_position += run_width.to_float();
}
}