mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2025-05-08 04:02:52 +00:00
1524288127
Currently, the Value class is essentially a "pImpl" wrapper around the ValueImpl hierarchy of classes. This is a bit difficult to follow and reason about, as methods jump between the Value class and its impl classes. This changes the Variant held by Value to instead store the specified types (String, int, etc.) directly. In doing so, the ValueImpl classes are removed, and all methods are now just concise Variant visitors. As part of this rewrite, support for the "array" type is dropped (or rather, just not re-implemented) as it was unused. If it's needed in the future, support can be re-added. This does retain the ability for non-NULL types to store NULL values (i.e. an empty Optional). I tried dropping this support as well, but it is depended upon by the on-disk storage classes in non-trivial ways. |
||
|---|---|---|
| .. | ||
| AST.h | ||
| CreateSchema.cpp | ||
| CreateTable.cpp | ||
| Describe.cpp | ||
| Expression.cpp | ||
| Insert.cpp | ||
| Lexer.cpp | ||
| Lexer.h | ||
| Parser.cpp | ||
| Parser.h | ||
| Select.cpp | ||
| Statement.cpp | ||
| SyntaxHighlighter.cpp | ||
| SyntaxHighlighter.h | ||
| Token.cpp | ||
| Token.h | ||