mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2025-05-12 22:22:55 +00:00
216f68c566
This was an oversight from when I converted PendingResponse and various other classes from being ref-counted to GC-allocated last minute - no one takes care to keep all of them alive. Some are on the stack, and some might be captured in another PendingResponse's JS::SafeFunction, but ultimately, we need a better solution. Since a PendingResponse is *always* the result of someone having created a Request, let's just let that keep a list of each PendingResponse that has been created for it, and visit them until they are resolved. After that, they can be GC'd with no complaints.
65 lines
1.9 KiB
C++
65 lines
1.9 KiB
C++
/*
|
|
* Copyright (c) 2022, Linus Groh <linusg@serenityos.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#include <LibJS/Heap/Heap.h>
|
|
#include <LibJS/Runtime/VM.h>
|
|
#include <LibWeb/Fetch/Fetching/PendingResponse.h>
|
|
#include <LibWeb/Fetch/Infrastructure/HTTP/Requests.h>
|
|
#include <LibWeb/Platform/EventLoopPlugin.h>
|
|
|
|
namespace Web::Fetch::Fetching {
|
|
|
|
JS::NonnullGCPtr<PendingResponse> PendingResponse::create(JS::VM& vm, JS::NonnullGCPtr<Infrastructure::Request> request)
|
|
{
|
|
return { *vm.heap().allocate_without_realm<PendingResponse>(request) };
|
|
}
|
|
|
|
JS::NonnullGCPtr<PendingResponse> PendingResponse::create(JS::VM& vm, JS::NonnullGCPtr<Infrastructure::Request> request, JS::NonnullGCPtr<Infrastructure::Response> response)
|
|
{
|
|
return { *vm.heap().allocate_without_realm<PendingResponse>(request, response) };
|
|
}
|
|
|
|
PendingResponse::PendingResponse(JS::NonnullGCPtr<Infrastructure::Request> request, JS::GCPtr<Infrastructure::Response> response)
|
|
: m_request(request)
|
|
, m_response(response)
|
|
{
|
|
m_request->add_pending_response({}, *this);
|
|
}
|
|
|
|
void PendingResponse::visit_edges(JS::Cell::Visitor& visitor)
|
|
{
|
|
Base::visit_edges(visitor);
|
|
visitor.visit(m_request);
|
|
visitor.visit(m_response);
|
|
}
|
|
|
|
void PendingResponse::when_loaded(Callback callback)
|
|
{
|
|
VERIFY(!m_callback);
|
|
m_callback = move(callback);
|
|
if (m_response)
|
|
run_callback();
|
|
}
|
|
|
|
void PendingResponse::resolve(JS::NonnullGCPtr<Infrastructure::Response> response)
|
|
{
|
|
VERIFY(!m_response);
|
|
m_response = response;
|
|
if (m_callback)
|
|
run_callback();
|
|
}
|
|
|
|
void PendingResponse::run_callback() const
|
|
{
|
|
VERIFY(m_callback);
|
|
VERIFY(m_response);
|
|
Platform::EventLoopPlugin::the().deferred_invoke([strong_this = JS::make_handle(const_cast<PendingResponse&>(*this))]() mutable {
|
|
strong_this->m_callback(*strong_this->m_response);
|
|
strong_this->m_request->remove_pending_response({}, *strong_this.ptr());
|
|
});
|
|
}
|
|
|
|
}
|