mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2025-10-17 21:49:42 +00:00
aa563706ca
Some checks are pending
CI / macOS, arm64, Sanitizer, Clang (push) Waiting to run
CI / Linux, x86_64, Fuzzers, Clang (push) Waiting to run
CI / Linux, x86_64, Sanitizer, GNU (push) Waiting to run
CI / Linux, x86_64, Sanitizer, Clang (push) Waiting to run
Package the js repl as a binary artifact / Linux, arm64 (push) Waiting to run
Package the js repl as a binary artifact / macOS, arm64 (push) Waiting to run
Package the js repl as a binary artifact / Linux, x86_64 (push) Waiting to run
Run test262 and test-wasm / run_and_update_results (push) Waiting to run
Lint Code / lint (push) Waiting to run
Label PRs with merge conflicts / auto-labeler (push) Waiting to run
Push notes / build (push) Waiting to run
Our previous implementation kept track of an AnimationTimeline being monotonically increasing, by looking at new time values coming in and setting `m_monotonically_increasing` to `false` whenever a new value is before the previous known time value. As far as I can tell, the spec doesn't really ask us to do so: it just defines 'monotonically increasing' as a property of a timeline, i.e. it guarantees that returned time values from `::current_time()` are always greater than or equal to the last returned value. This fixes a common crash seen when the last render opportunity lies before the document's origin time, and `::set_current_time()` was invoked with a negative value. This was especially visible in the `Text/input/wpt-import/css/cssom/CSSStyleSheet-constructable.html` test.
83 lines
2.5 KiB
C++
83 lines
2.5 KiB
C++
/*
|
|
* Copyright (c) 2023-2024, Matthew Olsson <mattco@serenityos.org>.
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#include <LibWeb/Animations/Animation.h>
|
|
#include <LibWeb/Animations/AnimationTimeline.h>
|
|
#include <LibWeb/Bindings/AnimationTimelinePrototype.h>
|
|
#include <LibWeb/DOM/Document.h>
|
|
|
|
namespace Web::Animations {
|
|
|
|
GC_DEFINE_ALLOCATOR(AnimationTimeline);
|
|
|
|
// https://drafts.csswg.org/web-animations-1/#dom-animationtimeline-currenttime
|
|
Optional<double> AnimationTimeline::current_time() const
|
|
{
|
|
// Returns the current time for this timeline or null if this timeline is inactive.
|
|
if (is_inactive())
|
|
return {};
|
|
return m_current_time;
|
|
}
|
|
|
|
void AnimationTimeline::set_current_time(Optional<double> value)
|
|
{
|
|
if (value == m_current_time)
|
|
return;
|
|
|
|
if (m_is_monotonically_increasing && m_current_time.has_value() && (!value.has_value() || *value < *m_current_time)) {
|
|
dbgln("AnimationTimeline::set_current_time({}): monotonically increasing timeline can only move forward", value);
|
|
return;
|
|
}
|
|
m_current_time = value;
|
|
|
|
// The loop might modify the content of m_associated_animations, so let's iterate over a copy.
|
|
auto temporary_copy = GC::RootVector<GC::Ref<Animation>>(vm().heap());
|
|
temporary_copy.extend(m_associated_animations.values());
|
|
for (auto& animation : temporary_copy)
|
|
animation->notify_timeline_time_did_change();
|
|
}
|
|
|
|
void AnimationTimeline::set_associated_document(GC::Ptr<DOM::Document> document)
|
|
{
|
|
if (document)
|
|
document->associate_with_timeline(*this);
|
|
if (m_associated_document)
|
|
m_associated_document->disassociate_with_timeline(*this);
|
|
m_associated_document = document;
|
|
}
|
|
|
|
// https://drafts.csswg.org/web-animations-1/#timeline
|
|
bool AnimationTimeline::is_inactive() const
|
|
{
|
|
// A timeline is considered to be inactive when its time value is unresolved, and active otherwise.
|
|
return !m_current_time.has_value();
|
|
}
|
|
|
|
AnimationTimeline::AnimationTimeline(JS::Realm& realm)
|
|
: Bindings::PlatformObject(realm)
|
|
{
|
|
}
|
|
|
|
void AnimationTimeline::finalize()
|
|
{
|
|
if (m_associated_document)
|
|
m_associated_document->disassociate_with_timeline(*this);
|
|
}
|
|
|
|
void AnimationTimeline::initialize(JS::Realm& realm)
|
|
{
|
|
WEB_SET_PROTOTYPE_FOR_INTERFACE(AnimationTimeline);
|
|
Base::initialize(realm);
|
|
}
|
|
|
|
void AnimationTimeline::visit_edges(Cell::Visitor& visitor)
|
|
{
|
|
Base::visit_edges(visitor);
|
|
visitor.visit(m_associated_document);
|
|
visitor.visit(m_associated_animations);
|
|
}
|
|
|
|
}
|