mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2025-07-09 18:41:53 +00:00
183c847c80
Some checks are pending
CI / Lagom (x86_64, Fuzzers_CI, false, ubuntu-24.04, Linux, Clang) (push) Waiting to run
CI / Lagom (arm64, Sanitizer_CI, false, macos-15, macOS, Clang) (push) Waiting to run
CI / Lagom (x86_64, Sanitizer_CI, false, ubuntu-24.04, Linux, GNU) (push) Waiting to run
CI / Lagom (x86_64, Sanitizer_CI, true, ubuntu-24.04, Linux, Clang) (push) Waiting to run
Package the js repl as a binary artifact / build-and-package (arm64, macos-15, macOS, macOS-universal2) (push) Waiting to run
Package the js repl as a binary artifact / build-and-package (x86_64, ubuntu-24.04, Linux, Linux-x86_64) (push) Waiting to run
Run test262 and test-wasm / run_and_update_results (push) Waiting to run
Lint Code / lint (push) Waiting to run
Label PRs with merge conflicts / auto-labeler (push) Waiting to run
Push notes / build (push) Waiting to run
This is *extremely* common on the web, but barely shows up at all in JavaScript benchmarks. A typical example is setting Element.innerHTML on a HTMLDivElement. HTMLDivElement doesn't have innerHTML, so it has to travel up the prototype chain until it finds it. Before this change, we didn't cache this at all, so we had to travel the prototype chain every time a setter like this was used. We now use the same mechanism we already had for GetBydId and cache PutById setter accesses in the prototype chain as well. 1.74x speedup on MicroBench/setter-in-prototype-chain.js
77 lines
2.7 KiB
C++
77 lines
2.7 KiB
C++
/*
|
|
* Copyright (c) 2024, Aliaksandr Kalenik <kalenik.aliaksandr@gmail.com>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#include <LibWeb/Bindings/ExceptionOrUtils.h>
|
|
#include <LibWeb/WebIDL/ObservableArray.h>
|
|
|
|
namespace Web::WebIDL {
|
|
|
|
GC_DEFINE_ALLOCATOR(ObservableArray);
|
|
|
|
GC::Ref<ObservableArray> ObservableArray::create(JS::Realm& realm)
|
|
{
|
|
auto prototype = realm.intrinsics().array_prototype();
|
|
return realm.create<ObservableArray>(prototype);
|
|
}
|
|
|
|
ObservableArray::ObservableArray(Object& prototype)
|
|
: JS::Array(prototype)
|
|
{
|
|
}
|
|
|
|
void ObservableArray::visit_edges(JS::Cell::Visitor& visitor)
|
|
{
|
|
Base::visit_edges(visitor);
|
|
visitor.visit(m_on_set_an_indexed_value);
|
|
visitor.visit(m_on_delete_an_indexed_value);
|
|
}
|
|
|
|
void ObservableArray::set_on_set_an_indexed_value_callback(SetAnIndexedValueCallbackFunction&& callback)
|
|
{
|
|
m_on_set_an_indexed_value = GC::create_function(heap(), move(callback));
|
|
}
|
|
|
|
void ObservableArray::set_on_delete_an_indexed_value_callback(DeleteAnIndexedValueCallbackFunction&& callback)
|
|
{
|
|
m_on_delete_an_indexed_value = GC::create_function(heap(), move(callback));
|
|
}
|
|
|
|
JS::ThrowCompletionOr<bool> ObservableArray::internal_set(JS::PropertyKey const& property_key, JS::Value value, JS::Value receiver, JS::CacheablePropertyMetadata* metadata, PropertyLookupPhase phase)
|
|
{
|
|
if (property_key.is_number() && m_on_set_an_indexed_value)
|
|
TRY(Bindings::throw_dom_exception_if_needed(vm(), [&] { return m_on_set_an_indexed_value->function()(value); }));
|
|
return TRY(Base::internal_set(property_key, value, receiver, metadata, phase));
|
|
}
|
|
|
|
JS::ThrowCompletionOr<bool> ObservableArray::internal_delete(JS::PropertyKey const& property_key)
|
|
{
|
|
if (property_key.is_number() && m_on_delete_an_indexed_value) {
|
|
auto maybe_value_and_attributes = indexed_properties().get(property_key.as_number());
|
|
JS::Value deleted_value;
|
|
if (maybe_value_and_attributes.has_value())
|
|
deleted_value = maybe_value_and_attributes->value;
|
|
TRY(Bindings::throw_dom_exception_if_needed(vm(), [&] { return m_on_delete_an_indexed_value->function()(deleted_value); }));
|
|
}
|
|
return JS::Array::internal_delete(property_key);
|
|
}
|
|
|
|
JS::ThrowCompletionOr<void> ObservableArray::append(JS::Value value)
|
|
{
|
|
if (m_on_set_an_indexed_value)
|
|
TRY(Bindings::throw_dom_exception_if_needed(vm(), [&] { return m_on_set_an_indexed_value->function()(value); }));
|
|
indexed_properties().append(value);
|
|
return {};
|
|
}
|
|
|
|
void ObservableArray::clear()
|
|
{
|
|
while (!indexed_properties().is_empty()) {
|
|
auto deleted_value = indexed_properties().storage()->take_first().value;
|
|
MUST(m_on_delete_an_indexed_value->function()(deleted_value));
|
|
}
|
|
}
|
|
|
|
}
|