mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2025-04-25 14:05:15 +00:00
34591ff3d9
As it turns out, making everyone piggyback on HTML::ImageRequest had some major flaws, as HTMLImageElement may decide to abort an ongoing fetch or wipe out image data, even when someone else is using the same image request. To avoid this issue, this patch introduces SharedImageRequest, and then implements ImageRequest on top of that. Other clients of the ImageRequest API are moved to SharedImageRequest as well, and ImageRequest is now only used by HTMLImageElement. This fixes an issue with image data disappearing and leading to asserts and/or visually absent images.
90 lines
3.2 KiB
C++
90 lines
3.2 KiB
C++
/*
|
|
* Copyright (c) 2023, Andreas Kling <kling@serenityos.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <AK/Error.h>
|
|
#include <AK/OwnPtr.h>
|
|
#include <AK/URL.h>
|
|
#include <LibGfx/Size.h>
|
|
#include <LibJS/Heap/Handle.h>
|
|
#include <LibWeb/Forward.h>
|
|
#include <LibWeb/HTML/SharedImageRequest.h>
|
|
|
|
namespace Web::HTML {
|
|
|
|
// https://html.spec.whatwg.org/multipage/images.html#image-request
|
|
class ImageRequest : public RefCounted<ImageRequest> {
|
|
public:
|
|
static ErrorOr<NonnullRefPtr<ImageRequest>> create(Page&);
|
|
~ImageRequest();
|
|
|
|
// https://html.spec.whatwg.org/multipage/images.html#img-req-state
|
|
enum class State {
|
|
Unavailable,
|
|
PartiallyAvailable,
|
|
CompletelyAvailable,
|
|
Broken,
|
|
};
|
|
|
|
bool is_available() const;
|
|
bool is_fetching() const;
|
|
|
|
State state() const;
|
|
void set_state(State);
|
|
|
|
AK::URL const& current_url() const;
|
|
void set_current_url(AK::URL);
|
|
|
|
[[nodiscard]] RefPtr<DecodedImageData const> image_data() const;
|
|
void set_image_data(RefPtr<DecodedImageData const>);
|
|
|
|
[[nodiscard]] float current_pixel_density() const { return m_current_pixel_density; }
|
|
void set_current_pixel_density(float density) { m_current_pixel_density = density; }
|
|
|
|
[[nodiscard]] Optional<Gfx::FloatSize> const& preferred_density_corrected_dimensions() const { return m_preferred_density_corrected_dimensions; }
|
|
void set_preferred_density_corrected_dimensions(Optional<Gfx::FloatSize> dimensions) { m_preferred_density_corrected_dimensions = move(dimensions); }
|
|
|
|
// https://html.spec.whatwg.org/multipage/images.html#prepare-an-image-for-presentation
|
|
void prepare_for_presentation(HTMLImageElement&);
|
|
|
|
void fetch_image(JS::Realm&, JS::NonnullGCPtr<Fetch::Infrastructure::Request>);
|
|
void add_callbacks(JS::SafeFunction<void()> on_finish, JS::SafeFunction<void()> on_fail);
|
|
|
|
SharedImageRequest const* shared_image_request() const { return m_shared_image_request; }
|
|
|
|
private:
|
|
explicit ImageRequest(Page&);
|
|
|
|
Page& m_page;
|
|
|
|
// https://html.spec.whatwg.org/multipage/images.html#img-req-state
|
|
// An image request's state is initially unavailable.
|
|
State m_state { State::Unavailable };
|
|
|
|
// https://html.spec.whatwg.org/multipage/images.html#img-req-url
|
|
// An image request's current URL is initially the empty string.
|
|
AK::URL m_current_url;
|
|
|
|
// https://html.spec.whatwg.org/multipage/images.html#img-req-data
|
|
RefPtr<DecodedImageData const> m_image_data;
|
|
|
|
// https://html.spec.whatwg.org/multipage/images.html#current-pixel-density
|
|
// Each image request has a current pixel density, which must initially be 1.
|
|
float m_current_pixel_density { 1 };
|
|
|
|
// https://html.spec.whatwg.org/multipage/images.html#preferred-density-corrected-dimensions
|
|
// Each image request has preferred density-corrected dimensions,
|
|
// which is either a struct consisting of a width and a height or is null. It must initially be null.
|
|
Optional<Gfx::FloatSize> m_preferred_density_corrected_dimensions;
|
|
|
|
RefPtr<SharedImageRequest> m_shared_image_request;
|
|
};
|
|
|
|
// https://html.spec.whatwg.org/multipage/images.html#abort-the-image-request
|
|
void abort_the_image_request(JS::Realm&, ImageRequest*);
|
|
|
|
}
|