mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2025-04-29 15:58:47 +00:00
54b9a4ec1e
Previously we would crash the process immediately when a promise violation was found during a syscall. This is error prone, as we don't unwind the stack. This means that in certain cases we can leak resources, like an OwnPtr / RefPtr tracked on the stack. Or even leak a lock acquired in a ScopeLockLocker. To remedy this situation we move the promise violation handling to the syscall handler, right before we return to user space. This allows the code to follow the normal unwind path, and grantees there is no longer any cleanup that needs to occur. The Process::require_promise() and Process::require_no_promises() functions were modified to return ErrorOr<void> so we enforce that the errors are always propagated by the caller.
54 lines
1.5 KiB
C++
54 lines
1.5 KiB
C++
/*
|
|
* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#include <Kernel/Debug.h>
|
|
#include <Kernel/FileSystem/OpenFileDescription.h>
|
|
#include <Kernel/Process.h>
|
|
|
|
namespace Kernel {
|
|
|
|
ErrorOr<FlatPtr> Process::sys$fcntl(int fd, int cmd, u32 arg)
|
|
{
|
|
VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this);
|
|
TRY(require_promise(Pledge::stdio));
|
|
dbgln_if(IO_DEBUG, "sys$fcntl: fd={}, cmd={}, arg={}", fd, cmd, arg);
|
|
auto description = TRY(fds().open_file_description(fd));
|
|
// NOTE: The FD flags are not shared between OpenFileDescription objects.
|
|
// This means that dup() doesn't copy the FD_CLOEXEC flag!
|
|
switch (cmd) {
|
|
case F_DUPFD: {
|
|
int arg_fd = (int)arg;
|
|
if (arg_fd < 0)
|
|
return EINVAL;
|
|
auto fd_allocation = TRY(m_fds.allocate(arg_fd));
|
|
m_fds[fd_allocation.fd].set(*description);
|
|
return fd_allocation.fd;
|
|
}
|
|
case F_GETFD:
|
|
return m_fds[fd].flags();
|
|
case F_SETFD:
|
|
m_fds[fd].set_flags(arg);
|
|
break;
|
|
case F_GETFL:
|
|
return description->file_flags();
|
|
case F_SETFL:
|
|
description->set_file_flags(arg);
|
|
break;
|
|
case F_ISTTY:
|
|
return description->is_tty();
|
|
case F_GETLK:
|
|
TRY(description->get_flock(Userspace<flock*>(arg)));
|
|
return 0;
|
|
case F_SETLK:
|
|
TRY(description->apply_flock(Process::current(), Userspace<const flock*>(arg)));
|
|
return 0;
|
|
default:
|
|
return EINVAL;
|
|
}
|
|
return 0;
|
|
}
|
|
|
|
}
|