mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2025-05-01 00:38:48 +00:00
54b9a4ec1e
Previously we would crash the process immediately when a promise violation was found during a syscall. This is error prone, as we don't unwind the stack. This means that in certain cases we can leak resources, like an OwnPtr / RefPtr tracked on the stack. Or even leak a lock acquired in a ScopeLockLocker. To remedy this situation we move the promise violation handling to the syscall handler, right before we return to user space. This allows the code to follow the normal unwind path, and grantees there is no longer any cleanup that needs to occur. The Process::require_promise() and Process::require_no_promises() functions were modified to return ErrorOr<void> so we enforce that the errors are always propagated by the caller.
46 lines
1.4 KiB
C++
46 lines
1.4 KiB
C++
/*
|
|
* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#include <Kernel/FileSystem/FIFO.h>
|
|
#include <Kernel/Process.h>
|
|
|
|
namespace Kernel {
|
|
|
|
ErrorOr<FlatPtr> Process::sys$pipe(int pipefd[2], int flags)
|
|
{
|
|
VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this)
|
|
TRY(require_promise(Pledge::stdio));
|
|
if (fds().open_count() + 2 > OpenFileDescriptions::max_open())
|
|
return EMFILE;
|
|
// Reject flags other than O_CLOEXEC, O_NONBLOCK
|
|
if ((flags & (O_CLOEXEC | O_NONBLOCK)) != flags)
|
|
return EINVAL;
|
|
|
|
u32 fd_flags = (flags & O_CLOEXEC) ? FD_CLOEXEC : 0;
|
|
auto fifo = TRY(FIFO::try_create(uid()));
|
|
|
|
auto reader_fd_allocation = TRY(m_fds.allocate());
|
|
auto writer_fd_allocation = TRY(m_fds.allocate());
|
|
|
|
auto reader_description = TRY(fifo->open_direction(FIFO::Direction::Reader));
|
|
auto writer_description = TRY(fifo->open_direction(FIFO::Direction::Writer));
|
|
|
|
reader_description->set_readable(true);
|
|
writer_description->set_writable(true);
|
|
if (flags & O_NONBLOCK) {
|
|
reader_description->set_blocking(false);
|
|
writer_description->set_blocking(false);
|
|
}
|
|
|
|
m_fds[reader_fd_allocation.fd].set(move(reader_description), fd_flags);
|
|
m_fds[writer_fd_allocation.fd].set(move(writer_description), fd_flags);
|
|
|
|
TRY(copy_to_user(&pipefd[0], &reader_fd_allocation.fd));
|
|
TRY(copy_to_user(&pipefd[1], &writer_fd_allocation.fd));
|
|
return 0;
|
|
}
|
|
|
|
}
|