mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2025-04-25 14:05:15 +00:00
9b483625e6
Currently, the generated IPC decoders will default-construct the type to be decoded, then pass that value by reference to the concrete decoder. This, of course, requires that the type is default-constructible. This was an issue for decoding Variants, which had to require the first type in the Variant list is Empty, to ensure it is default constructible. Further, this made it possible for values to become uninitialized in user-defined decoders. This patch makes the decoder interface such that the concrete decoders themselves contruct the decoded type upon return from the decoder. To do so, the default decoders in IPC::Decoder had to be moved to the IPC namespace scope, as these decoders are now specializations instead of overloaded methods (C++ requires specializations to be in a namespace scope).
72 lines
2.1 KiB
C++
72 lines
2.1 KiB
C++
/*
|
|
* Copyright (c) 2022, Tim Flynn <trflynn89@serenityos.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#include <AK/HashMap.h>
|
|
#include <AK/Optional.h>
|
|
#include <AK/Variant.h>
|
|
#include <AK/Vector.h>
|
|
#include <LibCore/SharedCircularQueue.h>
|
|
|
|
#pragma once
|
|
|
|
// These concepts are used to help the compiler distinguish between specializations that would be
|
|
// ambiguous otherwise. For example, if the specializations for int and Vector<T> were declared as
|
|
// follows:
|
|
//
|
|
// template<> ErrorOr<int> decode(Decoder& decoder);
|
|
// template<typename T> ErrorOr<Vector<T>> decode(Decoder& decoder);
|
|
//
|
|
// Then decode<int>() would be ambiguous because either declaration could work (the compiler would
|
|
// not be able to distinguish if you wanted to decode an int or a Vector of int).
|
|
namespace IPC::Concepts {
|
|
|
|
namespace Detail {
|
|
|
|
template<typename T>
|
|
constexpr inline bool IsHashMap = false;
|
|
template<typename K, typename V>
|
|
constexpr inline bool IsHashMap<HashMap<K, V>> = true;
|
|
template<typename K, typename V>
|
|
constexpr inline bool IsHashMap<OrderedHashMap<K, V>> = true;
|
|
|
|
template<typename T>
|
|
constexpr inline bool IsOptional = false;
|
|
template<typename T>
|
|
constexpr inline bool IsOptional<Optional<T>> = true;
|
|
|
|
template<typename T>
|
|
constexpr inline bool IsSharedSingleProducerCircularQueue = false;
|
|
template<typename T, size_t Size>
|
|
constexpr inline bool IsSharedSingleProducerCircularQueue<Core::SharedSingleProducerCircularQueue<T, Size>> = true;
|
|
|
|
template<typename T>
|
|
constexpr inline bool IsVariant = false;
|
|
template<typename... Ts>
|
|
constexpr inline bool IsVariant<Variant<Ts...>> = true;
|
|
|
|
template<typename T>
|
|
constexpr inline bool IsVector = false;
|
|
template<typename T>
|
|
constexpr inline bool IsVector<Vector<T>> = true;
|
|
|
|
}
|
|
|
|
template<typename T>
|
|
concept HashMap = Detail::IsHashMap<T>;
|
|
|
|
template<typename T>
|
|
concept Optional = Detail::IsOptional<T>;
|
|
|
|
template<typename T>
|
|
concept SharedSingleProducerCircularQueue = Detail::IsSharedSingleProducerCircularQueue<T>;
|
|
|
|
template<typename T>
|
|
concept Variant = Detail::IsVariant<T>;
|
|
|
|
template<typename T>
|
|
concept Vector = Detail::IsVector<T>;
|
|
|
|
}
|