mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2025-05-18 17:12:54 +00:00
6a549f6270
InlinePaintable was an ad-hoc paintable type required to support the
fragmentation of inline nodes across multiple lines. It existed because
there was no way to associate multiple paintables with a single layout
node. This resulted in a lot of duplicated code between PaintableBox and
InlinePaintable. For example, most of the CSS properties like
background, border, shadows, etc. and hit-testing are almost identical
for both of them. However, the code had to be duplicated to account for
the fact that InlinePaintable creates a box for each line. And we had
quite many places that operate on paintables with a code like:
```
if (box.is_paintable_box()) {
// do something
} else (box.is_inline_paintable()) {
// do exactly the same as for paintable box but using InlinePaintable
}
```
This change replaces the usage of `InlinePaintable` with
`PaintableWithLines` created for each line, which is now possible
because we support having multiple paintables per layout node. By doing
that, we remove lots of duplicated code and bring our implementation
closer to the spec.
31 lines
1.7 KiB
Text
31 lines
1.7 KiB
Text
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
|
|
BlockContainer <html> at (0,0) content-size 800x600 [BFC] children: not-inline
|
|
BlockContainer <body> at (8,8) content-size 784x34 children: not-inline
|
|
BlockContainer <details> at (8,8) content-size 784x34 children: not-inline
|
|
ListItemBox <summary> at (32,8) content-size 760x17 children: inline
|
|
frag 0 from TextNode start: 0, length: 13, rect: [32,8 114.625x17] baseline: 13.296875
|
|
"I'm a summary"
|
|
TextNode <#text>
|
|
ListItemMarkerBox <(anonymous)> at (8,8) content-size 12x17 children: not-inline
|
|
BlockContainer <slot> at (8,25) content-size 784x17 children: inline
|
|
TextNode <#text>
|
|
TextNode <#text>
|
|
InlineNode <span>
|
|
frag 0 from TextNode start: 0, length: 10, rect: [8,25 82.3125x17] baseline: 13.296875
|
|
"I'm a node"
|
|
TextNode <#text>
|
|
TextNode <#text>
|
|
BlockContainer <(anonymous)> at (8,42) content-size 784x0 children: inline
|
|
TextNode <#text>
|
|
|
|
ViewportPaintable (Viewport<#document>) [0,0 800x600]
|
|
PaintableWithLines (BlockContainer<HTML>) [0,0 800x600]
|
|
PaintableWithLines (BlockContainer<BODY>) [8,8 784x34]
|
|
PaintableWithLines (BlockContainer<DETAILS>) [8,8 784x34]
|
|
PaintableWithLines (ListItemBox<SUMMARY>) [32,8 760x17]
|
|
TextPaintable (TextNode<#text>)
|
|
MarkerPaintable (ListItemMarkerBox(anonymous)) [8,8 12x17]
|
|
PaintableWithLines (BlockContainer<SLOT>) [8,25 784x17]
|
|
PaintableWithLines (InlineNode<SPAN>)
|
|
TextPaintable (TextNode<#text>)
|
|
PaintableWithLines (BlockContainer(anonymous)) [8,42 784x0]
|