ladybird/Tests/LibWeb/Text/expected/iframe-removed-asyncronously.txt at 9a7ce901b762794a8dafbe17ec0d38c30c2a6b58 - mirrors/ladybird - git.jellysandwich.dev

mirrors/ladybird

mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-05-14 07:02:54 +00:00

Shannon Booth 30377e6e35 LibWeb: Do not spin the event loop on processing iframe attributes

Partially reverting a3149c1ce9

Spinning the event loop was causing a crash on:

https://wpt.live/url/percent-encoding.window.html

As it was turning what is meant to be a synchronous operation into an
asynchronous one.

The sequence demonstrated by the reproducing test is as follows:
  * A src attribute is changed for the iframe
  * process_the_iframe_attributes entered with valid content navigable
  * Event loop is spun, allowing the queued iframe removal to execute
  * process_the_iframe_attributes continues with null content navigable
  * 💥

2024-10-07 15:10:41 +02:00

1 line

21 B

Text

Raw Blame History

PASS! (Didn't crash)