mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2025-06-01 07:52:50 +00:00
988c8451d4
Fixes crashing after following steps: 1. Open https://github.com/SerenityOS/serenity 2. Click on "Pull requests" tab The problem was `navigable` null pointer dereferencing in `decode_favicon()`. But navigable is null because the document was created by `parseFromString()` DOMParser API. With this change we skip fetching initiated by HTMLLinkElement if document does not have a browsing context: - Favicon is not displayed for such documents so no need to fetch. - Stylesheets fetching won't affect such document because style or layout does not run for them.
10 lines
452 B
HTML
10 lines
452 B
HTML
<!DOCTYPE html>
|
|
<script src="include.js"></script>
|
|
<script>
|
|
test(() => {
|
|
const parser = new DOMParser();
|
|
const htmlString = '<head><link rel="icon" type="image/png" href="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAIAAACQkWg2AAAAEElEQVR4nGNgGAWjYBTAAAADEAABPywr7AAAAABJRU5ErkJggg=="></head>';
|
|
const doc = parser.parseFromString(htmlString, "text/html");
|
|
println("PASS (didn't crash)");
|
|
});
|
|
</script>
|