mirror of
				https://github.com/LadybirdBrowser/ladybird.git
				synced 2025-10-24 17:09:43 +00:00 
			
		
		
		
	After speaking with fantasai at CSSWG about this, it turns out I had misunderstood intrinsic heights. I originally believed all intrinsic sizes had to be computed with no influence from the surrounding context. As it turns out, intrinsic heights *are* influenced by the available width, since it's needed to determine where lines break. The APIs for calculating min-content and max-content heights now take the available width as inputs. This instantly improves layout in many cases where we'd previously make things way too wide.
		
			
				
	
	
		
			122 lines
		
	
	
	
		
			4.9 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
			
		
		
	
	
			122 lines
		
	
	
	
		
			4.9 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
| /*
 | |
|  * Copyright (c) 2020-2022, Andreas Kling <kling@serenityos.org>
 | |
|  *
 | |
|  * SPDX-License-Identifier: BSD-2-Clause
 | |
|  */
 | |
| 
 | |
| #pragma once
 | |
| 
 | |
| #include <AK/OwnPtr.h>
 | |
| #include <LibWeb/Forward.h>
 | |
| #include <LibWeb/Layout/AvailableSpace.h>
 | |
| #include <LibWeb/Layout/LayoutState.h>
 | |
| 
 | |
| namespace Web::Layout {
 | |
| 
 | |
| class FormattingContext {
 | |
| public:
 | |
|     virtual ~FormattingContext();
 | |
| 
 | |
|     enum class Type {
 | |
|         Block,
 | |
|         Inline,
 | |
|         Flex,
 | |
|         Table,
 | |
|         SVG,
 | |
|     };
 | |
| 
 | |
|     virtual void run(Box const&, LayoutMode, AvailableSpace const&) = 0;
 | |
| 
 | |
|     // This function returns the automatic content height of the context's root box.
 | |
|     virtual float automatic_content_width() const { return 0; }
 | |
| 
 | |
|     // This function returns the automatic content height of the context's root box.
 | |
|     virtual float automatic_content_height() const = 0;
 | |
| 
 | |
|     Box const& context_box() const { return m_context_box; }
 | |
| 
 | |
|     FormattingContext* parent() { return m_parent; }
 | |
|     FormattingContext const* parent() const { return m_parent; }
 | |
| 
 | |
|     Type type() const { return m_type; }
 | |
|     bool is_block_formatting_context() const { return type() == Type::Block; }
 | |
| 
 | |
|     virtual bool inhibits_floating() const { return false; }
 | |
| 
 | |
|     static bool creates_block_formatting_context(Box const&);
 | |
| 
 | |
|     static float compute_width_for_replaced_element(LayoutState const&, ReplacedBox const&, AvailableSpace const&);
 | |
|     static float compute_height_for_replaced_element(LayoutState const&, ReplacedBox const&, AvailableSpace const&);
 | |
| 
 | |
|     OwnPtr<FormattingContext> create_independent_formatting_context_if_needed(LayoutState&, Box const& child_box);
 | |
| 
 | |
|     virtual void parent_context_did_dimension_child_root_box() { }
 | |
| 
 | |
|     float calculate_min_content_width(Layout::Box const&) const;
 | |
|     float calculate_max_content_width(Layout::Box const&) const;
 | |
|     float calculate_min_content_height(Layout::Box const&, AvailableSize const& available_width) const;
 | |
|     float calculate_max_content_height(Layout::Box const&, AvailableSize const& available_width) const;
 | |
| 
 | |
|     float calculate_fit_content_height(Layout::Box const&, AvailableSpace const&) const;
 | |
|     float calculate_fit_content_width(Layout::Box const&, AvailableSpace const&) const;
 | |
| 
 | |
|     virtual float greatest_child_width(Box const&);
 | |
| 
 | |
|     float containing_block_width_for(Box const& box) const { return containing_block_width_for(box, m_state); }
 | |
|     float containing_block_height_for(Box const& box) const { return containing_block_height_for(box, m_state); }
 | |
| 
 | |
|     static float containing_block_width_for(Box const&, LayoutState const&);
 | |
|     static float containing_block_height_for(Box const&, LayoutState const&);
 | |
| 
 | |
|     float compute_box_y_position_with_respect_to_siblings(Box const&) const;
 | |
| 
 | |
|     float calculate_stretch_fit_width(Box const&, AvailableSize const&) const;
 | |
| 
 | |
|     virtual bool can_determine_size_of_child() const { return false; }
 | |
|     virtual void determine_width_of_child(Box const&, AvailableSpace const&) { }
 | |
|     virtual void determine_height_of_child(Box const&, AvailableSpace const&) { }
 | |
| 
 | |
|     virtual Gfx::FloatPoint calculate_static_position(Box const&) const;
 | |
| 
 | |
| protected:
 | |
|     FormattingContext(Type, LayoutState&, Box const&, FormattingContext* parent = nullptr);
 | |
| 
 | |
|     float calculate_fit_content_size(float min_content_size, float max_content_size, AvailableSize const&) const;
 | |
| 
 | |
|     OwnPtr<FormattingContext> layout_inside(Box const&, LayoutMode, AvailableSpace const&);
 | |
|     void compute_inset(Box const& box);
 | |
| 
 | |
|     struct SpaceUsedByFloats {
 | |
|         float left { 0 };
 | |
|         float right { 0 };
 | |
|     };
 | |
| 
 | |
|     struct ShrinkToFitResult {
 | |
|         float preferred_width { 0 };
 | |
|         float preferred_minimum_width { 0 };
 | |
|     };
 | |
| 
 | |
|     static float tentative_width_for_replaced_element(LayoutState const&, ReplacedBox const&, CSS::Size const& computed_width, AvailableSpace const&);
 | |
|     static float tentative_height_for_replaced_element(LayoutState const&, ReplacedBox const&, CSS::Size const& computed_height, AvailableSpace const&);
 | |
|     float compute_auto_height_for_block_formatting_context_root(BlockContainer const&) const;
 | |
|     float compute_auto_height_for_block_level_element(Box const&, AvailableSpace const&) const;
 | |
| 
 | |
|     ShrinkToFitResult calculate_shrink_to_fit_widths(Box const&);
 | |
| 
 | |
|     void layout_absolutely_positioned_element(Box const&, AvailableSpace const&);
 | |
|     void compute_width_for_absolutely_positioned_element(Box const&, AvailableSpace const&);
 | |
|     void compute_width_for_absolutely_positioned_non_replaced_element(Box const&, AvailableSpace const&);
 | |
|     void compute_width_for_absolutely_positioned_replaced_element(ReplacedBox const&, AvailableSpace const&);
 | |
|     void compute_height_for_absolutely_positioned_element(Box const&, AvailableSpace const&);
 | |
|     void compute_height_for_absolutely_positioned_non_replaced_element(Box const&, AvailableSpace const&);
 | |
|     void compute_height_for_absolutely_positioned_replaced_element(ReplacedBox const&, AvailableSpace const&);
 | |
| 
 | |
|     Type m_type {};
 | |
| 
 | |
|     FormattingContext* m_parent { nullptr };
 | |
|     Box const& m_context_box;
 | |
| 
 | |
|     LayoutState& m_state;
 | |
| };
 | |
| 
 | |
| }
 |