mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2025-07-22 08:51:57 +00:00
Instead, we can just use the scope type to determine if a scope is a
function scope.
This fixes using `this` for parameter default values in arrow functions
crashing. This happened by `uses_this_from_environment` was not set in
`set_uses_this`, as it didn't think it was in a function scope whilst
parsing parameters.
Fixes closing modal dialogs causing a crash on https://www.ikea.com/
No test262 diff.
Reverts the functional part of 08cfd5f
, because it was a workaround for
this issue.
21 lines
534 B
JavaScript
21 lines
534 B
JavaScript
test("using this in default value of arrow function parameter does not crash", () => {
|
|
const result = [];
|
|
|
|
class A {
|
|
constructor() {
|
|
this.foo = (bar = this.value1, baz = this.value2, value3 = this.value3) => {
|
|
result.push(bar);
|
|
result.push(baz);
|
|
result.push(value3);
|
|
};
|
|
|
|
this.value1 = 20;
|
|
this.value2 = 30;
|
|
this.value3 = 40;
|
|
}
|
|
}
|
|
|
|
new A().foo(10);
|
|
|
|
expect(result).toEqual([10, 30, 40]);
|
|
});
|