mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2025-07-22 00:41:55 +00:00
d08d6b08d3
Our currently implementation of structured serialization has a design flaw, where if the serialized/transferred type was not used in the destination realm, it would not be seen as exposed and thus we would not re-create the type on the other side. This is very common, for example, transferring a MessagePort to a just inserted iframe, or the just inserted iframe transferring a MessagePort to it's parent. This is what Google reCAPTCHA does. This flaw occurred due to relying on lazily populated HashMaps of constructors, namespaces and interfaces. This commit changes it so that per-type "is exposed" implementations are generated. Since it no longer relies on interface name strings, this commit changes serializable types to indicate their type with an enum, in line with how transferrable types indicate their type. This makes Google reCAPTCHA work on https://www.google.com/recaptcha/api2/demo It currently doesn't work on non-Google origins due to a separate same-origin policy bug.
45 lines
1.5 KiB
C++
45 lines
1.5 KiB
C++
/*
|
|
* Copyright (c) 2021, Andreas Kling <andreas@ladybird.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <LibWeb/Geometry/DOMRectReadOnly.h>
|
|
|
|
namespace Web::Geometry {
|
|
|
|
// https://drafts.fxtf.org/geometry/#DOMRect
|
|
class DOMRect final : public DOMRectReadOnly {
|
|
WEB_PLATFORM_OBJECT(DOMRect, DOMRectReadOnly);
|
|
GC_DECLARE_ALLOCATOR(DOMRect);
|
|
|
|
public:
|
|
static WebIDL::ExceptionOr<GC::Ref<DOMRect>> construct_impl(JS::Realm&, double x = 0, double y = 0, double width = 0, double height = 0);
|
|
[[nodiscard]] static GC::Ref<DOMRect> create(JS::Realm&, Gfx::FloatRect const&);
|
|
[[nodiscard]] static GC::Ref<DOMRect> create(JS::Realm&);
|
|
[[nodiscard]] static GC::Ref<DOMRect> from_rect(JS::VM&, DOMRectInit const&);
|
|
|
|
virtual ~DOMRect() override;
|
|
|
|
double x() const { return m_rect.x(); }
|
|
double y() const { return m_rect.y(); }
|
|
double width() const { return m_rect.width(); }
|
|
double height() const { return m_rect.height(); }
|
|
|
|
void set_x(double x) { m_rect.set_x(x); }
|
|
void set_y(double y) { m_rect.set_y(y); }
|
|
void set_width(double width) { m_rect.set_width(width); }
|
|
void set_height(double height) { m_rect.set_height(height); }
|
|
|
|
virtual HTML::SerializeType serialize_type() const override { return HTML::SerializeType::DOMRect; }
|
|
|
|
private:
|
|
DOMRect(JS::Realm&, double x, double y, double width, double height);
|
|
explicit DOMRect(JS::Realm&);
|
|
|
|
virtual void initialize(JS::Realm&) override;
|
|
};
|
|
|
|
}
|