ladybird/Libraries/LibWeb/Geometry/DOMRectReadOnly.cpp
Timothy Flynn 64abc6101d LibWeb+WebWorker: Use IPC mechanics for structured serialization
Our structured serialization implementation had its own bespoke encoder
and decoder to serialize JS values. It also used a u32 buffer under the
hood, which made using its structures a bit awkward. We had previously
worked around its data structures in transferable streams, which nested
transfers of MessagePort instances. We basically had to add hooks into
the MessagePort to route to the correct transfer receiving steps, and
we could not invoke the correct AOs directly as the spec dictates.

We now use IPC mechanics to encode and decode data. This works because,
although we are encoding JS values, we are only ultimately encoding
primitive and basic AK types. The resulting data structures actually
enforce that we implement transferable streams exactly as the spec is
worded (I had planned to do that in a separate commit, but the fallout
of this patch actually required that change).
2025-07-18 10:09:02 -04:00

91 lines
2.7 KiB
C++
Raw Blame History

This file contains ambiguous Unicode characters

This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.

/*
* Copyright (c) 2022, Andreas Kling <andreas@ladybird.org>
* Copyright (c) 2024, Kenneth Myhra <kennethmyhra@serenityos.org>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
#include <LibWeb/Bindings/DOMRectReadOnlyPrototype.h>
#include <LibWeb/Bindings/Intrinsics.h>
#include <LibWeb/Geometry/DOMRectReadOnly.h>
#include <LibWeb/HTML/StructuredSerialize.h>
#include <LibWeb/WebIDL/ExceptionOr.h>
namespace Web::Geometry {
GC_DEFINE_ALLOCATOR(DOMRectReadOnly);
WebIDL::ExceptionOr<GC::Ref<DOMRectReadOnly>> DOMRectReadOnly::construct_impl(JS::Realm& realm, double x, double y, double width, double height)
{
return realm.create<DOMRectReadOnly>(realm, x, y, width, height);
}
// https://drafts.fxtf.org/geometry/#create-a-domrect-from-the-dictionary
GC::Ref<DOMRectReadOnly> DOMRectReadOnly::from_rect(JS::VM& vm, Geometry::DOMRectInit const& other)
{
auto& realm = *vm.current_realm();
return realm.create<DOMRectReadOnly>(realm, other.x, other.y, other.width, other.height);
}
GC::Ref<DOMRectReadOnly> DOMRectReadOnly::create(JS::Realm& realm)
{
return realm.create<DOMRectReadOnly>(realm);
}
DOMRectReadOnly::DOMRectReadOnly(JS::Realm& realm, double x, double y, double width, double height)
: PlatformObject(realm)
, m_rect(x, y, width, height)
{
}
DOMRectReadOnly::DOMRectReadOnly(JS::Realm& realm)
: PlatformObject(realm)
{
}
DOMRectReadOnly::~DOMRectReadOnly() = default;
void DOMRectReadOnly::initialize(JS::Realm& realm)
{
WEB_SET_PROTOTYPE_FOR_INTERFACE(DOMRectReadOnly);
Base::initialize(realm);
}
// https://drafts.fxtf.org/geometry/#structured-serialization
WebIDL::ExceptionOr<void> DOMRectReadOnly::serialization_steps(HTML::TransferDataEncoder& serialized, bool, HTML::SerializationMemory&)
{
// 1. Set serialized.[[X]] to values x coordinate.
serialized.encode(x());
// 2. Set serialized.[[Y]] to values y coordinate.
serialized.encode(y());
// 3. Set serialized.[[Width]] to values width.
serialized.encode(width());
// 4. Set serialized.[[Height]] to values height.
serialized.encode(height());
return {};
}
// https://drafts.fxtf.org/geometry/#structured-serialization
WebIDL::ExceptionOr<void> DOMRectReadOnly::deserialization_steps(HTML::TransferDataDecoder& serialized, HTML::DeserializationMemory&)
{
// 1. Set values x coordinate to serialized.[[X]].
auto x = serialized.decode<double>();
// 2. Set values y coordinate to serialized.[[Y]].
auto y = serialized.decode<double>();
// 3. Set values width to serialized.[[Width]].
auto width = serialized.decode<double>();
// 4. Set values height to serialized.[[Height]].
auto height = serialized.decode<double>();
m_rect = { x, y, width, height };
return {};
}
}