mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2025-07-23 17:33:12 +00:00
eed47acb1f
Until now, every paint phase of every PaintableBox injected its own
clipping sequence into the display list:
```
before_paint: Save
AddClipRect (1)
...clip rectangles for each containing block with clip...
AddClipRect (N)
paint: ...paint phase items...
after_paint: Restore
```
Because we ran that sequence for every phase of every box, Skia had to
rebuild clip stack `paint_phases * paintable_boxes` times. Worse,
usually most paint phases contribute no visible drawing at all, yet we
still had to emit clipping items because `before_paint()` has no way to
know that in advance.
This change takes a different approach:
- Clip information is now attached as metadata `ClipFrame` to each
DisplayList item.
- `DisplayListPlayer` groups consecutive commands that share a
`ClipFrame`, applying the clip once at the start of the group and
restoring it once at the end.
Going from 10 ms to 5 ms in rasterization on Discord might not sound
like much, but keep in mind that for 60fps we have 16 ms per frame and
there is a lot more work besides display list rasterization we do in
each frame.
* https://discord.com/channels/1247070541085671459/1247090064480014443
- DisplayList items: 81844 -> 3671
- rasterize time: 10 ms -> 5 ms
- record time: 5 ms -> 3 ms
* https://github.com/LadybirdBrowser/ladybird
- DisplayList items: 7902 -> 1176
- rasterize time: 4 ms -> 4 ms
- record time: 3 ms -> 2 ms
113 lines
4.6 KiB
C++
113 lines
4.6 KiB
C++
/*
|
|
* Copyright (c) 2024-2025, Aliaksandr Kalenik <kalenik.aliaksandr@gmail.com>
|
|
* Copyright (c) 2025, Jelle Raaijmakers <jelle@ladybird.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <AK/Forward.h>
|
|
#include <AK/NonnullRefPtr.h>
|
|
#include <AK/SegmentedVector.h>
|
|
#include <LibGfx/Color.h>
|
|
#include <LibGfx/Forward.h>
|
|
#include <LibGfx/ImmutableBitmap.h>
|
|
#include <LibGfx/PaintStyle.h>
|
|
#include <LibWeb/CSS/Enums.h>
|
|
#include <LibWeb/Painting/ClipFrame.h>
|
|
#include <LibWeb/Painting/Command.h>
|
|
#include <LibWeb/Painting/ScrollState.h>
|
|
|
|
namespace Web::Painting {
|
|
|
|
class DisplayList;
|
|
|
|
class DisplayListPlayer {
|
|
public:
|
|
virtual ~DisplayListPlayer() = default;
|
|
|
|
void execute(DisplayList&, ScrollStateSnapshot const&, RefPtr<Gfx::PaintingSurface>);
|
|
|
|
protected:
|
|
Gfx::PaintingSurface& surface() const { return m_surfaces.last(); }
|
|
void execute_impl(DisplayList&, ScrollStateSnapshot const& scroll_state, RefPtr<Gfx::PaintingSurface>);
|
|
|
|
private:
|
|
virtual void flush() = 0;
|
|
virtual void draw_glyph_run(DrawGlyphRun const&) = 0;
|
|
virtual void fill_rect(FillRect const&) = 0;
|
|
virtual void draw_painting_surface(DrawPaintingSurface const&) = 0;
|
|
virtual void draw_scaled_immutable_bitmap(DrawScaledImmutableBitmap const&) = 0;
|
|
virtual void draw_repeated_immutable_bitmap(DrawRepeatedImmutableBitmap const&) = 0;
|
|
virtual void save(Save const&) = 0;
|
|
virtual void save_layer(SaveLayer const&) = 0;
|
|
virtual void restore(Restore const&) = 0;
|
|
virtual void translate(Translate const&) = 0;
|
|
virtual void add_clip_rect(AddClipRect const&) = 0;
|
|
virtual void push_stacking_context(PushStackingContext const&) = 0;
|
|
virtual void pop_stacking_context(PopStackingContext const&) = 0;
|
|
virtual void paint_linear_gradient(PaintLinearGradient const&) = 0;
|
|
virtual void paint_radial_gradient(PaintRadialGradient const&) = 0;
|
|
virtual void paint_conic_gradient(PaintConicGradient const&) = 0;
|
|
virtual void paint_outer_box_shadow(PaintOuterBoxShadow const&) = 0;
|
|
virtual void paint_inner_box_shadow(PaintInnerBoxShadow const&) = 0;
|
|
virtual void paint_text_shadow(PaintTextShadow const&) = 0;
|
|
virtual void fill_rect_with_rounded_corners(FillRectWithRoundedCorners const&) = 0;
|
|
virtual void fill_path_using_color(FillPathUsingColor const&) = 0;
|
|
virtual void fill_path_using_paint_style(FillPathUsingPaintStyle const&) = 0;
|
|
virtual void stroke_path_using_color(StrokePathUsingColor const&) = 0;
|
|
virtual void stroke_path_using_paint_style(StrokePathUsingPaintStyle const&) = 0;
|
|
virtual void draw_ellipse(DrawEllipse const&) = 0;
|
|
virtual void fill_ellipse(FillEllipse const&) = 0;
|
|
virtual void draw_line(DrawLine const&) = 0;
|
|
virtual void apply_backdrop_filter(ApplyBackdropFilter const&) = 0;
|
|
virtual void draw_rect(DrawRect const&) = 0;
|
|
virtual void draw_triangle_wave(DrawTriangleWave const&) = 0;
|
|
virtual void add_rounded_rect_clip(AddRoundedRectClip const&) = 0;
|
|
virtual void add_mask(AddMask const&) = 0;
|
|
virtual void paint_nested_display_list(PaintNestedDisplayList const&) = 0;
|
|
virtual void paint_scrollbar(PaintScrollBar const&) = 0;
|
|
virtual void apply_opacity(ApplyOpacity const&) = 0;
|
|
virtual void apply_composite_and_blending_operator(ApplyCompositeAndBlendingOperator const&) = 0;
|
|
virtual void apply_filters(ApplyFilter const&) = 0;
|
|
virtual void apply_transform(ApplyTransform const&) = 0;
|
|
virtual void apply_mask_bitmap(ApplyMaskBitmap const&) = 0;
|
|
virtual bool would_be_fully_clipped_by_painter(Gfx::IntRect) const = 0;
|
|
|
|
void apply_clip_frame(ClipFrame const&, DevicePixelConverter const&);
|
|
void remove_clip_frame(ClipFrame const&);
|
|
|
|
Vector<NonnullRefPtr<Gfx::PaintingSurface>, 1> m_surfaces;
|
|
};
|
|
|
|
class DisplayList : public AtomicRefCounted<DisplayList> {
|
|
public:
|
|
static NonnullRefPtr<DisplayList> create()
|
|
{
|
|
return adopt_ref(*new DisplayList());
|
|
}
|
|
|
|
void append(Command&& command, Optional<i32> scroll_frame_id, RefPtr<ClipFrame const>);
|
|
|
|
struct CommandListItem {
|
|
Optional<i32> scroll_frame_id;
|
|
RefPtr<ClipFrame const> clip_frame;
|
|
Command command;
|
|
};
|
|
|
|
AK::SegmentedVector<CommandListItem, 512> const& commands() const { return m_commands; }
|
|
|
|
void set_device_pixels_per_css_pixel(double device_pixels_per_css_pixel) { m_device_pixels_per_css_pixel = device_pixels_per_css_pixel; }
|
|
double device_pixels_per_css_pixel() const { return m_device_pixels_per_css_pixel; }
|
|
|
|
String dump() const;
|
|
|
|
private:
|
|
DisplayList() = default;
|
|
|
|
AK::SegmentedVector<CommandListItem, 512> m_commands;
|
|
double m_device_pixels_per_css_pixel;
|
|
};
|
|
|
|
}
|