mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2025-07-23 17:33:12 +00:00
910fd426a2
83b6bc4 went too far by forbidding SVGSVGElement from establishing a
stacking context. This element type does follow the behavior of CSS
boxes, unlike inner SVG elements like `<rect>`, `<circle>`, etc., which
are not supposed to be aware of concepts like stacking contexts,
overflow clipping, scroll offsets, etc.
This change allows us to delete overrides of `before_paint()` and
`after_paint()` in SVGPaintable and SVGSVGPaintable, because display
list recording code has been rearranged to take care of clipping and
scrolling before recursing into SVGSVGPaintable descendants.
`Screenshot/images/css-transform-box-ref.png` expectation is updated and
fixes a bug where a rectangle at the very bottom of the page was not
clipped correctly.
`Screenshot/images/svg-filters-lb-website-ref.png` has a more subtle
difference, but if you look closely, you’ll see it matches other
browsers more closely now.
36 lines
957 B
C++
36 lines
957 B
C++
/*
|
|
* Copyright (c) 2022, Andreas Kling <andreas@ladybird.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <LibWeb/Layout/SVGSVGBox.h>
|
|
#include <LibWeb/Painting/PaintableBox.h>
|
|
|
|
namespace Web::Painting {
|
|
|
|
class SVGSVGPaintable final : public PaintableBox {
|
|
GC_CELL(SVGSVGPaintable, PaintableBox);
|
|
GC_DECLARE_ALLOCATOR(SVGSVGPaintable);
|
|
|
|
public:
|
|
static GC::Ref<SVGSVGPaintable> create(Layout::SVGSVGBox const&);
|
|
|
|
Layout::SVGSVGBox const& layout_box() const;
|
|
|
|
static void paint_svg_box(PaintContext& context, PaintableBox const& svg_box, PaintPhase phase);
|
|
static void paint_descendants(PaintContext& context, PaintableBox const& paintable, PaintPhase phase);
|
|
|
|
protected:
|
|
SVGSVGPaintable(Layout::SVGSVGBox const&);
|
|
|
|
private:
|
|
virtual bool is_svg_svg_paintable() const final { return true; }
|
|
};
|
|
|
|
template<>
|
|
inline bool Paintable::fast_is<SVGSVGPaintable>() const { return is_svg_svg_paintable(); }
|
|
|
|
}
|