mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2025-10-18 06:00:27 +00:00
d45f8a3081
Some checks are pending
CI / macOS, arm64, Sanitizer, Clang (push) Waiting to run
CI / Linux, x86_64, Fuzzers, Clang (push) Waiting to run
CI / Linux, x86_64, Sanitizer, GNU (push) Waiting to run
CI / Linux, x86_64, Sanitizer, Clang (push) Waiting to run
Package the js repl as a binary artifact / Linux, arm64 (push) Waiting to run
Package the js repl as a binary artifact / macOS, arm64 (push) Waiting to run
Package the js repl as a binary artifact / Linux, x86_64 (push) Waiting to run
Label PRs with merge conflicts / auto-labeler (push) Waiting to run
Push notes / build (push) Waiting to run
Run test262 and test-wasm / run_and_update_results (push) Waiting to run
Lint Code / lint (push) Waiting to run
We already had IC support in PutById for the following cases:
- Changing an existing own property
- Calling a setter located in the prototype chain
This was enough to speed up code where structurally identical objects
(same shape) are processed in a loop:
```js
const arr = [{ a: 1 }, { a: 2 }, { a: 3 }];
for (let obj of arr) {
obj.a += 1;
}
```
However, creating structurally identical objects in a loop was still
slow:
```js
for (let i = 0; i < 10_000_000; i++) {
const o = {};
o.a = 1;
o.b = 2;
o.c = 3;
}
```
This change addresses that by adding a new IC type that caches both the
source and target shapes, allowing property additions to be fast-pathed
by directly jumping to the shape that already includes the new property.
91 lines
3.3 KiB
C++
91 lines
3.3 KiB
C++
/*
|
|
* Copyright (c) 2020, Andreas Kling <andreas@ladybird.org>
|
|
* Copyright (c) 2020-2022, Linus Groh <linusg@serenityos.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <AK/Assertions.h>
|
|
#include <AK/Concepts.h>
|
|
#include <AK/Function.h>
|
|
#include <AK/Span.h>
|
|
#include <AK/Vector.h>
|
|
#include <LibJS/Export.h>
|
|
#include <LibJS/Runtime/Completion.h>
|
|
#include <LibJS/Runtime/GlobalObject.h>
|
|
#include <LibJS/Runtime/Object.h>
|
|
#include <LibJS/Runtime/VM.h>
|
|
|
|
namespace JS {
|
|
|
|
class JS_API Array : public Object {
|
|
JS_OBJECT(Array, Object);
|
|
GC_DECLARE_ALLOCATOR(Array);
|
|
|
|
public:
|
|
static ThrowCompletionOr<GC::Ref<Array>> create(Realm&, u64 length, Object* prototype = nullptr);
|
|
static GC::Ref<Array> create_from(Realm&, ReadonlySpan<Value>);
|
|
|
|
template<size_t N>
|
|
static GC::Ref<Array> create_from(Realm& realm, Value const (&values)[N])
|
|
{
|
|
return create_from(realm, ReadonlySpan<Value> { values, N });
|
|
}
|
|
|
|
// Non-standard but equivalent to CreateArrayFromList.
|
|
template<typename T>
|
|
static GC::Ref<Array> create_from(Realm& realm, ReadonlySpan<T> elements, Function<Value(T const&)> map_fn)
|
|
{
|
|
auto values = GC::RootVector<Value> { realm.heap() };
|
|
values.ensure_capacity(elements.size());
|
|
for (auto const& element : elements)
|
|
values.append(map_fn(element));
|
|
|
|
return Array::create_from(realm, values);
|
|
}
|
|
|
|
virtual ~Array() override = default;
|
|
|
|
virtual ThrowCompletionOr<Optional<PropertyDescriptor>> internal_get_own_property(PropertyKey const&) const override final;
|
|
virtual ThrowCompletionOr<bool> internal_set(PropertyKey const&, Value value, Value receiver, CacheableSetPropertyMetadata*, PropertyLookupPhase) override;
|
|
virtual ThrowCompletionOr<bool> internal_define_own_property(PropertyKey const&, PropertyDescriptor&, Optional<PropertyDescriptor>* precomputed_get_own_property = nullptr) override final;
|
|
virtual ThrowCompletionOr<bool> internal_has_property(PropertyKey const&) const override final;
|
|
virtual ThrowCompletionOr<bool> internal_delete(PropertyKey const&) override;
|
|
virtual ThrowCompletionOr<GC::RootVector<Value>> internal_own_property_keys() const override final;
|
|
|
|
[[nodiscard]] bool length_is_writable() const { return m_length_writable; }
|
|
|
|
bool is_proxy_target() const { return m_is_proxy_target; }
|
|
void set_is_proxy_target(bool is_proxy_target) { m_is_proxy_target = is_proxy_target; }
|
|
|
|
bool default_prototype_chain_intact() const;
|
|
|
|
virtual void visit_edges(Cell::Visitor& visitor) override;
|
|
|
|
protected:
|
|
explicit Array(Realm& realm, Object& prototype);
|
|
|
|
private:
|
|
virtual bool is_array_exotic_object() const final { return true; }
|
|
|
|
ThrowCompletionOr<bool> set_length(PropertyDescriptor const&);
|
|
|
|
GC::Ref<Realm> m_realm;
|
|
bool m_length_writable { true };
|
|
bool m_is_proxy_target { false };
|
|
};
|
|
|
|
template<>
|
|
inline bool Object::fast_is<Array>() const { return is_array_exotic_object(); }
|
|
|
|
enum class Holes {
|
|
SkipHoles,
|
|
ReadThroughHoles,
|
|
};
|
|
|
|
ThrowCompletionOr<GC::RootVector<Value>> sort_indexed_properties(VM&, Object const&, size_t length, Function<ThrowCompletionOr<double>(Value, Value)> const& sort_compare, Holes holes);
|
|
ThrowCompletionOr<double> compare_array_elements(VM&, Value x, Value y, FunctionObject* comparefn);
|
|
|
|
}
|