mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2025-04-25 14:05:15 +00:00
476094922b
This patch is unfortunately rather large and might make some things feel
bloated, but it is necessary to fix a few flaws in LibJS, primarily
blindly coercing values to numbers without exception checks - i.e.
interpreter.argument(0).to_i32(); // can fail!!!
Some examples where the interpreter would actually crash:
var o = { toString: () => { throw Error() } };
+o;
o - 1;
"foo".charAt(o);
"bar".repeat(o);
To fix this, we now have the following...
to_double(Interpreter&)
to_i32()
to_i32(Interpreter&)
to_size_t()
to_size_t(Interpreter&)
...and a whole lot of exception checking.
There's intentionally no to_double(), use as_double() directly instead.
This way we still can use these convenient utility functions but don't
need to check for exceptions if we are sure the value already is a
number.
Fixes #2267.
104 lines
3.8 KiB
C++
104 lines
3.8 KiB
C++
/*
|
|
* Copyright (c) 2020, Linus Groh <mail@linusgroh.de>
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions are met:
|
|
*
|
|
* 1. Redistributions of source code must retain the above copyright notice, this
|
|
* list of conditions and the following disclaimer.
|
|
*
|
|
* 2. Redistributions in binary form must reproduce the above copyright notice,
|
|
* this list of conditions and the following disclaimer in the documentation
|
|
* and/or other materials provided with the distribution.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
|
|
* AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
|
|
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
|
|
* DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
|
|
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
|
|
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
|
|
* SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
|
|
* CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
|
|
* OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
*/
|
|
|
|
#include <LibJS/Interpreter.h>
|
|
#include <LibJS/Runtime/Error.h>
|
|
#include <LibJS/Runtime/GlobalObject.h>
|
|
#include <LibJS/Runtime/NumberConstructor.h>
|
|
#include <LibJS/Runtime/NumberObject.h>
|
|
#include <math.h>
|
|
|
|
#define EPSILON pow(2, -52)
|
|
#define MAX_SAFE_INTEGER pow(2, 53) - 1
|
|
#define MIN_SAFE_INTEGER -(pow(2, 53) - 1)
|
|
|
|
namespace JS {
|
|
|
|
NumberConstructor::NumberConstructor()
|
|
: NativeFunction("Number", *interpreter().global_object().function_prototype())
|
|
{
|
|
u8 attr = Attribute::Writable | Attribute::Configurable;
|
|
put_native_function("isFinite", is_finite, 1, attr);
|
|
put_native_function("isInteger", is_integer, 1, attr);
|
|
put_native_function("isNaN", is_nan, 1, attr);
|
|
put_native_function("isSafeInteger", is_safe_integer, 1, attr);
|
|
put("parseFloat", interpreter().global_object().get("parseFloat"));
|
|
put("prototype", interpreter().global_object().number_prototype(), 0);
|
|
put("length", Value(1), Attribute::Configurable);
|
|
put("EPSILON", Value(EPSILON), 0);
|
|
put("MAX_SAFE_INTEGER", Value(MAX_SAFE_INTEGER), 0);
|
|
put("MIN_SAFE_INTEGER", Value(MIN_SAFE_INTEGER), 0);
|
|
put("NEGATIVE_INFINITY", js_negative_infinity(), 0);
|
|
put("POSITIVE_INFINITY", js_infinity(), 0);
|
|
put("NaN", js_nan(), 0);
|
|
}
|
|
|
|
NumberConstructor::~NumberConstructor()
|
|
{
|
|
}
|
|
|
|
Value NumberConstructor::call(Interpreter& interpreter)
|
|
{
|
|
if (!interpreter.argument_count())
|
|
return Value(0);
|
|
return interpreter.argument(0).to_number(interpreter);
|
|
}
|
|
|
|
Value NumberConstructor::construct(Interpreter& interpreter)
|
|
{
|
|
double number = 0;
|
|
if (interpreter.argument_count()) {
|
|
number = interpreter.argument(0).to_double(interpreter);
|
|
if (interpreter.exception())
|
|
return {};
|
|
}
|
|
return NumberObject::create(interpreter.global_object(), number);
|
|
}
|
|
|
|
Value NumberConstructor::is_finite(Interpreter& interpreter)
|
|
{
|
|
return Value(interpreter.argument(0).is_finite_number());
|
|
}
|
|
|
|
Value NumberConstructor::is_integer(Interpreter& interpreter)
|
|
{
|
|
return Value(interpreter.argument(0).is_integer());
|
|
}
|
|
|
|
Value NumberConstructor::is_nan(Interpreter& interpreter)
|
|
{
|
|
return Value(interpreter.argument(0).is_nan());
|
|
}
|
|
|
|
Value NumberConstructor::is_safe_integer(Interpreter& interpreter)
|
|
{
|
|
if (!interpreter.argument(0).is_number())
|
|
return Value(false);
|
|
auto value = interpreter.argument(0).as_double();
|
|
return Value((int64_t)value == value && value >= MIN_SAFE_INTEGER && value <= MAX_SAFE_INTEGER);
|
|
}
|
|
|
|
}
|