mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2025-04-25 05:55:13 +00:00
f3ec727555
We were previously assuming that dictionary members were always required when being returned. This is a bit of a weird case, because unlike _input_ dictionaries which the spec marks as required, 'result' dictionaries do not seem to be marked in spec IDL as required. This is still fine from the POV that the spec is written as it states that we should only be putting the values into the dictionary if the value exists. We could do this through some metaprogramming constexpr type checks. For example, if the type in our C++ representation was not an Optional, we can skip the has_value check. Instead of doing that, change the IDL of the result dictionaries to annotate these members so that the IDL generator knows this information up front. While all current cases have every single member returned or not returned, it is conceivable that the spec could have a situation that one member is always returned (and should get marked as required), while the others are optionally returned. Therefore, this new GenerateAsRequired attribute is applied for each individual member. |
||
|---|---|---|
| .. | ||
| TextDecoder.cpp | ||
| TextDecoder.h | ||
| TextDecoder.idl | ||
| TextEncoder.cpp | ||
| TextEncoder.h | ||
| TextEncoder.idl | ||
| TextEncoderCommon.cpp | ||
| TextEncoderCommon.h | ||
| TextEncoderCommon.idl | ||
| TextEncoderStream.cpp | ||
| TextEncoderStream.h | ||
| TextEncoderStream.idl | ||