mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2025-07-12 12:01:52 +00:00
f405d71657
Some checks are pending
CI / Lagom (x86_64, Fuzzers_CI, false, ubuntu-24.04, Linux, Clang) (push) Waiting to run
CI / Lagom (arm64, Sanitizer_CI, false, macos-15, macOS, Clang) (push) Waiting to run
CI / Lagom (x86_64, Sanitizer_CI, false, ubuntu-24.04, Linux, GNU) (push) Waiting to run
CI / Lagom (x86_64, Sanitizer_CI, true, ubuntu-24.04, Linux, Clang) (push) Waiting to run
Package the js repl as a binary artifact / build-and-package (arm64, macos-15, macOS, macOS-universal2) (push) Waiting to run
Package the js repl as a binary artifact / build-and-package (x86_64, ubuntu-24.04, Linux, Linux-x86_64) (push) Waiting to run
Run test262 and test-wasm / run_and_update_results (push) Waiting to run
Lint Code / lint (push) Waiting to run
Label PRs with merge conflicts / auto-labeler (push) Waiting to run
Push notes / build (push) Waiting to run
81b6a11 regressed correctness by always bypassing the `next()` method
resolution for built-in iterators, causing incorrect behavior when
`next()` was redefined on built-in prototypes. This change fixes the
issue by storing a flag on built-in prototypes indicating whether
`next()` has ever been redefined.
44 lines
1,007 B
C++
44 lines
1,007 B
C++
/*
|
|
* Copyright (c) 2020, Matthew Olsson <mattco@serenityos.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <AK/String.h>
|
|
#include <AK/Utf8View.h>
|
|
#include <LibJS/Runtime/Iterator.h>
|
|
#include <LibJS/Runtime/Object.h>
|
|
|
|
namespace JS {
|
|
|
|
class StringIterator final : public Object
|
|
, public BuiltinIterator {
|
|
JS_OBJECT(StringIterator, Object);
|
|
GC_DECLARE_ALLOCATOR(StringIterator);
|
|
|
|
public:
|
|
static GC::Ref<StringIterator> create(Realm&, String string);
|
|
|
|
virtual ~StringIterator() override = default;
|
|
|
|
BuiltinIterator* as_builtin_iterator_if_next_is_not_redefined() override
|
|
{
|
|
if (m_next_method_was_redefined)
|
|
return nullptr;
|
|
return this;
|
|
}
|
|
ThrowCompletionOr<void> next(VM&, bool& done, Value& value) override;
|
|
|
|
private:
|
|
explicit StringIterator(String string, Object& prototype);
|
|
|
|
friend class StringIteratorPrototype;
|
|
|
|
String m_string;
|
|
Utf8CodePointIterator m_iterator;
|
|
bool m_done { false };
|
|
};
|
|
|
|
}
|