ladybird/Libraries/LibWeb/WebIDL/ObservableArray.cpp
Aliaksandr Kalenik bd6750aaa5 LibJS: Skip prototype chain lookup in internal_set() for arrays
...when Array.prototype and Object.prototype are intact.

If `internal_set()` is called on an array exotic object with a numeric
PropertyKey, and:
- the prototype chain has not been modified (i.e., there are no getters
  or setters for indexed properties), and
- the array is not the target of a Proxy object,

then we can directly store the value in the receiver's indexed
properties, without checking whether it already exists somewhere in the
prototype chain.

1.7x improvement on the following program:
```js
function f() {
    let a = [];
    let i = 0;
    while (i < 10_000_000) {
        a.push(i);
        i++;
    }
}

f();
```
2025-05-23 14:51:32 +02:00

77 lines
2.7 KiB
C++

/*
* Copyright (c) 2024, Aliaksandr Kalenik <kalenik.aliaksandr@gmail.com>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
#include <LibWeb/Bindings/ExceptionOrUtils.h>
#include <LibWeb/WebIDL/ObservableArray.h>
namespace Web::WebIDL {
GC_DEFINE_ALLOCATOR(ObservableArray);
GC::Ref<ObservableArray> ObservableArray::create(JS::Realm& realm)
{
auto prototype = realm.intrinsics().array_prototype();
return realm.create<ObservableArray>(realm, prototype);
}
ObservableArray::ObservableArray(JS::Realm& realm, Object& prototype)
: JS::Array(realm, prototype)
{
}
void ObservableArray::visit_edges(JS::Cell::Visitor& visitor)
{
Base::visit_edges(visitor);
visitor.visit(m_on_set_an_indexed_value);
visitor.visit(m_on_delete_an_indexed_value);
}
void ObservableArray::set_on_set_an_indexed_value_callback(SetAnIndexedValueCallbackFunction&& callback)
{
m_on_set_an_indexed_value = GC::create_function(heap(), move(callback));
}
void ObservableArray::set_on_delete_an_indexed_value_callback(DeleteAnIndexedValueCallbackFunction&& callback)
{
m_on_delete_an_indexed_value = GC::create_function(heap(), move(callback));
}
JS::ThrowCompletionOr<bool> ObservableArray::internal_set(JS::PropertyKey const& property_key, JS::Value value, JS::Value receiver, JS::CacheablePropertyMetadata* metadata, PropertyLookupPhase phase)
{
if (property_key.is_number() && m_on_set_an_indexed_value)
TRY(Bindings::throw_dom_exception_if_needed(vm(), [&] { return m_on_set_an_indexed_value->function()(value); }));
return TRY(Base::internal_set(property_key, value, receiver, metadata, phase));
}
JS::ThrowCompletionOr<bool> ObservableArray::internal_delete(JS::PropertyKey const& property_key)
{
if (property_key.is_number() && m_on_delete_an_indexed_value) {
auto maybe_value_and_attributes = indexed_properties().get(property_key.as_number());
JS::Value deleted_value;
if (maybe_value_and_attributes.has_value())
deleted_value = maybe_value_and_attributes->value;
TRY(Bindings::throw_dom_exception_if_needed(vm(), [&] { return m_on_delete_an_indexed_value->function()(deleted_value); }));
}
return JS::Array::internal_delete(property_key);
}
JS::ThrowCompletionOr<void> ObservableArray::append(JS::Value value)
{
if (m_on_set_an_indexed_value)
TRY(Bindings::throw_dom_exception_if_needed(vm(), [&] { return m_on_set_an_indexed_value->function()(value); }));
indexed_properties().append(value);
return {};
}
void ObservableArray::clear()
{
while (!indexed_properties().is_empty()) {
auto deleted_value = indexed_properties().storage()->take_first().value;
MUST(m_on_delete_an_indexed_value->function()(deleted_value));
}
}
}