mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2025-07-23 09:22:30 +00:00
d08d6b08d3
Our currently implementation of structured serialization has a design flaw, where if the serialized/transferred type was not used in the destination realm, it would not be seen as exposed and thus we would not re-create the type on the other side. This is very common, for example, transferring a MessagePort to a just inserted iframe, or the just inserted iframe transferring a MessagePort to it's parent. This is what Google reCAPTCHA does. This flaw occurred due to relying on lazily populated HashMaps of constructors, namespaces and interfaces. This commit changes it so that per-type "is exposed" implementations are generated. Since it no longer relies on interface name strings, this commit changes serializable types to indicate their type with an enum, in line with how transferrable types indicate their type. This makes Google reCAPTCHA work on https://www.google.com/recaptcha/api2/demo It currently doesn't work on non-Google origins due to a separate same-origin policy bug.
85 lines
2.5 KiB
C++
85 lines
2.5 KiB
C++
/*
|
|
* Copyright (c) 2021, Andreas Kling <andreas@ladybird.org>
|
|
* Copyright (c) 2024, Kenneth Myhra <kennethmyhra@serenityos.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <LibGfx/Rect.h>
|
|
#include <LibWeb/Bindings/PlatformObject.h>
|
|
#include <LibWeb/Bindings/Serializable.h>
|
|
#include <LibWeb/Forward.h>
|
|
|
|
namespace Web::Geometry {
|
|
|
|
// https://drafts.fxtf.org/geometry/#dictdef-domrectinit
|
|
struct DOMRectInit {
|
|
double x { 0.0 };
|
|
double y { 0.0 };
|
|
double width { 0.0 };
|
|
double height { 0.0 };
|
|
};
|
|
|
|
// https://drafts.fxtf.org/geometry/#domrectreadonly
|
|
class DOMRectReadOnly
|
|
: public Bindings::PlatformObject
|
|
, public Bindings::Serializable {
|
|
WEB_PLATFORM_OBJECT(DOMRectReadOnly, Bindings::PlatformObject);
|
|
GC_DECLARE_ALLOCATOR(DOMRectReadOnly);
|
|
|
|
public:
|
|
static WebIDL::ExceptionOr<GC::Ref<DOMRectReadOnly>> construct_impl(JS::Realm&, double x = 0, double y = 0, double width = 0, double height = 0);
|
|
[[nodiscard]] static GC::Ref<DOMRectReadOnly> from_rect(JS::VM&, DOMRectInit const&);
|
|
static GC::Ref<DOMRectReadOnly> create(JS::Realm&);
|
|
|
|
virtual ~DOMRectReadOnly() override;
|
|
|
|
double x() const { return m_rect.x(); }
|
|
double y() const { return m_rect.y(); }
|
|
double width() const { return m_rect.width(); }
|
|
double height() const { return m_rect.height(); }
|
|
|
|
double top() const
|
|
{
|
|
if (isnan(y()) || isnan(height()))
|
|
return NAN;
|
|
return min(y(), y() + height());
|
|
}
|
|
|
|
double right() const
|
|
{
|
|
if (isnan(x()) || isnan(width()))
|
|
return NAN;
|
|
return max(x(), x() + width());
|
|
}
|
|
|
|
double bottom() const
|
|
{
|
|
if (isnan(y()) || isnan(height()))
|
|
return NAN;
|
|
return max(y(), y() + height());
|
|
}
|
|
|
|
double left() const
|
|
{
|
|
if (isnan(x()) || isnan(width()))
|
|
return NAN;
|
|
return min(x(), x() + width());
|
|
}
|
|
|
|
virtual HTML::SerializeType serialize_type() const override { return HTML::SerializeType::DOMRectReadOnly; }
|
|
virtual WebIDL::ExceptionOr<void> serialization_steps(HTML::SerializationRecord&, bool for_storage, HTML::SerializationMemory&) override;
|
|
virtual WebIDL::ExceptionOr<void> deserialization_steps(ReadonlySpan<u32> const&, size_t& position, HTML::DeserializationMemory&) override;
|
|
|
|
protected:
|
|
DOMRectReadOnly(JS::Realm&, double x, double y, double width, double height);
|
|
explicit DOMRectReadOnly(JS::Realm&);
|
|
|
|
virtual void initialize(JS::Realm&) override;
|
|
|
|
Gfx::DoubleRect m_rect;
|
|
};
|
|
|
|
}
|