mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2025-10-23 00:19:18 +00:00
cd72e788e9
Some checks are pending
CI / Lagom (arm64, Sanitizer_CI, false, macos-15, macOS, Clang) (push) Waiting to run
CI / Lagom (x86_64, Fuzzers_CI, false, ubuntu-24.04, Linux, Clang) (push) Waiting to run
CI / Lagom (x86_64, Sanitizer_CI, false, ubuntu-24.04, Linux, GNU) (push) Waiting to run
CI / Lagom (x86_64, Sanitizer_CI, true, ubuntu-24.04, Linux, Clang) (push) Waiting to run
Package the js repl as a binary artifact / build-and-package (arm64, macos-15, macOS, macOS-universal2) (push) Waiting to run
Package the js repl as a binary artifact / build-and-package (x86_64, ubuntu-24.04, Linux, Linux-x86_64) (push) Waiting to run
Run test262 and test-wasm / run_and_update_results (push) Waiting to run
Lint Code / lint (push) Waiting to run
Label PRs with merge conflicts / auto-labeler (push) Waiting to run
Push notes / build (push) Waiting to run
We were handling removing the style sheet from the shadow root, but not appending to it. Fixing this also revealed a bug that a removed link element would always try to remove from the document's list, as the root is no longer the shadow root it's in. The fix is to use the passed in old root to remove the style sheet from. Fixes the cookie banner on https://nos.nl/
13 lines
402 B
Text
13 lines
402 B
Text
== before appending
|
|
is linkEl.sheet null? true
|
|
- document stylesheets (length = 0)
|
|
- shadow root stylesheets (length = 0)
|
|
== link loaded
|
|
is linkEl.sheet null? false
|
|
- document stylesheets (length = 0)
|
|
- shadow root stylesheets (length = 1)
|
|
-- shadow root linkEl.sheet === sheet: true
|
|
== link removed
|
|
is linkEl.sheet null? true
|
|
- document stylesheets (length = 0)
|
|
- shadow root stylesheets (length = 0)
|