ladybird/Tests/LibWeb/Text/expected/favicon-in-inactive-document.txt at d1fbb7b51efdec9f2e418cde5dcbb1dacaedc80c - mirrors/ladybird - git.jellysandwich.dev

mirrors/ladybird

mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-10-23 00:19:18 +00:00

Aliaksandr Kalenik 988c8451d4 LibWeb: Skip HTMLLinkElement resource fetching for documents without BC

Fixes crashing after following steps:
1. Open https://github.com/SerenityOS/serenity
2. Click on "Pull requests" tab

The problem was `navigable` null pointer dereferencing in
`decode_favicon()`. But navigable is null because the document was
created by `parseFromString()` DOMParser API.

With this change we skip fetching initiated by HTMLLinkElement if
document does not have a browsing context:
- Favicon is not displayed for such documents so no need to fetch.
- Stylesheets fetching won't affect such document because style or
  layout does not run for them.

2024-04-25 09:31:01 +02:00

1 line

20 B

Text

Raw Blame History

PASS (didn't crash)