mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2025-04-28 15:28:55 +00:00
da177c6517
The previous handling of the name and message properties specifically was breaking websites that created their own error types and relied on the error prototype working correctly - not assuming an JS::Error this object, that is. The way it works now, and it is supposed to work, is: - Error.prototype.name and Error.prototype.message just have initial string values and are no longer getters/setters - When constructing an error with a message, we create a regular property on the newly created object, so a lookup of the message property will either get it from the object directly or go though the prototype chain - Internal m_name/m_message properties are no longer needed and removed This makes printing errors slightly more complicated, as we can no longer rely on the (safe) internal properties, and cannot trust a property lookup either - get_without_side_effects() is used to solve this, it's not perfect but something we can revisit later. I did some refactoring along the way, there was some really old stuff in there - accessing vm.call_frame().arguments[0] is not something we (have to) do anymore :^) Fixes #6245.
86 lines
3.5 KiB
C++
86 lines
3.5 KiB
C++
/*
|
|
* Copyright (c) 2021, Andreas Kling <kling@serenityos.org>
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions are met:
|
|
*
|
|
* 1. Redistributions of source code must retain the above copyright notice, this
|
|
* list of conditions and the following disclaimer.
|
|
*
|
|
* 2. Redistributions in binary form must reproduce the above copyright notice,
|
|
* this list of conditions and the following disclaimer in the documentation
|
|
* and/or other materials provided with the distribution.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
|
|
* AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
|
|
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
|
|
* DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
|
|
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
|
|
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
|
|
* SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
|
|
* CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
|
|
* OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
*/
|
|
|
|
#include <AK/ScopeGuard.h>
|
|
#include <LibWeb/Bindings/CSSStyleDeclarationWrapper.h>
|
|
#include <LibWeb/CSS/Parser/DeprecatedCSSParser.h>
|
|
#include <LibWeb/DOM/Element.h>
|
|
|
|
namespace Web::Bindings {
|
|
|
|
JS::Value CSSStyleDeclarationWrapper::get(const JS::PropertyName& name, JS::Value receiver, bool without_side_effects) const
|
|
{
|
|
// FIXME: These should actually use camelCase versions of the property names!
|
|
auto property_id = CSS::property_id_from_string(name.to_string());
|
|
if (property_id == CSS::PropertyID::Invalid)
|
|
return Base::get(name, receiver, without_side_effects);
|
|
for (auto& property : impl().properties()) {
|
|
if (property.property_id == property_id)
|
|
return js_string(vm(), property.value->to_string());
|
|
}
|
|
return js_string(vm(), String::empty());
|
|
}
|
|
|
|
bool CSSStyleDeclarationWrapper::put(const JS::PropertyName& name, JS::Value value, JS::Value receiver)
|
|
{
|
|
// FIXME: These should actually use camelCase versions of the property names!
|
|
auto property_id = CSS::property_id_from_string(name.to_string());
|
|
if (property_id == CSS::PropertyID::Invalid)
|
|
return Base::put(name, value, receiver);
|
|
|
|
auto css_text = value.to_string(global_object());
|
|
if (vm().exception())
|
|
return false;
|
|
|
|
auto new_value = parse_css_value(CSS::ParsingContext {}, css_text, property_id);
|
|
// FIXME: What are we supposed to do if we can't parse it?
|
|
if (!new_value)
|
|
return false;
|
|
|
|
ScopeGuard style_invalidation_guard = [&] {
|
|
auto& declaration = downcast<CSS::ElementInlineCSSStyleDeclaration>(impl());
|
|
if (auto* element = declaration.element())
|
|
element->invalidate_style();
|
|
};
|
|
|
|
// FIXME: I don't think '!important' is being handled correctly here..
|
|
|
|
for (auto& property : impl().m_properties) {
|
|
if (property.property_id == property_id) {
|
|
property.value = new_value.release_nonnull();
|
|
return true;
|
|
}
|
|
}
|
|
|
|
impl().m_properties.append(CSS::StyleProperty {
|
|
.property_id = property_id,
|
|
.value = new_value.release_nonnull(),
|
|
.important = false,
|
|
});
|
|
return true;
|
|
}
|
|
|
|
}
|